[INFO] fetching crate frugalos_raft 1.2.0... [INFO] checking frugalos_raft-1.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate frugalos_raft 1.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate frugalos_raft 1.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate frugalos_raft 1.2.0 [INFO] finished tweaking crates.io crate frugalos_raft 1.2.0 [INFO] tweaked toml for crates.io crate frugalos_raft 1.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding nom v2.2.1 (latest: v7.1.3) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding splay_tree v0.2.10 (latest: v0.3.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding trackable v0.2.24 (latest: v1.3.0) [INFO] [stderr] Adding uuid v0.7.4 (latest: v1.10.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3c6db2854c0d6c9ab89926651d9649ea5067cce377ef1ee225808f3956c5763 [INFO] running `Command { std: "docker" "start" "-a" "d3c6db2854c0d6c9ab89926651d9649ea5067cce377ef1ee225808f3956c5763", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3c6db2854c0d6c9ab89926651d9649ea5067cce377ef1ee225808f3956c5763", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3c6db2854c0d6c9ab89926651d9649ea5067cce377ef1ee225808f3956c5763", kill_on_drop: false }` [INFO] [stdout] d3c6db2854c0d6c9ab89926651d9649ea5067cce377ef1ee225808f3956c5763 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8573ec7640f294325344890a054d23156b42c81ab297abeaf16693a7d44c831f [INFO] running `Command { std: "docker" "start" "-a" "8573ec7640f294325344890a054d23156b42c81ab297abeaf16693a7d44c831f", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking atomic_immut v0.1.4 [INFO] [stderr] Compiling procinfo v0.4.2 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking splay_tree v0.2.10 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking nbchan v0.1.3 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking factory v0.1.2 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking fibers v0.1.13 [INFO] [stderr] Checking fibers_global v0.1.2 [INFO] [stderr] Compiling trackable_derive v1.0.0 [INFO] [stderr] Checking trackable v1.3.0 [INFO] [stderr] Checking trackable v0.2.24 [INFO] [stderr] Checking bytecodec v0.4.15 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking protobuf_codec v0.2.8 [INFO] [stderr] Checking prometrics v0.1.13 [INFO] [stderr] Checking tasque v0.1.5 [INFO] [stderr] Checking raftlog v0.6.0 [INFO] [stderr] Checking cannyls v0.10.0 [INFO] [stderr] Checking fibers_tasque v0.1.2 [INFO] [stderr] Checking fibers_rpc v0.3.4 [INFO] [stderr] Checking raftlog_protobuf v0.3.0 [INFO] [stderr] Checking frugalos_raft v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::client::RpcClient` [INFO] [stdout] --> src/rpc/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use self::client::RpcClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::server::RpcServer` [INFO] [stdout] --> src/rpc/mod.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub use self::server::RpcServer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `LoadLogPrefix` and `SaveLogPrefix` [INFO] [stdout] --> src/storage/mod.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | pub use self::log_prefix::{LoadLogPrefix, SaveLogPrefix}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `LoadLogSuffix` and `SaveLogSuffix` [INFO] [stdout] --> src/storage/mod.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub use self::log_suffix::{LoadLogSuffix, SaveLogSuffix}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::client::RpcClient` [INFO] [stdout] --> src/rpc/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use self::client::RpcClient; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::server::RpcServer` [INFO] [stdout] --> src/rpc/mod.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub use self::server::RpcServer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `LoadLogPrefix` and `SaveLogPrefix` [INFO] [stdout] --> src/storage/mod.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | pub use self::log_prefix::{LoadLogPrefix, SaveLogPrefix}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `LoadLogSuffix` and `SaveLogSuffix` [INFO] [stdout] --> src/storage/mod.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 17 | pub use self::log_suffix::{LoadLogSuffix, SaveLogSuffix}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/storage/mod.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | INITIALIZATION_LOCK.compare_and_swap(0, 1, atomic::Ordering::SeqCst) == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/storage/mod.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | INITIALIZATION_LOCK.compare_and_swap(0, 1, atomic::Ordering::SeqCst) == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `spawner` is never read [INFO] [stdout] --> src/rpc/mail.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Mailer { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | spawner: BoxSpawn, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mailer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 278 | pub fn deserialize<'de, D>(deserializer: D) -> Result<[u8; NODE_ID_SIZE], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | from_hex_str(&hex).map_err(de::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protobuf.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | fn into_raftlog_error(e: bytecodec::Error) -> raftlog::Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | raftlog::ErrorKind::InvalidInput.takes_over(e).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft_io.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 25 | service: ServiceHandle, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | storage: Storage, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | mailer: Mailer, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(RaftIo { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | logger: storage.logger(), [INFO] [stdout] 34 | | node_id, [INFO] [stdout] 35 | | service, [INFO] [stdout] ... | [INFO] [stdout] 38 | | timer, [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft_io.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | .map_err(|e| ErrorKind::Other.takes_over(e).into()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(spawner: S, rpc_service: ClientServiceHandle, metrics: Option) -> Self [INFO] [stdout] | ---------- -------------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let (message_tx, message_rx) = mpsc::channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Mailer { [INFO] [stdout] 29 | spawner: spawner.boxed(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:136:46 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | send_request_vote_call_messages: builder [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 137 | | .counter("send_messages_total") [INFO] [stdout] 138 | | .label("type", "request_vote_call") [INFO] [stdout] 139 | | .finish() [INFO] [stdout] 140 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:141:47 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | send_request_vote_reply_messages: builder [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 142 | | .counter("send_messages_total") [INFO] [stdout] 143 | | .label("type", "request_vote_reply") [INFO] [stdout] 144 | | .finish() [INFO] [stdout] 145 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:146:48 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | send_append_entries_call_messages: builder [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 147 | | .counter("send_messages_total") [INFO] [stdout] 148 | | .label("type", "append_entries_call") [INFO] [stdout] 149 | | .finish() [INFO] [stdout] 150 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:151:49 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | send_append_entries_reply_messages: builder [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 152 | | .counter("send_messages_total") [INFO] [stdout] 153 | | .label("type", "append_entries_reply") [INFO] [stdout] 154 | | .finish() [INFO] [stdout] 155 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:156:50 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | send_install_snapshot_cast_messages: builder [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 157 | | .counter("send_messages_total") [INFO] [stdout] 158 | | .label("type", "install_snapshot_cast") [INFO] [stdout] 159 | | .finish() [INFO] [stdout] 160 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:161:46 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | recv_request_vote_call_messages: builder [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 162 | | .counter("recv_messages_total") [INFO] [stdout] 163 | | .label("type", "request_vote_call") [INFO] [stdout] 164 | | .finish() [INFO] [stdout] 165 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:166:47 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | recv_request_vote_reply_messages: builder [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 167 | | .counter("recv_messages_total") [INFO] [stdout] 168 | | .label("type", "request_vote_reply") [INFO] [stdout] 169 | | .finish() [INFO] [stdout] 170 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:171:48 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | recv_append_entries_call_messages: builder [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 172 | | .counter("recv_messages_total") [INFO] [stdout] 173 | | .label("type", "append_entries_call") [INFO] [stdout] 174 | | .finish() [INFO] [stdout] 175 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:176:49 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | recv_append_entries_reply_messages: builder [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 177 | | .counter("recv_messages_total") [INFO] [stdout] 178 | | .label("type", "append_entries_reply") [INFO] [stdout] 179 | | .finish() [INFO] [stdout] 180 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:181:50 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | recv_install_snapshot_cast_messages: builder [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 182 | | .counter("recv_messages_total") [INFO] [stdout] 183 | | .label("type", "install_snapshot_cast") [INFO] [stdout] 184 | | .finish() [INFO] [stdout] 185 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/server.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(service: ServiceHandle) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | metrics: Metrics::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/server.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 78 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | unknown_node_messages: builder [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 82 | | .counter("unknown_node_messages_total") [INFO] [stdout] 83 | | .finish() [INFO] [stdout] 84 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/server.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 78 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | downed_node_messages: builder [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 86 | | .counter("downed_node_messages_total") [INFO] [stdout] 87 | | .finish() [INFO] [stdout] 88 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 66 | logger: Logger, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | node_id: LocalNodeId, [INFO] [stdout] 68 | device: DeviceHandle, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | metrics: StorageMetrics, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> Self { [INFO] [stdout] 71 | let (event_tx, event_rx) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Storage { [INFO] [stdout] 73 | handle: Handle { [INFO] [stdout] | _____________________^ [INFO] [stdout] 74 | | logger, [INFO] [stdout] 75 | | node_id, [INFO] [stdout] 76 | | device, [INFO] [stdout] 77 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:161:30 [INFO] [stdout] | [INFO] [stdout] 116 | let future = if let Some(end) = end { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let future = log_prefix::LoadLogPrefix::new(self); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Err(e) => log::LoadLogInner::Failed(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let future = log_prefix::LoadLogPrefix::new(self); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let next = Some(log_suffix::LoadLogSuffix::new(self)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | LoadLog::new(future, self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:188:22 [INFO] [stdout] | [INFO] [stdout] 183 | let future = if let Err(e) = track!(self.append_to_local_buffer(suffix)) { [INFO] [stdout] | ------ - ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | SaveLog::new(log::SaveLogInner::Suffix(future), self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:188:57 [INFO] [stdout] | [INFO] [stdout] 183 | let future = if let Err(e) = track!(self.append_to_local_buffer(suffix)) { [INFO] [stdout] | ------ - ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | SaveLog::new(log::SaveLogInner::Suffix(future), self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 201 | let inner = if let Err(e) = track!(self.poll_and_handle_event()) { [INFO] [stdout] | ----- - ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | SaveLog::new(inner, self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/ballot.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 23 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let future = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let future = into_box_future(future); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/ballot.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 72 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let future = match track!(protobuf::encode_ballot(ballot)) { [INFO] [stdout] | ------ --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Err(e) => Either::B(futures::failed(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/delete.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn new(handle: Handle, old_index: Range) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | future: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/delete.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn new(handle: Handle, old_entries: Range) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let future = Self::delete(&handle, &old_entries); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok(DeleteOldLogEntries { handle, future }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/load.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 26 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let phase = Phase::A(LoadLogPrefixIndex::new(handle.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/load.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn new(handle: Handle, prefix_index: Range) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | future: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:64:23 [INFO] [stdout] | [INFO] [stdout] 46 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let phase = Phase5::A(LoadLogPrefixIndex::new(handle.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | event_tx: storage.event_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 46 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let phase = Phase5::A(LoadLogPrefixIndex::new(handle.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn new(handle: Handle, old_index: Range, prefix: LogPrefix) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let prefix_bytes = track!(protobuf::encode_log_prefix(prefix))?; [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(SaveLogPrefixBytes { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | handle, [INFO] [stdout] 147 | | current_index: prefix_index.start, [INFO] [stdout] 148 | | prefix_index, [INFO] [stdout] 149 | | prefix_bytes, [INFO] [stdout] 150 | | future: None, [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn new(handle: Handle, index: Range) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let lump_id = handle.node_id.to_log_prefix_index_lump_id(); [INFO] [stdout] 202 | let bytes = track!(protobuf::encode_log_prefix_index(index.clone()))?; [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let future = into_box_future( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(SaveLogPrefixIndex { handle, future }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | handle: handle.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | future: LoadLogEntry::new(handle, head.index), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | event_tx: storage.event_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:148:22 [INFO] [stdout] | [INFO] [stdout] 133 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let future = Either::A(futures::done(Ok(true))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn failed(storage: &Storage, e: Error) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | SaveLogSuffix { [INFO] [stdout] 153 | handle: storage.handle.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn failed(storage: &Storage, e: Error) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | future: Either::A(futures::done(Err(e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:158:22 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn failed(storage: &Storage, e: Error) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timer.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 63 | .map_err(|e| RaftErrorKind::Other.cause(e).into(),)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 42 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frugalos_raft` (lib) due to 43 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `spawner` is never read [INFO] [stdout] --> src/rpc/mail.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Mailer { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | spawner: BoxSpawn, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mailer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 278 | pub fn deserialize<'de, D>(deserializer: D) -> Result<[u8; NODE_ID_SIZE], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | from_hex_str(&hex).map_err(de::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protobuf.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | fn into_raftlog_error(e: bytecodec::Error) -> raftlog::Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | raftlog::ErrorKind::InvalidInput.takes_over(e).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft_io.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 25 | service: ServiceHandle, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | storage: Storage, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | mailer: Mailer, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(RaftIo { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | logger: storage.logger(), [INFO] [stdout] 34 | | node_id, [INFO] [stdout] 35 | | service, [INFO] [stdout] ... | [INFO] [stdout] 38 | | timer, [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft_io.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | .map_err(|e| ErrorKind::Other.takes_over(e).into()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(spawner: S, rpc_service: ClientServiceHandle, metrics: Option) -> Self [INFO] [stdout] | ---------- -------------------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let (message_tx, message_rx) = mpsc::channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Mailer { [INFO] [stdout] 29 | spawner: spawner.boxed(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:136:46 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | send_request_vote_call_messages: builder [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 137 | | .counter("send_messages_total") [INFO] [stdout] 138 | | .label("type", "request_vote_call") [INFO] [stdout] 139 | | .finish() [INFO] [stdout] 140 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:141:47 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | send_request_vote_reply_messages: builder [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 142 | | .counter("send_messages_total") [INFO] [stdout] 143 | | .label("type", "request_vote_reply") [INFO] [stdout] 144 | | .finish() [INFO] [stdout] 145 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:146:48 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | send_append_entries_call_messages: builder [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 147 | | .counter("send_messages_total") [INFO] [stdout] 148 | | .label("type", "append_entries_call") [INFO] [stdout] 149 | | .finish() [INFO] [stdout] 150 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:151:49 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | send_append_entries_reply_messages: builder [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 152 | | .counter("send_messages_total") [INFO] [stdout] 153 | | .label("type", "append_entries_reply") [INFO] [stdout] 154 | | .finish() [INFO] [stdout] 155 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:156:50 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | send_install_snapshot_cast_messages: builder [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 157 | | .counter("send_messages_total") [INFO] [stdout] 158 | | .label("type", "install_snapshot_cast") [INFO] [stdout] 159 | | .finish() [INFO] [stdout] 160 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:161:46 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | recv_request_vote_call_messages: builder [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 162 | | .counter("recv_messages_total") [INFO] [stdout] 163 | | .label("type", "request_vote_call") [INFO] [stdout] 164 | | .finish() [INFO] [stdout] 165 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:166:47 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | recv_request_vote_reply_messages: builder [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 167 | | .counter("recv_messages_total") [INFO] [stdout] 168 | | .label("type", "request_vote_reply") [INFO] [stdout] 169 | | .finish() [INFO] [stdout] 170 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:171:48 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | recv_append_entries_call_messages: builder [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 172 | | .counter("recv_messages_total") [INFO] [stdout] 173 | | .label("type", "append_entries_call") [INFO] [stdout] 174 | | .finish() [INFO] [stdout] 175 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:176:49 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | recv_append_entries_reply_messages: builder [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 177 | | .counter("recv_messages_total") [INFO] [stdout] 178 | | .label("type", "append_entries_reply") [INFO] [stdout] 179 | | .finish() [INFO] [stdout] 180 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/mail.rs:181:50 [INFO] [stdout] | [INFO] [stdout] 133 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | recv_install_snapshot_cast_messages: builder [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 182 | | .counter("recv_messages_total") [INFO] [stdout] 183 | | .label("type", "install_snapshot_cast") [INFO] [stdout] 184 | | .finish() [INFO] [stdout] 185 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/server.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(service: ServiceHandle) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | metrics: Metrics::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/server.rs:81:36 [INFO] [stdout] | [INFO] [stdout] 78 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | unknown_node_messages: builder [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 82 | | .counter("unknown_node_messages_total") [INFO] [stdout] 83 | | .finish() [INFO] [stdout] 84 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc/server.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 78 | let mut builder = MetricBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | downed_node_messages: builder [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 86 | | .counter("downed_node_messages_total") [INFO] [stdout] 87 | | .finish() [INFO] [stdout] 88 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 66 | logger: Logger, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | node_id: LocalNodeId, [INFO] [stdout] 68 | device: DeviceHandle, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | metrics: StorageMetrics, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | ) -> Self { [INFO] [stdout] 71 | let (event_tx, event_rx) = mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Storage { [INFO] [stdout] 73 | handle: Handle { [INFO] [stdout] | _____________________^ [INFO] [stdout] 74 | | logger, [INFO] [stdout] 75 | | node_id, [INFO] [stdout] 76 | | device, [INFO] [stdout] 77 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:161:30 [INFO] [stdout] | [INFO] [stdout] 116 | let future = if let Some(end) = end { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let future = log_prefix::LoadLogPrefix::new(self); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Err(e) => log::LoadLogInner::Failed(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let future = log_prefix::LoadLogPrefix::new(self); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let next = Some(log_suffix::LoadLogSuffix::new(self)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | LoadLog::new(future, self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:188:22 [INFO] [stdout] | [INFO] [stdout] 183 | let future = if let Err(e) = track!(self.append_to_local_buffer(suffix)) { [INFO] [stdout] | ------ - ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | SaveLog::new(log::SaveLogInner::Suffix(future), self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:188:57 [INFO] [stdout] | [INFO] [stdout] 183 | let future = if let Err(e) = track!(self.append_to_local_buffer(suffix)) { [INFO] [stdout] | ------ - ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | SaveLog::new(log::SaveLogInner::Suffix(future), self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/mod.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 201 | let inner = if let Err(e) = track!(self.poll_and_handle_event()) { [INFO] [stdout] | ----- - ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | SaveLog::new(inner, self.metrics.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/ballot.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 23 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let future = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let future = into_box_future(future); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/ballot.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 72 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let future = match track!(protobuf::encode_ballot(ballot)) { [INFO] [stdout] | ------ --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Err(e) => Either::B(futures::failed(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/delete.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn new(handle: Handle, old_index: Range) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | future: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/delete.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn new(handle: Handle, old_entries: Range) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let future = Self::delete(&handle, &old_entries); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok(DeleteOldLogEntries { handle, future }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/delete.rs:167:11 [INFO] [stdout] | [INFO] [stdout] 158 | fn run_test(proposal_size: usize, f: F) -> TestResult [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let mut system = new_system(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | f((system, leader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/load.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 26 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let phase = Phase::A(LoadLogPrefixIndex::new(handle.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/load.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 156 | pub fn new(handle: Handle, prefix_index: Range) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | future: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:64:23 [INFO] [stdout] | [INFO] [stdout] 46 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let phase = Phase5::A(LoadLogPrefixIndex::new(handle.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | event_tx: storage.event_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 46 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let phase = Phase5::A(LoadLogPrefixIndex::new(handle.clone())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn new(handle: Handle, old_index: Range, prefix: LogPrefix) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let prefix_bytes = track!(protobuf::encode_log_prefix(prefix))?; [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(SaveLogPrefixBytes { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | handle, [INFO] [stdout] 147 | | current_index: prefix_index.start, [INFO] [stdout] 148 | | prefix_index, [INFO] [stdout] 149 | | prefix_bytes, [INFO] [stdout] 150 | | future: None, [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_prefix/save.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn new(handle: Handle, index: Range) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let lump_id = handle.node_id.to_log_prefix_index_lump_id(); [INFO] [stdout] 202 | let bytes = track!(protobuf::encode_log_prefix_index(index.clone()))?; [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let future = into_box_future( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(SaveLogPrefixIndex { handle, future }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | handle: handle.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | future: LoadLogEntry::new(handle, head.index), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | event_tx: storage.event_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 31 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:148:22 [INFO] [stdout] | [INFO] [stdout] 133 | let handle = storage.handle.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let future = Either::A(futures::done(Ok(true))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn failed(storage: &Storage, e: Error) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | SaveLogSuffix { [INFO] [stdout] 153 | handle: storage.handle.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn failed(storage: &Storage, e: Error) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | future: Either::A(futures::done(Err(e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/log_suffix.rs:158:22 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn failed(storage: &Storage, e: Error) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | metrics: storage.metrics.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_util.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 41 | let logger = Logger::root(Discard, o!()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let mut rpc_server_builder = ServerBuilder::new(([127, 0, 0, 1], 0).into()); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | [INFO] [stdout] 44 | let service = Service::new(logger, &mut rpc_server_builder); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let service_handle = service.handle(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let rpc_server = rpc_server_builder.finish(fibers_global::handle()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let (rpc_server, bind_addr) = track!(fibers_global::execute(rpc_server.local_addr()))?; [INFO] [stdout] | ---------- ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | fibers_global::spawn(rpc_server.map_err(|e| panic!("{}", e))); [INFO] [stdout] 51 | let rpc_service = ClientService::new(fibers_global::handle()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let rpc_service_handle = rpc_service.handle(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(System { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | raft_service: service_handle, [INFO] [stdout] 57 | | rpc_service: rpc_service_handle, [INFO] [stdout] 58 | | rpc_server_addr: bind_addr, [INFO] [stdout] ... | [INFO] [stdout] 63 | | devices: Vec::new(), [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_util.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 157 | let mailer = Mailer::new(fibers_global::handle(), self.rpc_service.clone(), None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let logger = Logger::root(Discard, o!()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let nvm = MemoryNvm::new(vec![0; 10 * 1024 * 1024]); [INFO] [stdout] 169 | let device = DeviceBuilder::new().spawn(|| track!(cannyls::storage::Storage::create(nvm))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | let storage = Storage::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let handle = storage.handle(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let io = track!(RaftIo::new( [INFO] [stdout] | _____________--___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | | self.raft_service.clone(), [INFO] [stdout] 179 | | storage, [INFO] [stdout] 180 | | mailer, [INFO] [stdout] 181 | | timer [INFO] [stdout] 182 | | ))?; [INFO] [stdout] | |__________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | [INFO] [stdout] 184 | Ok((node_id, io, device, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frugalos_raft` (lib test) due to 47 previous errors; 6 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_util.rs:221:7 [INFO] [stdout] | [INFO] [stdout] 214 | pub(crate) fn run_test_with_storage(node_id: LocalNodeId, f: F) -> TestResult [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | let logger = Logger::root(Discard, o!()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let device = track!(spawn_memory_device(1024 * 1024))?; [INFO] [stdout] | ------ ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let storage = Storage::new(logger, node_id, device.handle(), StorageMetrics::new()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | f((storage, device)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timer.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 63 | .map_err(|e| RaftErrorKind::Other.cause(e).into(),)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 46 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "8573ec7640f294325344890a054d23156b42c81ab297abeaf16693a7d44c831f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8573ec7640f294325344890a054d23156b42c81ab297abeaf16693a7d44c831f", kill_on_drop: false }` [INFO] [stdout] 8573ec7640f294325344890a054d23156b42c81ab297abeaf16693a7d44c831f