[INFO] fetching crate frost-dalek 0.2.3... [INFO] checking frost-dalek-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate frost-dalek 0.2.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate frost-dalek 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate frost-dalek 0.2.3 [INFO] finished tweaking crates.io crate frost-dalek 0.2.3 [INFO] tweaked toml for crates.io crate frost-dalek 0.2.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 98 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding libm v0.1.4 (latest: v0.2.8) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 15c505203c1492bd6f431469e08d87ecf0b93c2dc16927e2e5cf16f026e9452e [INFO] running `Command { std: "docker" "start" "-a" "15c505203c1492bd6f431469e08d87ecf0b93c2dc16927e2e5cf16f026e9452e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "15c505203c1492bd6f431469e08d87ecf0b93c2dc16927e2e5cf16f026e9452e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15c505203c1492bd6f431469e08d87ecf0b93c2dc16927e2e5cf16f026e9452e", kill_on_drop: false }` [INFO] [stdout] 15c505203c1492bd6f431469e08d87ecf0b93c2dc16927e2e5cf16f026e9452e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b2847df05d7ad37cc94af20be375df8124bbf0b0d3140b42df4a12cb5c29afaf [INFO] running `Command { std: "docker" "start" "-a" "b2847df05d7ad37cc94af20be375df8124bbf0b0d3140b42df4a12cb5c29afaf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking frost-dalek v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `secret_share`, `public_key`, and `group_key` are never read [INFO] [stdout] --> src/keygen.rs:213:16 [INFO] [stdout] | [INFO] [stdout] 212 | pub struct DealtParticipant { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 213 | pub(crate) secret_share: SecretShare, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 214 | pub(crate) public_key: IndividualPublicKey, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 215 | pub(crate) group_key: RistrettoPoint, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DealtParticipant` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/keygen.rs:385:5 [INFO] [stdout] | [INFO] [stdout] 383 | pub struct DistributedKeyGeneration { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] 384 | state: Box, [INFO] [stdout] 385 | data: S, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DistributedKeyGeneration` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `parameters` is never read [INFO] [stdout] --> src/signature.rs:365:16 [INFO] [stdout] | [INFO] [stdout] 363 | pub(crate) struct AggregatorState { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 364 | /// The protocol instance parameters. [INFO] [stdout] 365 | pub(crate) parameters: Parameters, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AggregatorState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keygen.rs:515:12 [INFO] [stdout] | [INFO] [stdout] 499 | let mut their_secret_shares: Vec = Vec::with_capacity(parameters.n as usize - 1); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 506 | let my_secret_share = SecretShare::evaluate_polynomial(my_index, my_coefficients); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | let state = ActualState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | Ok(DistributedKeyGeneration:: { [INFO] [stdout] | ____________^ [INFO] [stdout] 516 | | state: Box::new(state), [INFO] [stdout] 517 | | data: RoundOne {}, [INFO] [stdout] 518 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keygen.rs:561:12 [INFO] [stdout] | [INFO] [stdout] 533 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 534 | my_secret_shares: Vec, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 561 | Ok(DistributedKeyGeneration:: { [INFO] [stdout] | ____________^ [INFO] [stdout] 562 | | state: self.state, [INFO] [stdout] 563 | | data: RoundTwo {}, [INFO] [stdout] 564 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keygen.rs:643:12 [INFO] [stdout] | [INFO] [stdout] 636 | pub fn finish(mut self, my_commitment: &RistrettoPoint) -> Result<(GroupKey, SecretKey), ()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 637 | let secret_key = self.calculate_signing_key()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | Ok((group_key, secret_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/precomputation.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 42 | fn from(other: NoncePair) -> CommitmentShare { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | hiding: Commitment { [INFO] [stdout] | _____________________^ [INFO] [stdout] 48 | | nonce: other.0, [INFO] [stdout] 49 | | sealed: x, [INFO] [stdout] 50 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/precomputation.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 42 | fn from(other: NoncePair) -> CommitmentShare { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | binding: Commitment { [INFO] [stdout] | ______________________^ [INFO] [stdout] 52 | | nonce: other.1, [INFO] [stdout] 53 | | sealed: y, [INFO] [stdout] 54 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/precomputation.rs:168:6 [INFO] [stdout] | [INFO] [stdout] 150 | mut csprng: impl CryptoRng + Rng, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let mut commitments: Vec = Vec::with_capacity(number_of_shares); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | SecretCommitmentShareList { commitments }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signature.rs:571:12 [INFO] [stdout] | [INFO] [stdout] 539 | pub fn finalize(mut self) -> Result, HashMap> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 571 | Ok(SignatureAggregator { state: self.state, aggregator: Finalized { message_hash } }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frost-dalek` (lib) due to 8 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b2847df05d7ad37cc94af20be375df8124bbf0b0d3140b42df4a12cb5c29afaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2847df05d7ad37cc94af20be375df8124bbf0b0d3140b42df4a12cb5c29afaf", kill_on_drop: false }` [INFO] [stdout] b2847df05d7ad37cc94af20be375df8124bbf0b0d3140b42df4a12cb5c29afaf