[INFO] crate froggy 0.4.2 is already in cache [INFO] checking froggy-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate froggy 0.4.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate froggy 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate froggy 0.4.2 [INFO] finished tweaking crates.io crate froggy 0.4.2 [INFO] tweaked toml for crates.io crate froggy 0.4.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] [stderr] Adding spin v0.4.10 (latest: v0.9.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d30b8c3f4879a18d17b3cf5a1ef5d64354587e4298d1c958474604a70b54bbe2 [INFO] running `Command { std: "docker" "start" "-a" "d30b8c3f4879a18d17b3cf5a1ef5d64354587e4298d1c958474604a70b54bbe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d30b8c3f4879a18d17b3cf5a1ef5d64354587e4298d1c958474604a70b54bbe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d30b8c3f4879a18d17b3cf5a1ef5d64354587e4298d1c958474604a70b54bbe2", kill_on_drop: false }` [INFO] [stdout] d30b8c3f4879a18d17b3cf5a1ef5d64354587e4298d1c958474604a70b54bbe2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98d98d46488eca3f240ece22957b6d32c1b7c777ba64d152aed6ea3d1c3d00be [INFO] running `Command { std: "docker" "start" "-a" "98d98d46488eca3f240ece22957b6d32c1b7c777ba64d152aed6ea3d1c3d00be", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking spin v0.4.10 [INFO] [stderr] Checking froggy v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/lib.rs:35:48 [INFO] [stdout] | [INFO] [stdout] 35 | use std::sync::atomic::{AtomicUsize, Ordering, ATOMIC_USIZE_INIT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/lib.rs:35:48 [INFO] [stdout] | [INFO] [stdout] 35 | use std::sync::atomic::{AtomicUsize, Ordering, ATOMIC_USIZE_INIT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/lib.rs:54:35 [INFO] [stdout] | [INFO] [stdout] 54 | static STORAGE_UID: AtomicUsize = ATOMIC_USIZE_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 54 | static STORAGE_UID: AtomicUsize = AtomicUsize::new(0); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/lib.rs:54:35 [INFO] [stdout] | [INFO] [stdout] 54 | static STORAGE_UID: AtomicUsize = ATOMIC_USIZE_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 54 | static STORAGE_UID: AtomicUsize = AtomicUsize::new(0); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `index`, `epoch`, `storage_id`, and `pending` are never read [INFO] [stdout] --> src/lib.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 163 | pub struct Pointer<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 164 | /// All integer entries are `usize` for future-proofing. [INFO] [stdout] 165 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 166 | epoch: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 167 | storage_id: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 168 | pending: &'a Pending, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Pointer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:292:20 [INFO] [stdout] | [INFO] [stdout] 287 | fn new_impl(data: Vec, meta: Vec, epoch: Vec) -> Storage { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | inner: StorageInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 293 | | data: data, [INFO] [stdout] 294 | | meta: meta, [INFO] [stdout] 295 | | free_list: Vec::new(), [INFO] [stdout] 296 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:297:22 [INFO] [stdout] | [INFO] [stdout] 287 | fn new_impl(data: Vec, meta: Vec, epoch: Vec) -> Storage { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | pending: Arc::new(Mutex::new(Pending { [INFO] [stdout] | ______________________^ [INFO] [stdout] 298 | | add_ref: Vec::new(), [INFO] [stdout] 299 | | sub_ref: Vec::new(), [INFO] [stdout] 300 | | epoch: epoch, [INFO] [stdout] 301 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:405:22 [INFO] [stdout] | [INFO] [stdout] 397 | let mut pending = self.pending.lock(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | pending: self.pending.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:466:22 [INFO] [stdout] | [INFO] [stdout] 447 | pub fn create(&mut self, value: T) -> Pointer { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 466 | pending: self.pending.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursor.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 104 | let mut pending = self.pending.lock(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | pending: self.pending.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/weak.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 53 | let mut pending = self.pending.lock(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Pointer { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | data: self.data, [INFO] [stdout] 60 | | pending: self.pending.clone(), [INFO] [stdout] 61 | | marker: PhantomData, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `froggy` (lib) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `index`, `epoch`, `storage_id`, and `pending` are never read [INFO] [stdout] --> src/lib.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 163 | pub struct Pointer<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 164 | /// All integer entries are `usize` for future-proofing. [INFO] [stdout] 165 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 166 | epoch: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 167 | storage_id: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 168 | pending: &'a Pending, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Pointer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:292:20 [INFO] [stdout] | [INFO] [stdout] 287 | fn new_impl(data: Vec, meta: Vec, epoch: Vec) -> Storage { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | inner: StorageInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 293 | | data: data, [INFO] [stdout] 294 | | meta: meta, [INFO] [stdout] 295 | | free_list: Vec::new(), [INFO] [stdout] 296 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:297:22 [INFO] [stdout] | [INFO] [stdout] 287 | fn new_impl(data: Vec, meta: Vec, epoch: Vec) -> Storage { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | pending: Arc::new(Mutex::new(Pending { [INFO] [stdout] | ______________________^ [INFO] [stdout] 298 | | add_ref: Vec::new(), [INFO] [stdout] 299 | | sub_ref: Vec::new(), [INFO] [stdout] 300 | | epoch: epoch, [INFO] [stdout] 301 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:405:22 [INFO] [stdout] | [INFO] [stdout] 397 | let mut pending = self.pending.lock(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | pending: self.pending.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:466:22 [INFO] [stdout] | [INFO] [stdout] 447 | pub fn create(&mut self, value: T) -> Pointer { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 466 | pending: self.pending.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursor.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 104 | let mut pending = self.pending.lock(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | pending: self.pending.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/weak.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 53 | let mut pending = self.pending.lock(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Pointer { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | data: self.data, [INFO] [stdout] 60 | | pending: self.pending.clone(), [INFO] [stdout] 61 | | marker: PhantomData, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `froggy` (lib test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "98d98d46488eca3f240ece22957b6d32c1b7c777ba64d152aed6ea3d1c3d00be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98d98d46488eca3f240ece22957b6d32c1b7c777ba64d152aed6ea3d1c3d00be", kill_on_drop: false }` [INFO] [stdout] 98d98d46488eca3f240ece22957b6d32c1b7c777ba64d152aed6ea3d1c3d00be