[INFO] fetching crate frnsc-hive 0.13.1... [INFO] checking frnsc-hive-0.13.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate frnsc-hive 0.13.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate frnsc-hive 0.13.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate frnsc-hive 0.13.1 [INFO] finished tweaking crates.io crate frnsc-hive 0.13.1 [INFO] tweaked toml for crates.io crate frnsc-hive 0.13.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 066d6b93423ca392dc8b1b17a04aad9609b656133e3fcac264b0886c6bbcc5ee [INFO] running `Command { std: "docker" "start" "-a" "066d6b93423ca392dc8b1b17a04aad9609b656133e3fcac264b0886c6bbcc5ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "066d6b93423ca392dc8b1b17a04aad9609b656133e3fcac264b0886c6bbcc5ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "066d6b93423ca392dc8b1b17a04aad9609b656133e3fcac264b0886c6bbcc5ee", kill_on_drop: false }` [INFO] [stdout] 066d6b93423ca392dc8b1b17a04aad9609b656133e3fcac264b0886c6bbcc5ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 04ee78dc1211561e57cba3dae80af88570d0961eebd6fa5aebb788b3890fc0cb [INFO] running `Command { std: "docker" "start" "-a" "04ee78dc1211561e57cba3dae80af88570d0961eebd6fa5aebb788b3890fc0cb", kill_on_drop: false }` [INFO] [stderr] Checking forensic-rs v0.13.0 [INFO] [stderr] Checking frnsc-hive v0.13.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `fixed` is never read [INFO] [stdout] --> src/cell_cache.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct CachedCell { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | pub fixed: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CachedCell` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/mounted_map.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub struct MountedCell { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 56 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `location` and `mounted_cache` are never read [INFO] [stdout] --> src/reader.rs:337:16 [INFO] [stdout] | [INFO] [stdout] 336 | pub struct HiveFiles { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 337 | pub(crate) location: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 345 | pub(crate) mounted_cache: BTreeMap, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `others_hive_by_position` is never used [INFO] [stdout] --> src/reader.rs:1629:15 [INFO] [stdout] | [INFO] [stdout] 1629 | pub(crate) fn others_hive_by_position(position: u16, offset: isize) -> RegHiveKey { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn from_fs(mut fs: Box) -> ForensicResult> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut reader = Self::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Box::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 349 | pub fn new(location: PathBuf, mut primary: Box) -> ForensicResult { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 370 | | location, [INFO] [stdout] 371 | | base_block, [INFO] [stdout] 372 | | primary, [INFO] [stdout] ... | [INFO] [stdout] 378 | | mounted_cache: BTreeMap::new(), [INFO] [stdout] 379 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:659:13 [INFO] [stdout] | [INFO] [stdout] 658 | fn from_file(&self, _file: Box) -> ForensicResult> { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 659 | Err(ForensicError::bad_format_str( [INFO] [stdout] | _____________^ [INFO] [stdout] 660 | | "Cannot create HiveRegistryReader from file", [INFO] [stdout] 661 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:1412:13 [INFO] [stdout] | [INFO] [stdout] 1340 | let mut borrow_hive = hive.borrow_mut(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1412 | Err(ForensicError::NoMoreData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fixed` is never read [INFO] [stdout] --> src/cell_cache.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct CachedCell { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | pub fixed: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CachedCell` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/mounted_map.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub struct MountedCell { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 56 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `location` and `mounted_cache` are never read [INFO] [stdout] --> src/reader.rs:337:16 [INFO] [stdout] | [INFO] [stdout] 336 | pub struct HiveFiles { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 337 | pub(crate) location: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 345 | pub(crate) mounted_cache: BTreeMap, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `others_hive_by_position` is never used [INFO] [stdout] --> src/reader.rs:1629:15 [INFO] [stdout] | [INFO] [stdout] 1629 | pub(crate) fn others_hive_by_position(position: u16, offset: isize) -> RegHiveKey { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn from_fs(mut fs: Box) -> ForensicResult> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut reader = Self::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Box::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 349 | pub fn new(location: PathBuf, mut primary: Box) -> ForensicResult { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 370 | | location, [INFO] [stdout] 371 | | base_block, [INFO] [stdout] 372 | | primary, [INFO] [stdout] ... | [INFO] [stdout] 378 | | mounted_cache: BTreeMap::new(), [INFO] [stdout] 379 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:659:13 [INFO] [stdout] | [INFO] [stdout] 658 | fn from_file(&self, _file: Box) -> ForensicResult> { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 659 | Err(ForensicError::bad_format_str( [INFO] [stdout] | _____________^ [INFO] [stdout] 660 | | "Cannot create HiveRegistryReader from file", [INFO] [stdout] 661 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:1412:13 [INFO] [stdout] | [INFO] [stdout] 1340 | let mut borrow_hive = hive.borrow_mut(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1412 | Err(ForensicError::NoMoreData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frnsc-hive` (lib) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frnsc-hive` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "04ee78dc1211561e57cba3dae80af88570d0961eebd6fa5aebb788b3890fc0cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04ee78dc1211561e57cba3dae80af88570d0961eebd6fa5aebb788b3890fc0cb", kill_on_drop: false }` [INFO] [stdout] 04ee78dc1211561e57cba3dae80af88570d0961eebd6fa5aebb788b3890fc0cb