[INFO] fetching crate freighter-storage 1.0.1... [INFO] checking freighter-storage-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate freighter-storage 1.0.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate freighter-storage 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate freighter-storage 1.0.1 [INFO] finished tweaking crates.io crate freighter-storage 1.0.1 [INFO] tweaked toml for crates.io crate freighter-storage 1.0.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 188 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding axum v0.6.20 (latest: v0.7.5) [INFO] [stderr] Adding axum-core v0.3.4 (latest: v0.4.3) [INFO] [stderr] Adding base16ct v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding crypto-bigint v0.4.9 (latest: v0.5.5) [INFO] [stderr] Adding der v0.6.1 (latest: v0.7.9) [INFO] [stderr] Adding ecdsa v0.14.8 (latest: v0.16.9) [INFO] [stderr] Adding elliptic-curve v0.12.3 (latest: v0.13.8) [INFO] [stderr] Adding ff v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding group v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchit v0.7.3 (latest: v0.8.4) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding p256 v0.11.1 (latest: v0.13.2) [INFO] [stderr] Adding pkcs8 v0.9.0 (latest: v0.10.2) [INFO] [stderr] Adding rfc6979 v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding sec1 v0.3.0 (latest: v0.7.3) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding spki v0.6.0 (latest: v0.7.3) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5be2d15e6e9cd551bcbfc56987fd7702fd14b9d7eb4642a9db1be6677b47682c [INFO] running `Command { std: "docker" "start" "-a" "5be2d15e6e9cd551bcbfc56987fd7702fd14b9d7eb4642a9db1be6677b47682c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5be2d15e6e9cd551bcbfc56987fd7702fd14b9d7eb4642a9db1be6677b47682c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5be2d15e6e9cd551bcbfc56987fd7702fd14b9d7eb4642a9db1be6677b47682c", kill_on_drop: false }` [INFO] [stdout] 5be2d15e6e9cd551bcbfc56987fd7702fd14b9d7eb4642a9db1be6677b47682c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64aa530a6f9d45b83de47569d393117c34295ae8e12ac52c3218b09d7f50e352 [INFO] running `Command { std: "docker" "start" "-a" "64aa530a6f9d45b83de47569d393117c34295ae8e12ac52c3218b09d7f50e352", kill_on_drop: false }` [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking aws-smithy-types v1.2.4 [INFO] [stderr] Checking aws-smithy-eventstream v0.60.4 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking aws-smithy-http v0.60.10 [INFO] [stderr] Checking aws-credential-types v1.2.1 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking aws-smithy-checksums v0.60.12 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.7.1 [INFO] [stderr] Checking aws-runtime v1.4.2 [INFO] [stderr] Checking aws-sdk-s3 v1.47.0 [INFO] [stderr] Checking freighter-api-types v1.0.0 [INFO] [stderr] Checking freighter-storage v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3_client.rs:189:98 [INFO] [stdout] | [INFO] [stdout] 189 | async fn put_file(&self, path: &str, file_bytes: Bytes, meta: Metadata) -> StorageResult<()> { [INFO] [stdout] | __________________________________________-----------------_______________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | | self.put_object(path.into(), file_bytes.into(), meta).await [INFO] [stdout] 191 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3_client.rs:198:28 [INFO] [stdout] | [INFO] [stdout] 196 | file_bytes: Bytes, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | meta: Metadata, [INFO] [stdout] 198 | ) -> StorageResult<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 199 | | let mut all_data = match self.pull_object(path.into()).await { [INFO] [stdout] 200 | | Ok(data) => Vec::from(data), [INFO] [stdout] 201 | | Err(StorageError::NotFound) => Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 205 | | self.put_object(path.into(), all_data.into(), meta).await [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3_client.rs:230:28 [INFO] [stdout] | [INFO] [stdout] 228 | crate_bytes: Bytes, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | sha256: [u8; 32], [INFO] [stdout] 230 | ) -> StorageResult<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 231 | | let len = crate_bytes.len(); [INFO] [stdout] 232 | | let path = construct_path(name, version); [INFO] [stdout] 233 | | self.put_object( [INFO] [stdout] ... | [INFO] [stdout] 245 | | .await [INFO] [stdout] 246 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:38:99 [INFO] [stdout] | [INFO] [stdout] 38 | async fn put_file(&self, path: &str, file_bytes: Bytes, _meta: Metadata) -> StorageResult<()> { [INFO] [stdout] | __________________________________________-----------------________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | | let path = self.abs_path(path)?; [INFO] [stdout] 40 | | let parent = path.parent().unwrap(); [INFO] [stdout] 41 | | if !parent.exists() { [INFO] [stdout] ... | [INFO] [stdout] 47 | | Ok(()) [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:46:66 [INFO] [stdout] | [INFO] [stdout] 46 | tmp.persist(path).map_err(|e| StorageError::ServiceError(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:50:112 [INFO] [stdout] | [INFO] [stdout] 50 | async fn create_or_append_file(&self, path: &str, file_bytes: Bytes, _meta: Metadata) -> StorageResult<()> { [INFO] [stdout] | _______________________________________________________-----------------________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | | let path = self.abs_path(path)?; [INFO] [stdout] 52 | | let parent = path.parent().unwrap(); [INFO] [stdout] 53 | | if !parent.exists() { [INFO] [stdout] ... | [INFO] [stdout] 59 | | Ok(()) [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freighter-storage` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3_client.rs:189:98 [INFO] [stdout] | [INFO] [stdout] 189 | async fn put_file(&self, path: &str, file_bytes: Bytes, meta: Metadata) -> StorageResult<()> { [INFO] [stdout] | __________________________________________-----------------_______________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | | self.put_object(path.into(), file_bytes.into(), meta).await [INFO] [stdout] 191 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3_client.rs:198:28 [INFO] [stdout] | [INFO] [stdout] 196 | file_bytes: Bytes, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | meta: Metadata, [INFO] [stdout] 198 | ) -> StorageResult<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 199 | | let mut all_data = match self.pull_object(path.into()).await { [INFO] [stdout] 200 | | Ok(data) => Vec::from(data), [INFO] [stdout] 201 | | Err(StorageError::NotFound) => Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 205 | | self.put_object(path.into(), all_data.into(), meta).await [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/s3_client.rs:230:28 [INFO] [stdout] | [INFO] [stdout] 228 | crate_bytes: Bytes, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | sha256: [u8; 32], [INFO] [stdout] 230 | ) -> StorageResult<()> { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 231 | | let len = crate_bytes.len(); [INFO] [stdout] 232 | | let path = construct_path(name, version); [INFO] [stdout] 233 | | self.put_object( [INFO] [stdout] ... | [INFO] [stdout] 245 | | .await [INFO] [stdout] 246 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:38:99 [INFO] [stdout] | [INFO] [stdout] 38 | async fn put_file(&self, path: &str, file_bytes: Bytes, _meta: Metadata) -> StorageResult<()> { [INFO] [stdout] | __________________________________________-----------------________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | | let path = self.abs_path(path)?; [INFO] [stdout] 40 | | let parent = path.parent().unwrap(); [INFO] [stdout] 41 | | if !parent.exists() { [INFO] [stdout] ... | [INFO] [stdout] 47 | | Ok(()) [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:46:66 [INFO] [stdout] | [INFO] [stdout] 46 | tmp.persist(path).map_err(|e| StorageError::ServiceError(e.into()))?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:50:112 [INFO] [stdout] | [INFO] [stdout] 50 | async fn create_or_append_file(&self, path: &str, file_bytes: Bytes, _meta: Metadata) -> StorageResult<()> { [INFO] [stdout] | _______________________________________________________-----------------________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | | let path = self.abs_path(path)?; [INFO] [stdout] 52 | | let parent = path.parent().unwrap(); [INFO] [stdout] 53 | | if !parent.exists() { [INFO] [stdout] ... | [INFO] [stdout] 59 | | Ok(()) [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freighter-storage` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "64aa530a6f9d45b83de47569d393117c34295ae8e12ac52c3218b09d7f50e352", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64aa530a6f9d45b83de47569d393117c34295ae8e12ac52c3218b09d7f50e352", kill_on_drop: false }` [INFO] [stdout] 64aa530a6f9d45b83de47569d393117c34295ae8e12ac52c3218b09d7f50e352