[INFO] fetching crate freebsd-embedded-hal 0.1.2... [INFO] checking freebsd-embedded-hal-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate freebsd-embedded-hal 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate freebsd-embedded-hal 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate freebsd-embedded-hal 0.1.2 [INFO] finished tweaking crates.io crate freebsd-embedded-hal 0.1.2 [INFO] tweaked toml for crates.io crate freebsd-embedded-hal 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate freebsd-embedded-hal 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5cedc386b7a78d6427b583ebb62b2a6c4922a8a7e7bc115bac240890bb0e64e4 [INFO] running `Command { std: "docker" "start" "-a" "5cedc386b7a78d6427b583ebb62b2a6c4922a8a7e7bc115bac240890bb0e64e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5cedc386b7a78d6427b583ebb62b2a6c4922a8a7e7bc115bac240890bb0e64e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cedc386b7a78d6427b583ebb62b2a6c4922a8a7e7bc115bac240890bb0e64e4", kill_on_drop: false }` [INFO] [stdout] 5cedc386b7a78d6427b583ebb62b2a6c4922a8a7e7bc115bac240890bb0e64e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6bce50c67487f44261af7fb83a921344f3b4ebf9db0c4630f6c3646cea9b184 [INFO] running `Command { std: "docker" "start" "-a" "b6bce50c67487f44261af7fb83a921344f3b4ebf9db0c4630f6c3646cea9b184", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.134 [INFO] [stderr] Checking nb v1.0.0 [INFO] [stderr] Checking embedded-hal v1.0.0-alpha.6 [INFO] [stderr] Checking freebsd-embedded-hal v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpio.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn from_path>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | use std::os::unix::ffi::OsStrExt; [INFO] [stdout] 67 | let path_str = CString::new(path.as_ref().as_os_str().as_bytes())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(GpioChip(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | / OpenOptions::new() [INFO] [stdout] 81 | | .read(true) [INFO] [stdout] 82 | | .write(true) [INFO] [stdout] 83 | | .open(path) [INFO] [stdout] 84 | | .map(|f| I2cBus(f.into_raw_fd())) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:129:34 [INFO] [stdout] | [INFO] [stdout] 124 | fn write_iter(&mut self, address: u8, bytes: B) -> Result<(), Self::Error> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | self.write(address, &mut bytes.into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:175:39 [INFO] [stdout] | [INFO] [stdout] 168 | bytes: B, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | self.write_read(address, &mut bytes.into_iter().collect::>(), buffer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:245:33 [INFO] [stdout] | [INFO] [stdout] 236 | fn exec_iter<'a, O>(&mut self, address: u8, operations: O) -> Result<(), Self::Error> [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | self.exec(address, &mut operations.into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpio.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn from_path>(path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | use std::os::unix::ffi::OsStrExt; [INFO] [stdout] 67 | let path_str = CString::new(path.as_ref().as_os_str().as_bytes())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(GpioChip(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | / OpenOptions::new() [INFO] [stdout] 81 | | .read(true) [INFO] [stdout] 82 | | .write(true) [INFO] [stdout] 83 | | .open(path) [INFO] [stdout] 84 | | .map(|f| I2cBus(f.into_raw_fd())) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:129:34 [INFO] [stdout] | [INFO] [stdout] 124 | fn write_iter(&mut self, address: u8, bytes: B) -> Result<(), Self::Error> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | self.write(address, &mut bytes.into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freebsd-embedded-hal` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:175:39 [INFO] [stdout] | [INFO] [stdout] 168 | bytes: B, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | self.write_read(address, &mut bytes.into_iter().collect::>(), buffer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/i2c.rs:245:33 [INFO] [stdout] | [INFO] [stdout] 236 | fn exec_iter<'a, O>(&mut self, address: u8, operations: O) -> Result<(), Self::Error> [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | self.exec(address, &mut operations.into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freebsd-embedded-hal` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "b6bce50c67487f44261af7fb83a921344f3b4ebf9db0c4630f6c3646cea9b184", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6bce50c67487f44261af7fb83a921344f3b4ebf9db0c4630f6c3646cea9b184", kill_on_drop: false }` [INFO] [stdout] b6bce50c67487f44261af7fb83a921344f3b4ebf9db0c4630f6c3646cea9b184