[INFO] fetching crate frclib-datalog 0.1.3... [INFO] checking frclib-datalog-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate frclib-datalog 0.1.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate frclib-datalog 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate frclib-datalog 0.1.3 [INFO] finished tweaking crates.io crate frclib-datalog 0.1.3 [INFO] tweaked toml for crates.io crate frclib-datalog 0.1.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8bd3dcd404d73264a8e8b530b805193eb4c10dc3130b93164df620a9e3845ee [INFO] running `Command { std: "docker" "start" "-a" "f8bd3dcd404d73264a8e8b530b805193eb4c10dc3130b93164df620a9e3845ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8bd3dcd404d73264a8e8b530b805193eb4c10dc3130b93164df620a9e3845ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8bd3dcd404d73264a8e8b530b805193eb4c10dc3130b93164df620a9e3845ee", kill_on_drop: false }` [INFO] [stdout] f8bd3dcd404d73264a8e8b530b805193eb4c10dc3130b93164df620a9e3845ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9443d6889498af4537d65fa16556ca134811b696fe8100ae997cc04409ab942c [INFO] running `Command { std: "docker" "start" "-a" "9443d6889498af4537d65fa16556ca134811b696fe8100ae997cc04409ab942c", kill_on_drop: false }` [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking nohash v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking rmpv v1.3.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Compiling frclib-structure-macros v0.1.3 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking frclib-core v0.2.4 [INFO] [stderr] Checking frclib-datalog v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:110:25 [INFO] [stdout] | [INFO] [stdout] 110 | values: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:170:37 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn write(&mut self, id: TypedEntryId, value: T) -> Result<(), DataLogError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | self.inner_write(id.into(), value.into_frc_value().to_timestamped(now()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:183:37 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn write_timestamped(&mut self, id: TypedEntryId, value: T, timestamp: FrcTimestamp) -> Result<(), DataLogErr... [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | self.inner_write(id.into(), value.into_frc_value().to_timestamped(timestamp), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 288 | pub fn get_entry(&mut self, key: impl ToString, metadata: Option) -> Result, DataLogEr... [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | / self.get_entry_dynamic( [INFO] [stdout] 290 | | key, [INFO] [stdout] 291 | | T::TYPE, [INFO] [stdout] 292 | | metadata [INFO] [stdout] 293 | | ).map(EntryId::typed::) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | let exec = || DataLogReader::try_new( [INFO] [stdout] | ___________________^ [INFO] [stdout] 73 | | buffer.clone(), [INFO] [stdout] 74 | | DataLogReaderConfig::default() [INFO] [stdout] 75 | | ).expect("Failed to create reader"); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frclib-datalog` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:110:25 [INFO] [stdout] | [INFO] [stdout] 110 | values: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:170:37 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn write(&mut self, id: TypedEntryId, value: T) -> Result<(), DataLogError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | self.inner_write(id.into(), value.into_frc_value().to_timestamped(now()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:183:37 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn write_timestamped(&mut self, id: TypedEntryId, value: T, timestamp: FrcTimestamp) -> Result<(), DataLogErr... [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | self.inner_write(id.into(), value.into_frc_value().to_timestamped(timestamp), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 288 | pub fn get_entry(&mut self, key: impl ToString, metadata: Option) -> Result, DataLogEr... [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | / self.get_entry_dynamic( [INFO] [stdout] 290 | | key, [INFO] [stdout] 291 | | T::TYPE, [INFO] [stdout] 292 | | metadata [INFO] [stdout] 293 | | ).map(EntryId::typed::) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frclib-datalog` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "9443d6889498af4537d65fa16556ca134811b696fe8100ae997cc04409ab942c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9443d6889498af4537d65fa16556ca134811b696fe8100ae997cc04409ab942c", kill_on_drop: false }` [INFO] [stdout] 9443d6889498af4537d65fa16556ca134811b696fe8100ae997cc04409ab942c