[INFO] fetching crate frag 0.1.6... [INFO] checking frag-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate frag 0.1.6 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate frag 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate frag 0.1.6 [INFO] finished tweaking crates.io crate frag 0.1.6 [INFO] tweaked toml for crates.io crate frag 0.1.6 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate frag 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd7da2eb755dd635d6c754b591f5645f2eed7c0b8b14814c6d1ec0a2e120248e [INFO] running `Command { std: "docker" "start" "-a" "dd7da2eb755dd635d6c754b591f5645f2eed7c0b8b14814c6d1ec0a2e120248e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd7da2eb755dd635d6c754b591f5645f2eed7c0b8b14814c6d1ec0a2e120248e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd7da2eb755dd635d6c754b591f5645f2eed7c0b8b14814c6d1ec0a2e120248e", kill_on_drop: false }` [INFO] [stdout] dd7da2eb755dd635d6c754b591f5645f2eed7c0b8b14814c6d1ec0a2e120248e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90765420c7213df69889e2eec52db1a2870f77e89806d95a7fc1545195b2b48b [INFO] running `Command { std: "docker" "start" "-a" "90765420c7213df69889e2eec52db1a2870f77e89806d95a7fc1545195b2b48b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking file-id v0.1.0 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking flate2 v1.0.25 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking notify-debouncer-full v0.1.0 [INFO] [stderr] Checking hotwatch v0.5.0 [INFO] [stderr] Checking frag v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:568:8 [INFO] [stdout] | [INFO] [stdout] 552 | let sdl_context = sdl2::init()?;//.expect("Frag: could not create SDL context."); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 553 | let video_subsystem = sdl_context.video()?;//.expect("Frag: could not get SDL video subsystem."); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 556 | let window = video_subsystem.window(":3", ww as u32, wh as u32) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | let _gl_contex = window.gl_create_context().strerr("Frag: could not create GL context.")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 568 | Ok((sdl_context, window, _gl_contex)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader.rs:193:32 [INFO] [stdout] | [INFO] [stdout] 188 | let vert_cstr = if let Ok(cstr) = CString::new(vert_source){ cstr } else { return Err("Frag: could not make vert cstr.".to_string... [INFO] [stdout] | --------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let frag_cstr = if let Ok(cstr) = CString::new(frag_source){ cstr } else { return Err("Frag: could not make frag cstr.".to_string... [INFO] [stdout] | --------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let vert_shader = Shader::from_vert_source(&vert_cstr)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let frag_shader = Shader::from_frag_source(&frag_cstr, sections)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | [INFO] [stdout] 193 | Program::from_shaders(&[vert_shader, frag_shader], sections) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 208 | let error = create_whitespace_cstring_with_len(len as usize); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(Program { id }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:568:8 [INFO] [stdout] | [INFO] [stdout] 552 | let sdl_context = sdl2::init()?;//.expect("Frag: could not create SDL context."); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 553 | let video_subsystem = sdl_context.video()?;//.expect("Frag: could not get SDL video subsystem."); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 556 | let window = video_subsystem.window(":3", ww as u32, wh as u32) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | let _gl_contex = window.gl_create_context().strerr("Frag: could not create GL context.")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 568 | Ok((sdl_context, window, _gl_contex)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader.rs:193:32 [INFO] [stdout] | [INFO] [stdout] 188 | let vert_cstr = if let Ok(cstr) = CString::new(vert_source){ cstr } else { return Err("Frag: could not make vert cstr.".to_string... [INFO] [stdout] | --------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let frag_cstr = if let Ok(cstr) = CString::new(frag_source){ cstr } else { return Err("Frag: could not make frag cstr.".to_string... [INFO] [stdout] | --------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let vert_shader = Shader::from_vert_source(&vert_cstr)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let frag_shader = Shader::from_frag_source(&frag_cstr, sections)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | [INFO] [stdout] 193 | Program::from_shaders(&[vert_shader, frag_shader], sections) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 208 | let error = create_whitespace_cstring_with_len(len as usize); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(Program { id }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frag` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frag` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "90765420c7213df69889e2eec52db1a2870f77e89806d95a7fc1545195b2b48b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90765420c7213df69889e2eec52db1a2870f77e89806d95a7fc1545195b2b48b", kill_on_drop: false }` [INFO] [stdout] 90765420c7213df69889e2eec52db1a2870f77e89806d95a7fc1545195b2b48b