[INFO] fetching crate fqdn 0.3.12... [INFO] checking fqdn-0.3.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fqdn 0.3.12 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate fqdn 0.3.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fqdn 0.3.12 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate fqdn 0.3.12 [INFO] tweaked toml for crates.io crate fqdn 0.3.12 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate fqdn 0.3.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff3156ef3a977a91aff0e21b31f7ebcc51ddabf7712cb214639f4cef707d0a30 [INFO] running `Command { std: "docker" "start" "-a" "ff3156ef3a977a91aff0e21b31f7ebcc51ddabf7712cb214639f4cef707d0a30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff3156ef3a977a91aff0e21b31f7ebcc51ddabf7712cb214639f4cef707d0a30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff3156ef3a977a91aff0e21b31f7ebcc51ddabf7712cb214639f4cef707d0a30", kill_on_drop: false }` [INFO] [stdout] ff3156ef3a977a91aff0e21b31f7ebcc51ddabf7712cb214639f4cef707d0a30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0116e5f56c95b6329bc80307d9e96168f8d78083d69777e581796569b075c430 [INFO] running `Command { std: "docker" "start" "-a" "0116e5f56c95b6329bc80307d9e96168f8d78083d69777e581796569b075c430", kill_on_drop: false }` [INFO] [stderr] Checking fqdn v0.3.12 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fqdn.rs:64:73 [INFO] [stdout] | [INFO] [stdout] 63 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | crate::check::check_byte_sequence(self.as_bytes_with_nul()).map(|_| FQDN(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fqdn` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fqdn.rs:64:73 [INFO] [stdout] | [INFO] [stdout] 63 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | crate::check::check_byte_sequence(self.as_bytes_with_nul()).map(|_| FQDN(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:230:44 [INFO] [stdout] | [INFO] [stdout] 230 | let ordered = items.iter().map(|s| s.parse::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:233:46 [INFO] [stdout] | [INFO] [stdout] 233 | let unordered = items.iter().map(|s| s.parse::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fqdn` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "0116e5f56c95b6329bc80307d9e96168f8d78083d69777e581796569b075c430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0116e5f56c95b6329bc80307d9e96168f8d78083d69777e581796569b075c430", kill_on_drop: false }` [INFO] [stdout] 0116e5f56c95b6329bc80307d9e96168f8d78083d69777e581796569b075c430