[INFO] fetching crate fpa_lr 0.5.1... [INFO] checking fpa_lr-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fpa_lr 0.5.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate fpa_lr 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fpa_lr 0.5.1 [INFO] finished tweaking crates.io crate fpa_lr 0.5.1 [INFO] tweaked toml for crates.io crate fpa_lr 0.5.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate fpa_lr 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 807dc0389affaa0fed7a6fd0d458c22b5497d927bc43894f3b3b49b0c8eafc56 [INFO] running `Command { std: "docker" "start" "-a" "807dc0389affaa0fed7a6fd0d458c22b5497d927bc43894f3b3b49b0c8eafc56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "807dc0389affaa0fed7a6fd0d458c22b5497d927bc43894f3b3b49b0c8eafc56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "807dc0389affaa0fed7a6fd0d458c22b5497d927bc43894f3b3b49b0c8eafc56", kill_on_drop: false }` [INFO] [stdout] 807dc0389affaa0fed7a6fd0d458c22b5497d927bc43894f3b3b49b0c8eafc56 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66c64b57b92763f4c650884ff13ffbde611c2a4baa56b4a82ee907a5c840a67c [INFO] running `Command { std: "docker" "start" "-a" "66c64b57b92763f4c650884ff13ffbde611c2a4baa56b4a82ee907a5c840a67c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling cc v1.0.54 [INFO] [stderr] Compiling proc-macro2 v1.0.17 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v1.0.25 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde v1.0.110 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling ryu v1.0.4 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Compiling lzma-sys v0.1.16 [INFO] [stderr] Compiling bzip2-sys v0.1.8+1.0.8 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking flate2 v1.0.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Compiling thiserror-impl v1.0.19 [INFO] [stderr] Compiling serde_derive v1.0.110 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking thiserror v1.0.19 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking niffler v2.0.1 [INFO] [stderr] Checking fpa_lr v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::subcommand::*` [INFO] [stdout] --> src/cli/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use self::subcommand::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::subcommand::*` [INFO] [stdout] --> src/cli/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use self::subcommand::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/m4.rs:186:20 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Reader { [INFO] [stdout] 186 | inner: csv::ReaderBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 187 | | .delimiter(b' ') [INFO] [stdout] 188 | | .has_headers(false) [INFO] [stdout] 189 | | .flexible(true) [INFO] [stdout] 190 | | .from_reader(reader), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/m4.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | fs::File::create(path).map(Writer::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/m4.rs:219:20 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn new(writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Writer { [INFO] [stdout] 219 | inner: csv::WriterBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 220 | | .delimiter(b' ') [INFO] [stdout] 221 | | .has_headers(false) [INFO] [stdout] 222 | | .flexible(true) [INFO] [stdout] 223 | | .from_writer(writer), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/paf.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | Reader { [INFO] [stdout] 190 | inner: csv::ReaderBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 191 | | .delimiter(b'\t') [INFO] [stdout] 192 | | .has_headers(false) [INFO] [stdout] 193 | | .flexible(true) [INFO] [stdout] 194 | | .from_reader(reader), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/paf.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn new(writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | Writer { [INFO] [stdout] 215 | inner: csv::WriterBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 216 | | .delimiter(b'\t') [INFO] [stdout] 217 | | .has_headers(false) [INFO] [stdout] 218 | | .flexible(true) [INFO] [stdout] 219 | | .from_writer(writer), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fpa_lr` (bin "fpa") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/m4.rs:186:20 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Reader { [INFO] [stdout] 186 | inner: csv::ReaderBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 187 | | .delimiter(b' ') [INFO] [stdout] 188 | | .has_headers(false) [INFO] [stdout] 189 | | .flexible(true) [INFO] [stdout] 190 | | .from_reader(reader), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/m4.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | fs::File::create(path).map(Writer::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/m4.rs:219:20 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn new(writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Writer { [INFO] [stdout] 219 | inner: csv::WriterBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 220 | | .delimiter(b' ') [INFO] [stdout] 221 | | .has_headers(false) [INFO] [stdout] 222 | | .flexible(true) [INFO] [stdout] 223 | | .from_writer(writer), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/paf.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | Reader { [INFO] [stdout] 190 | inner: csv::ReaderBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 191 | | .delimiter(b'\t') [INFO] [stdout] 192 | | .has_headers(false) [INFO] [stdout] 193 | | .flexible(true) [INFO] [stdout] 194 | | .from_reader(reader), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/paf.rs:215:20 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn new(writer: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | Writer { [INFO] [stdout] 215 | inner: csv::WriterBuilder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 216 | | .delimiter(b'\t') [INFO] [stdout] 217 | | .has_headers(false) [INFO] [stdout] 218 | | .flexible(true) [INFO] [stdout] 219 | | .from_writer(writer), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fpa_lr` (bin "fpa" test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "66c64b57b92763f4c650884ff13ffbde611c2a4baa56b4a82ee907a5c840a67c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66c64b57b92763f4c650884ff13ffbde611c2a4baa56b4a82ee907a5c840a67c", kill_on_drop: false }` [INFO] [stdout] 66c64b57b92763f4c650884ff13ffbde611c2a4baa56b4a82ee907a5c840a67c