[INFO] fetching crate four_derive 0.0.13... [INFO] checking four_derive-0.0.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate four_derive 0.0.13 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate four_derive 0.0.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate four_derive 0.0.13 [INFO] finished tweaking crates.io crate four_derive 0.0.13 [INFO] tweaked toml for crates.io crate four_derive 0.0.13 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4fa10d847108a4806b5189d6f83cfa35bb78fd578c6d32eedcb48b4990a787c [INFO] running `Command { std: "docker" "start" "-a" "b4fa10d847108a4806b5189d6f83cfa35bb78fd578c6d32eedcb48b4990a787c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4fa10d847108a4806b5189d6f83cfa35bb78fd578c6d32eedcb48b4990a787c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4fa10d847108a4806b5189d6f83cfa35bb78fd578c6d32eedcb48b4990a787c", kill_on_drop: false }` [INFO] [stdout] b4fa10d847108a4806b5189d6f83cfa35bb78fd578c6d32eedcb48b4990a787c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f51d0b705c20acf7ad14f8cffebde379337e0ed2812118d35ea5e805ace2532e [INFO] running `Command { std: "docker" "start" "-a" "f51d0b705c20acf7ad14f8cffebde379337e0ed2812118d35ea5e805ace2532e", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking four_derive v0.0.13 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 142 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Vec { [INFO] [stdout] 144 | / fields [INFO] [stdout] 145 | | .into_iter() [INFO] [stdout] 146 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 147 | | .filter(|f| { [INFO] [stdout] ... | [INFO] [stdout] 161 | | .into() [INFO] [stdout] 162 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 167 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | ) -> Vec { [INFO] [stdout] 169 | / fields [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] 171 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 172 | | .filter(|f| { [INFO] [stdout] ... | [INFO] [stdout] 185 | | .into() [INFO] [stdout] 186 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 191 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | ) -> Vec { [INFO] [stdout] 193 | / fields [INFO] [stdout] 194 | | .into_iter() [INFO] [stdout] 195 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 196 | | .filter(|f| { [INFO] [stdout] ... | [INFO] [stdout] 221 | | } [INFO] [stdout] 222 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 253 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | ) -> Vec { [INFO] [stdout] 255 | / fields [INFO] [stdout] 256 | | .into_iter() [INFO] [stdout] 257 | | .filter(|f| !is_option(&f.ty)) [INFO] [stdout] 258 | | .map(|f| { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 270 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | ) -> Vec { [INFO] [stdout] 272 | / fields [INFO] [stdout] 273 | | .into_iter() [INFO] [stdout] 274 | | .map(|f| { [INFO] [stdout] 275 | | let name = &f.ident; [INFO] [stdout] ... | [INFO] [stdout] 281 | | } [INFO] [stdout] 282 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:5 [INFO] [stdout] | [INFO] [stdout] 287 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | ) -> Vec { [INFO] [stdout] 289 | / fields [INFO] [stdout] 290 | | .into_iter() [INFO] [stdout] 291 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 292 | | .filter(|f| is_option(&f.ty)) [INFO] [stdout] ... | [INFO] [stdout] 313 | | } [INFO] [stdout] 314 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `four_derive` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 142 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Vec { [INFO] [stdout] 144 | / fields [INFO] [stdout] 145 | | .into_iter() [INFO] [stdout] 146 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 147 | | .filter(|f| { [INFO] [stdout] ... | [INFO] [stdout] 161 | | .into() [INFO] [stdout] 162 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 167 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | ) -> Vec { [INFO] [stdout] 169 | / fields [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] 171 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 172 | | .filter(|f| { [INFO] [stdout] ... | [INFO] [stdout] 185 | | .into() [INFO] [stdout] 186 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 191 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | ) -> Vec { [INFO] [stdout] 193 | / fields [INFO] [stdout] 194 | | .into_iter() [INFO] [stdout] 195 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 196 | | .filter(|f| { [INFO] [stdout] ... | [INFO] [stdout] 221 | | } [INFO] [stdout] 222 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 253 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | ) -> Vec { [INFO] [stdout] 255 | / fields [INFO] [stdout] 256 | | .into_iter() [INFO] [stdout] 257 | | .filter(|f| !is_option(&f.ty)) [INFO] [stdout] 258 | | .map(|f| { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 270 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | ) -> Vec { [INFO] [stdout] 272 | / fields [INFO] [stdout] 273 | | .into_iter() [INFO] [stdout] 274 | | .map(|f| { [INFO] [stdout] 275 | | let name = &f.ident; [INFO] [stdout] ... | [INFO] [stdout] 281 | | } [INFO] [stdout] 282 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:289:5 [INFO] [stdout] | [INFO] [stdout] 287 | fields: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | ) -> Vec { [INFO] [stdout] 289 | / fields [INFO] [stdout] 290 | | .into_iter() [INFO] [stdout] 291 | | .filter(|f| f.ident.as_ref().map(|i| i.to_string()) != Some("logical_id".to_string())) [INFO] [stdout] 292 | | .filter(|f| is_option(&f.ty)) [INFO] [stdout] ... | [INFO] [stdout] 313 | | } [INFO] [stdout] 314 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `four_derive` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "f51d0b705c20acf7ad14f8cffebde379337e0ed2812118d35ea5e805ace2532e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f51d0b705c20acf7ad14f8cffebde379337e0ed2812118d35ea5e805ace2532e", kill_on_drop: false }` [INFO] [stdout] f51d0b705c20acf7ad14f8cffebde379337e0ed2812118d35ea5e805ace2532e