[INFO] fetching crate four 0.0.13... [INFO] checking four-0.0.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate four 0.0.13 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate four 0.0.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate four 0.0.13 [INFO] finished tweaking crates.io crate four 0.0.13 [INFO] tweaked toml for crates.io crate four 0.0.13 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a8ebc584cbb03025dc9a04a596f66cef91815d550750e85a9027337a3e631f20 [INFO] running `Command { std: "docker" "start" "-a" "a8ebc584cbb03025dc9a04a596f66cef91815d550750e85a9027337a3e631f20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a8ebc584cbb03025dc9a04a596f66cef91815d550750e85a9027337a3e631f20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8ebc584cbb03025dc9a04a596f66cef91815d550750e85a9027337a3e631f20", kill_on_drop: false }` [INFO] [stdout] a8ebc584cbb03025dc9a04a596f66cef91815d550750e85a9027337a3e631f20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aaf41e20e86dfad682b50eb91916bd7ced834925e94c8d70406739c742c03545 [INFO] running `Command { std: "docker" "start" "-a" "aaf41e20e86dfad682b50eb91916bd7ced834925e94c8d70406739c742c03545", kill_on_drop: false }` [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Compiling urlencoding v2.1.3 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive-new v0.7.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling kinded_macros v0.3.0 [INFO] [stderr] Compiling four_derive v0.0.13 [INFO] [stderr] Compiling kinded v0.3.0 [INFO] [stderr] Compiling nutype_macros v0.5.0-beta.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking nutype v0.5.0-beta.2 [INFO] [stderr] Checking four v0.0.13 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `WillMappable` is more private than the item `WillBe::::map` [INFO] [stdout] --> src/core/convert.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn map(self) -> WillBe [INFO] [stdout] 32 | | where [INFO] [stdout] 33 | | U: WillMappable, [INFO] [stdout] | |___________________________^ method `WillBe::::map` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `WillMappable` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/core/convert.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | pub(crate) trait WillMappable {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `WillMappable` is more private than the item `WillBe::::map` [INFO] [stdout] --> src/core/convert.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn map(self) -> WillBe [INFO] [stdout] 32 | | where [INFO] [stdout] 33 | | U: WillMappable, [INFO] [stdout] | |___________________________^ method `WillBe::::map` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `WillMappable` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/core/convert.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | pub(crate) trait WillMappable {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/account.rs:7:58 [INFO] [stdout] | [INFO] [stdout] 7 | static ACCOUNT_REGEX: LazyLock = LazyLock::new(|| Regex::new(r#"\d{12}"#).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/account.rs:7:58 [INFO] [stdout] | [INFO] [stdout] 7 | static ACCOUNT_REGEX: LazyLock = LazyLock::new(|| Regex::new(r#"\d{12}"#).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/arn.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(value: Arn) -> AnyArn { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | service: Box::new(value.service), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/arn.rs:100:23 [INFO] [stdout] | [INFO] [stdout] 99 | let tail = acc.pop().expect("at least 1 value"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | match (tail, x) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/arn.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 301 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let mut contents: Vec> = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | Join(contents).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/convert.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 46 | fn from(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | WillBe { [INFO] [stdout] 48 | from: Box::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/function/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn r#ref(wrapped: R) -> WillBe { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | WillBe::new(Box::new(Ref::new(wrapped))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/function/reference.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(r: R) -> Ref { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ref { [INFO] [stdout] 37 | inner: r.referenced(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/logical_id.rs:6:22 [INFO] [stdout] | [INFO] [stdout] 6 | LazyLock::new(|| Regex::new(r#"[[:alnum:]]+"#).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/arn.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(value: Arn) -> AnyArn { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | service: Box::new(value.service), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/arn.rs:100:23 [INFO] [stdout] | [INFO] [stdout] 99 | let tail = acc.pop().expect("at least 1 value"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | match (tail, x) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/arn.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 301 | fn serialize(&self, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let mut contents: Vec> = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | Join(contents).serialize(serializer) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/convert.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 46 | fn from(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | WillBe { [INFO] [stdout] 48 | from: Box::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/function/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn r#ref(wrapped: R) -> WillBe { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | WillBe::new(Box::new(Ref::new(wrapped))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/function/reference.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(r: R) -> Ref { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ref { [INFO] [stdout] 37 | inner: r.referenced(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/logical_id.rs:6:22 [INFO] [stdout] | [INFO] [stdout] 6 | LazyLock::new(|| Regex::new(r#"[[:alnum:]]+"#).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `four` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `four` (lib test) due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "aaf41e20e86dfad682b50eb91916bd7ced834925e94c8d70406739c742c03545", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aaf41e20e86dfad682b50eb91916bd7ced834925e94c8d70406739c742c03545", kill_on_drop: false }` [INFO] [stdout] aaf41e20e86dfad682b50eb91916bd7ced834925e94c8d70406739c742c03545