[INFO] fetching crate forked-tarpc 0.31.1... [INFO] checking forked-tarpc-0.31.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate forked-tarpc 0.31.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate forked-tarpc 0.31.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate forked-tarpc 0.31.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate forked-tarpc 0.31.1 [INFO] tweaked toml for crates.io crate forked-tarpc 0.31.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate forked-tarpc 0.31.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 14e0ed8e10486578184f48909edaf31f7ba5ddffd46976859a928081fb7bbe20 [INFO] running `Command { std: "docker" "start" "-a" "14e0ed8e10486578184f48909edaf31f7ba5ddffd46976859a928081fb7bbe20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "14e0ed8e10486578184f48909edaf31f7ba5ddffd46976859a928081fb7bbe20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14e0ed8e10486578184f48909edaf31f7ba5ddffd46976859a928081fb7bbe20", kill_on_drop: false }` [INFO] [stdout] 14e0ed8e10486578184f48909edaf31f7ba5ddffd46976859a928081fb7bbe20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1a0d34c38df144e3d60ab656400ad04347415d5c0f2607c5d31a08098b64101 [INFO] running `Command { std: "docker" "start" "-a" "f1a0d34c38df144e3d60ab656400ad04347415d5c0f2607c5d31a08098b64101", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.139 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling tokio v1.21.2 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling pin-project-internal v1.0.11 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling crossbeam-utils v0.8.10 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling tracing-attributes v0.1.22 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling serde_derive v1.0.139 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking tracing-core v0.1.28 [INFO] [stderr] Compiling trybuild v1.0.63 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Compiling tarpc-plugins v0.12.0 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.5 [INFO] [stderr] Checking pin-project v1.0.11 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking thrift v0.15.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.14 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking serde_json v1.0.82 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_bytes v0.11.6 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Compiling enum-ordinalize v3.1.11 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking futures-test v0.3.21 [INFO] [stderr] Compiling educe v0.4.19 [INFO] [stderr] Checking tokio-serde v0.8.0 [INFO] [stderr] Checking tokio-stream v0.1.9 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking forked-tarpc v0.31.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking opentelemetry v0.17.0 [INFO] [stdout] warning: trait `PollContext` is never used [INFO] [stdout] --> src/lib.rs:392:18 [INFO] [stdout] | [INFO] [stdout] 392 | pub(crate) trait PollContext { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `SpanExt` is never used [INFO] [stdout] --> src/context.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 150 | pub(crate) trait SpanExt { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:411:18 [INFO] [stdout] | [INFO] [stdout] 407 | fn context(self, context: C) -> Poll>> [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | self.map(|o| o.map(|r| r.context(context))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:411:28 [INFO] [stdout] | [INFO] [stdout] 407 | fn context(self, context: C) -> Poll>> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | self.map(|o| o.map(|r| r.context(context))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:419:18 [INFO] [stdout] | [INFO] [stdout] 414 | fn with_context(self, f: F) -> Poll>> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | self.map(|o| o.map(|r| r.with_context(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:419:28 [INFO] [stdout] | [INFO] [stdout] 414 | fn with_context(self, f: F) -> Poll>> [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | self.map(|o| o.map(|r| r.with_context(f))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cancellations.rs:18:6 [INFO] [stdout] | [INFO] [stdout] 17 | let (tx, rx) = mpsc::unbounded_channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | (RequestCancellation(tx), CanceledRequests(rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cancellations.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 17 | let (tx, rx) = mpsc::unbounded_channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | (RequestCancellation(tx), CanceledRequests(rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:162:35 [INFO] [stdout] | [INFO] [stdout] 128 | request: Req, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | ) -> Result { [INFO] [stdout] 130 | let span = Span::current(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let (response_completion, mut response) = oneshot::channel(); [INFO] [stdout] | ------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let response_guard = ResponseGuard { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | response_guard.response().await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:248:17 [INFO] [stdout] | [INFO] [stdout] 238 | transport: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let (cancellation, canceled_requests) = cancellations(); [INFO] [stdout] | ------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | let canceled_requests = canceled_requests; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | client: Channel { [INFO] [stdout] | _________________^ [INFO] [stdout] 249 | | to_dispatch, [INFO] [stdout] 250 | | cancellation, [INFO] [stdout] 251 | | next_request_id: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] 252 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:253:19 [INFO] [stdout] | [INFO] [stdout] 238 | transport: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer); [INFO] [stdout] | ----------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | let (cancellation, canceled_requests) = cancellations(); [INFO] [stdout] | ------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | let canceled_requests = canceled_requests; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | dispatch: RequestDispatch { [INFO] [stdout] | ___________________^ [INFO] [stdout] 254 | | config, [INFO] [stdout] 255 | | canceled_requests, [INFO] [stdout] 256 | | transport: transport.fuse(), [INFO] [stdout] 257 | | in_flight_requests: InFlightRequests::default(), [INFO] [stdout] 258 | | pending_requests, [INFO] [stdout] 259 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 331 | message: ClientMessage, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | ) -> Result<(), ChannelError> { [INFO] [stdout] 333 | / self.transport_pin_mut() [INFO] [stdout] 334 | | .start_send(message) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:534:21 [INFO] [stdout] | [INFO] [stdout] 505 | span, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 506 | request_id, [INFO] [stdout] 507 | request, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 508 | response_completion, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | } = match ready!(self.as_mut().poll_next_request(cx)?) { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 510 | Some(dispatch_request) => dispatch_request, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 513 | let entered = span.enter(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | let request = ClientMessage::Request(Request { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 534 | Poll::Ready(Some(Ok(()))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:553:21 [INFO] [stdout] | [INFO] [stdout] 541 | let (context, span, request_id) = match ready!(self.as_mut().poll_next_cancellation(cx)?) { [INFO] [stdout] | ---- ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 542 | Some(triple) => triple, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 545 | let _entered = span.enter(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 546 | [INFO] [stdout] 547 | let cancel = ClientMessage::Cancel { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | Poll::Ready(Some(Ok(()))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:137:24 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn new(config: Config, transport: T) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let (request_cancellation, canceled_requests) = cancellations(); [INFO] [stdout] | -------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | transport: transport.fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:140:33 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn new(config: Config, transport: T) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let (request_cancellation, canceled_requests) = cancellations(); [INFO] [stdout] | -------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | in_flight_requests: InFlightRequests::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:590:34 [INFO] [stdout] | [INFO] [stdout] 577 | |TrackedRequest { [INFO] [stdout] | ______________- [INFO] [stdout] 578 | | request, [INFO] [stdout] 579 | | abort_registration, [INFO] [stdout] 580 | | span, [INFO] [stdout] 581 | | mut response_guard, [INFO] [stdout] 582 | | }| { [INFO] [stdout] | |______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 590 | response_tx: self.responses_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/limits/channels_per_key.rs:146:23 [INFO] [stdout] | [INFO] [stdout] 143 | pub(crate) fn new(listener: S, channels_per_key: u32, keymaker: F) -> Self { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let (dropped_keys_tx, dropped_keys) = mpsc::unbounded_channel(); [INFO] [stdout] | --------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | MaxChannelsPerKey { [INFO] [stdout] 146 | listener: listener.fuse(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/limits/channels_per_key.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 143 | pub(crate) fn new(listener: S, channels_per_key: u32, keymaker: F) -> Self { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let (dropped_keys_tx, dropped_keys) = mpsc::unbounded_channel(); [INFO] [stdout] | --------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | key_counts: FnvHashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/limits/channels_per_key.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 168 | stream: S::Item, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | ) -> Result, K> { [INFO] [stdout] 170 | let key = (self.as_mut().keymaker)(&stream); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | let tracker = self.as_mut().increment_channels_for_key(key.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok(TrackedChannel { [INFO] [stdout] | ____________^ [INFO] [stdout] 180 | | tracker, [INFO] [stdout] 181 | | inner: stream, [INFO] [stdout] 182 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/limits/channels_per_key.rs:188:15 [INFO] [stdout] | [INFO] [stdout] 185 | fn increment_channels_for_key(self: Pin<&mut Self>, key: K) -> Result>, K> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | match self_.key_counts.entry(key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 28 | let (tx1, rx2) = mpsc::unbounded_channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (tx2, rx1) = mpsc::unbounded_channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | ( [INFO] [stdout] 31 | UnboundedChannel { tx: tx1, rx: rx1 }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 28 | let (tx1, rx2) = mpsc::unbounded_channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let (tx2, rx1) = mpsc::unbounded_channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | UnboundedChannel { tx: tx2, rx: rx2 }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 68 | fn start_send(self: Pin<&mut Self>, item: SinkItem) -> Result<(), Self::Error> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | / self.tx [INFO] [stdout] 70 | | .send(item) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | .map_err(|_| ChannelError::Send(CLOSED_MESSAGE.into())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 90 | let (tx1, rx2) = futures::channel::mpsc::channel(capacity); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (tx2, rx1) = futures::channel::mpsc::channel(capacity); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | (Channel { tx: tx1, rx: rx1 }, Channel { tx: tx2, rx: rx2 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:92:36 [INFO] [stdout] | [INFO] [stdout] 90 | let (tx1, rx2) = futures::channel::mpsc::channel(capacity); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (tx2, rx1) = futures::channel::mpsc::channel(capacity); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | (Channel { tx: tx1, rx: rx1 }, Channel { tx: tx2, rx: rx2 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:124:45 [INFO] [stdout] | [INFO] [stdout] 124 | .map_err(|e| ChannelError::Send(Box::new(e))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:131:45 [INFO] [stdout] | [INFO] [stdout] 131 | .map_err(|e| ChannelError::Send(Box::new(e))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:138:45 [INFO] [stdout] | [INFO] [stdout] 138 | .map_err(|e| ChannelError::Send(Box::new(e))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:145:45 [INFO] [stdout] | [INFO] [stdout] 145 | .map_err(|e| ChannelError::Send(Box::new(e))) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `forked-tarpc` (lib) due to 30 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f1a0d34c38df144e3d60ab656400ad04347415d5c0f2607c5d31a08098b64101", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1a0d34c38df144e3d60ab656400ad04347415d5c0f2607c5d31a08098b64101", kill_on_drop: false }` [INFO] [stdout] f1a0d34c38df144e3d60ab656400ad04347415d5c0f2607c5d31a08098b64101