[INFO] fetching crate forgotten 1.2.0... [INFO] checking forgotten-1.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate forgotten 1.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate forgotten 1.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate forgotten 1.2.0 [INFO] finished tweaking crates.io crate forgotten 1.2.0 [INFO] tweaked toml for crates.io crate forgotten 1.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf83f3872b7a168164f0bd8433d46a70cdb1d2a9fadef33b016a133efdaac944 [INFO] running `Command { std: "docker" "start" "-a" "bf83f3872b7a168164f0bd8433d46a70cdb1d2a9fadef33b016a133efdaac944", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf83f3872b7a168164f0bd8433d46a70cdb1d2a9fadef33b016a133efdaac944", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf83f3872b7a168164f0bd8433d46a70cdb1d2a9fadef33b016a133efdaac944", kill_on_drop: false }` [INFO] [stdout] bf83f3872b7a168164f0bd8433d46a70cdb1d2a9fadef33b016a133efdaac944 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b330877e202f55008b035b4b13b99ff7701997c39bb1687e4e691b90e224fe60 [INFO] running `Command { std: "docker" "start" "-a" "b330877e202f55008b035b4b13b99ff7701997c39bb1687e4e691b90e224fe60", kill_on_drop: false }` [INFO] [stderr] Checking forgotten v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 54 | fn forget(&mut self, v: T) -> ForgottenKey { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | self.forget_rc(Rc::new(v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:62:10 [INFO] [stdout] | [INFO] [stdout] 59 | fn forget_and_get(&mut self, v: T) -> (ForgottenKey, Rc) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let v = Rc::new(v); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let ret = Rc::clone(&v); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | (self.forget_rc(v), ret) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn forget(v: T) -> ForgottenKey { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 157 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 158 | | fg.forget(v) [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn forget_and_get(v: T) -> (ForgottenKey, Rc) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 165 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 166 | | fg.forget_and_get(v) [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:172:20 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn forget_rc(v: Rc) -> ForgottenKey { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 173 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 174 | | fg.forget_rc(v) [INFO] [stdout] 175 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:188:20 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn free(k: ForgottenKey) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 189 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 190 | | fg.free(k) [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:228:20 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn take(k: ForgottenKey) -> Rc { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 229 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 230 | | fg.take(k) [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `forgotten` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 54 | fn forget(&mut self, v: T) -> ForgottenKey { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | self.forget_rc(Rc::new(v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:62:10 [INFO] [stdout] | [INFO] [stdout] 59 | fn forget_and_get(&mut self, v: T) -> (ForgottenKey, Rc) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let v = Rc::new(v); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let ret = Rc::clone(&v); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | (self.forget_rc(v), ret) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn forget(v: T) -> ForgottenKey { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 157 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 158 | | fg.forget(v) [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn forget_and_get(v: T) -> (ForgottenKey, Rc) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 165 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 166 | | fg.forget_and_get(v) [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:172:20 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn forget_rc(v: Rc) -> ForgottenKey { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 173 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 174 | | fg.forget_rc(v) [INFO] [stdout] 175 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:188:20 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn free(k: ForgottenKey) { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 189 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 190 | | fg.free(k) [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global/forgotten_impl.rs:228:20 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn take(k: ForgottenKey) -> Rc { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | FORGOTTEN.with(|cell| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 229 | | let mut fg = cell.borrow_mut(); [INFO] [stdout] 230 | | fg.take(k) [INFO] [stdout] 231 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/global/forgotten_impl.rs:617:9 [INFO] [stdout] | [INFO] [stdout] 617 | drop(k); [INFO] [stdout] | ^^^^^-^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `shared_key::SharedForgottenKey` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 617 - drop(k); [INFO] [stdout] 617 + let _ = k; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `forgotten` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b330877e202f55008b035b4b13b99ff7701997c39bb1687e4e691b90e224fe60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b330877e202f55008b035b4b13b99ff7701997c39bb1687e4e691b90e224fe60", kill_on_drop: false }` [INFO] [stdout] b330877e202f55008b035b4b13b99ff7701997c39bb1687e4e691b90e224fe60