[INFO] fetching crate foreignc_template 0.1.1... [INFO] checking foreignc_template-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate foreignc_template 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate foreignc_template 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate foreignc_template 0.1.1 [INFO] finished tweaking crates.io crate foreignc_template 0.1.1 [INFO] tweaked toml for crates.io crate foreignc_template 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 100 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding glob v0.2.11 (latest: v0.3.1) [INFO] [stderr] Adding humansize v1.1.1 (latest: v2.1.3) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding tera v0.11.20 (latest: v1.20.0) [INFO] [stderr] Adding unic-char-property v0.7.0 (latest: v0.9.0) [INFO] [stderr] Adding unic-char-range v0.7.0 (latest: v0.9.0) [INFO] [stderr] Adding unic-common v0.7.0 (latest: v0.9.0) [INFO] [stderr] Adding unic-segment v0.7.0 (latest: v0.9.0) [INFO] [stderr] Adding unic-ucd-segment v0.7.0 (latest: v0.9.0) [INFO] [stderr] Adding unic-ucd-version v0.7.0 (latest: v0.9.0) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdbd5850ddb2e38d5f50164b019fc6ec51d23905725030da9e25d6a55c850f25 [INFO] running `Command { std: "docker" "start" "-a" "cdbd5850ddb2e38d5f50164b019fc6ec51d23905725030da9e25d6a55c850f25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdbd5850ddb2e38d5f50164b019fc6ec51d23905725030da9e25d6a55c850f25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdbd5850ddb2e38d5f50164b019fc6ec51d23905725030da9e25d6a55c850f25", kill_on_drop: false }` [INFO] [stdout] cdbd5850ddb2e38d5f50164b019fc6ec51d23905725030da9e25d6a55c850f25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b4c2ba742e44990fd57fadf6bf7e095089a7dd8eb08d9eff68cded347b58c58e [INFO] running `Command { std: "docker" "start" "-a" "b4c2ba742e44990fd57fadf6bf7e095089a7dd8eb08d9eff68cded347b58c58e", kill_on_drop: false }` [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking unic-char-range v0.7.0 [INFO] [stderr] Checking unic-common v0.7.0 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking unic-char-property v0.7.0 [INFO] [stderr] Checking unic-ucd-version v0.7.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking unic-ucd-segment v0.7.0 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking humansize v1.1.1 [INFO] [stderr] Checking unic-segment v0.7.0 [INFO] [stderr] Compiling foreignc_template v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking foreignc_util v0.1.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tera v0.11.20 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py_types.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn from_rust>(func: T, structs: &mut Vec) -> FunctionABI { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let py_input: Vec = f.inputs.iter().map(|a| PythonTypes::from_rust(&a.ty, structs)).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let py_output: Option = f.output.clone().map(|a| PythonTypes::from_rust(a, structs)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | extern_output: py_output.clone().map(|output| output.get_extern()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py_types.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn from_rust>(func: T, structs: &mut Vec) -> FunctionABI { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let py_input: Vec = f.inputs.iter().map(|a| PythonTypes::from_rust(&a.ty, structs)).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let py_output: Option = f.output.clone().map(|a| PythonTypes::from_rust(a, structs)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | sig_output: py_output.clone().map(|output| output.get_hint()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived_input.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 59 | fn open_file>(p: P) -> TResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(OpenOptions::new() [INFO] [stdout] | ________^ [INFO] [stdout] 61 | | .create(true) [INFO] [stdout] 62 | | .write(true) [INFO] [stdout] 63 | | .open(p)?) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/derived_input.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | panic!(format!("{} does not exist", dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 92 - panic!(format!("{} does not exist", dir)) [INFO] [stdout] 92 + panic!("{} does not exist", dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `foreignc_template` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py_types.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn from_rust>(func: T, structs: &mut Vec) -> FunctionABI { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let py_input: Vec = f.inputs.iter().map(|a| PythonTypes::from_rust(&a.ty, structs)).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let py_output: Option = f.output.clone().map(|a| PythonTypes::from_rust(a, structs)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | extern_output: py_output.clone().map(|output| output.get_extern()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/py_types.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn from_rust>(func: T, structs: &mut Vec) -> FunctionABI { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let py_input: Vec = f.inputs.iter().map(|a| PythonTypes::from_rust(&a.ty, structs)).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let py_output: Option = f.output.clone().map(|a| PythonTypes::from_rust(a, structs)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | sig_output: py_output.clone().map(|output| output.get_hint()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived_input.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 59 | fn open_file>(p: P) -> TResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(OpenOptions::new() [INFO] [stdout] | ________^ [INFO] [stdout] 61 | | .create(true) [INFO] [stdout] 62 | | .write(true) [INFO] [stdout] 63 | | .open(p)?) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/derived_input.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | panic!(format!("{} does not exist", dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 92 - panic!(format!("{} does not exist", dir)) [INFO] [stdout] 92 + panic!("{} does not exist", dir) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `foreignc_template` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b4c2ba742e44990fd57fadf6bf7e095089a7dd8eb08d9eff68cded347b58c58e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4c2ba742e44990fd57fadf6bf7e095089a7dd8eb08d9eff68cded347b58c58e", kill_on_drop: false }` [INFO] [stdout] b4c2ba742e44990fd57fadf6bf7e095089a7dd8eb08d9eff68cded347b58c58e