[INFO] fetching crate forceatlas2 0.7.0... [INFO] checking forceatlas2-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate forceatlas2 0.7.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate forceatlas2 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate forceatlas2 0.7.0 [INFO] finished tweaking crates.io crate forceatlas2 0.7.0 [INFO] tweaked toml for crates.io crate forceatlas2 0.7.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate forceatlas2 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e6564dd3bfe035e8a120b9a093c1fa950b206af1969d5f6156b5bea560263bb [INFO] running `Command { std: "docker" "start" "-a" "5e6564dd3bfe035e8a120b9a093c1fa950b206af1969d5f6156b5bea560263bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e6564dd3bfe035e8a120b9a093c1fa950b206af1969d5f6156b5bea560263bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e6564dd3bfe035e8a120b9a093c1fa950b206af1969d5f6156b5bea560263bb", kill_on_drop: false }` [INFO] [stdout] 5e6564dd3bfe035e8a120b9a093c1fa950b206af1969d5f6156b5bea560263bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f672bd8671b2033e53a80e506725411949b4971fdd40a4f9cea627cc03a162c4 [INFO] running `Command { std: "docker" "start" "-a" "f672bd8671b2033e53a80e506725411949b4971fdd40a4f9cea627cc03a162c4", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking forceatlas2 v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:10 [INFO] [stdout] | [INFO] [stdout] 77 | nodes: impl Iterator)>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | edges: E, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let mut concrete_nodes = O::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | bump: parking_lot::Mutex::new(bumpalo::Bump::with_capacity( [INFO] [stdout] | ___________________^ [INFO] [stdout] 102 | | (concrete_nodes.len() [INFO] [stdout] 103 | | + 4 * (concrete_nodes.len().checked_ilog2().unwrap_or(0) as usize + 1)) [INFO] [stdout] 104 | | * std::mem::size_of::< [INFO] [stdout] 105 | | trees::NodeN, N, 1>, [INFO] [stdout] 106 | | >(), [INFO] [stdout] 107 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:122:10 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn from_positioned(settings: Settings, nodes: O, edges: E) -> Self { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | bump: parking_lot::Mutex::new(bumpalo::Bump::with_capacity( [INFO] [stdout] | ___________________^ [INFO] [stdout] 123 | | (nodes.len() + 4 * (nodes.len().checked_ilog2().unwrap_or(0) as usize + 1)) [INFO] [stdout] 124 | | * std::mem::size_of::< [INFO] [stdout] 125 | | trees::NodeN, N, 1>, [INFO] [stdout] 126 | | >(), [INFO] [stdout] 127 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:22:41 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:32:41 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trees.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new_root<'r>(&'r mut self, pos: (VecN, VecN)) -> Root<'r, D, T, C, L, N> [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | node: bumpalo::boxed::Box::new_in(D::new(pos), self.bump), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:183:8 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn new(x: T, y: T) -> Self { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Self([x, y]) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:206:8 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn new(x: T, y: T, z: T) -> Self { [INFO] [stdout] | ---- ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | Self([x, y, z]) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:10 [INFO] [stdout] | [INFO] [stdout] 77 | nodes: impl Iterator)>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | edges: E, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let mut concrete_nodes = O::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | bump: parking_lot::Mutex::new(bumpalo::Bump::with_capacity( [INFO] [stdout] | ___________________^ [INFO] [stdout] 102 | | (concrete_nodes.len() [INFO] [stdout] 103 | | + 4 * (concrete_nodes.len().checked_ilog2().unwrap_or(0) as usize + 1)) [INFO] [stdout] 104 | | * std::mem::size_of::< [INFO] [stdout] 105 | | trees::NodeN, N, 1>, [INFO] [stdout] 106 | | >(), [INFO] [stdout] 107 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:122:10 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn from_positioned(settings: Settings, nodes: O, edges: E) -> Self { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | bump: parking_lot::Mutex::new(bumpalo::Bump::with_capacity( [INFO] [stdout] | ___________________^ [INFO] [stdout] 123 | | (nodes.len() + 4 * (nodes.len().checked_ilog2().unwrap_or(0) as usize + 1)) [INFO] [stdout] 124 | | * std::mem::size_of::< [INFO] [stdout] 125 | | trees::NodeN, N, 1>, [INFO] [stdout] 126 | | >(), [INFO] [stdout] 127 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:22:41 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/edge.rs:32:41 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(edge, weight)| (edge.clone(), weight.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trees.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new_root<'r>(&'r mut self, pos: (VecN, VecN)) -> Root<'r, D, T, C, L, N> [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | node: bumpalo::boxed::Box::new_in(D::new(pos), self.bump), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:183:8 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn new(x: T, y: T) -> Self { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Self([x, y]) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:206:8 [INFO] [stdout] | [INFO] [stdout] 205 | pub fn new(x: T, y: T, z: T) -> Self { [INFO] [stdout] | ---- ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | Self([x, y, z]) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `forceatlas2` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `forceatlas2` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "f672bd8671b2033e53a80e506725411949b4971fdd40a4f9cea627cc03a162c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f672bd8671b2033e53a80e506725411949b4971fdd40a4f9cea627cc03a162c4", kill_on_drop: false }` [INFO] [stdout] f672bd8671b2033e53a80e506725411949b4971fdd40a4f9cea627cc03a162c4