[INFO] fetching crate for_event_bus 0.1.6... [INFO] checking for_event_bus-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate for_event_bus 0.1.6 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate for_event_bus 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate for_event_bus 0.1.6 [INFO] finished tweaking crates.io crate for_event_bus 0.1.6 [INFO] tweaked toml for crates.io crate for_event_bus 0.1.6 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate for_event_bus 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53d1db36c8175c41430187211e19e0a9779b694a6461ca9494c58ceecc887606 [INFO] running `Command { std: "docker" "start" "-a" "53d1db36c8175c41430187211e19e0a9779b694a6461ca9494c58ceecc887606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53d1db36c8175c41430187211e19e0a9779b694a6461ca9494c58ceecc887606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53d1db36c8175c41430187211e19e0a9779b694a6461ca9494c58ceecc887606", kill_on_drop: false }` [INFO] [stdout] 53d1db36c8175c41430187211e19e0a9779b694a6461ca9494c58ceecc887606 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39066666642e32867185a50ceeccbb131113bacd00d429f5d7283a044f741b71 [INFO] running `Command { std: "docker" "start" "-a" "39066666642e32867185a50ceeccbb131113bacd00d429f5d7283a044f741b71", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling serde v1.0.186 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking notify v5.2.0 [INFO] [stderr] Checking notify-debouncer-mini v0.2.1 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.186 [INFO] [stderr] Compiling for-event-bus-derive v0.1.3 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking flexi_logger v0.24.2 [INFO] [stderr] Checking custom-utils v0.10.15 [INFO] [stderr] Checking for_event_bus v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus/mod.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 218 | let (tx_event, rx_event) = channel(CAP); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let id = WorkerId::init(name); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | ( [INFO] [stdout] 221 | / IdentityCommon { [INFO] [stdout] 222 | | id: id.clone(), [INFO] [stdout] 223 | | rx_event, [INFO] [stdout] 224 | | tx_data: self.tx.clone(), [INFO] [stdout] 225 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus/mod.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 218 | let (tx_event, rx_event) = channel(CAP); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let id = WorkerId::init(name); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | CopyOfWorker::init(id, tx_event), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bus/sub_bus.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | self.name.clone() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus/sub_bus.rs:95:26 [INFO] [stdout] | [INFO] [stdout] 84 | let (tx, rx) = channel(CAP); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | subscribers: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bus/sub_bus.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | name: name.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/mod.rs:60:31 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn init(id: WorkerId, tx_event: Sender) -> Self { [INFO] [stdout] | ------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | subscribe_events: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus/mod.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 218 | let (tx_event, rx_event) = channel(CAP); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let id = WorkerId::init(name); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | ( [INFO] [stdout] 221 | / IdentityCommon { [INFO] [stdout] 222 | | id: id.clone(), [INFO] [stdout] 223 | | rx_event, [INFO] [stdout] 224 | | tx_data: self.tx.clone(), [INFO] [stdout] 225 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus/mod.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 218 | let (tx_event, rx_event) = channel(CAP); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let id = WorkerId::init(name); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | CopyOfWorker::init(id, tx_event), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bus/sub_bus.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | self.name.clone() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bus/sub_bus.rs:95:26 [INFO] [stdout] | [INFO] [stdout] 84 | let (tx, rx) = channel(CAP); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | subscribers: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/bus/sub_bus.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | name: name.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker/mod.rs:60:31 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn init(id: WorkerId, tx_event: Sender) -> Self { [INFO] [stdout] | ------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | subscribe_events: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `for_event_bus` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `for_event_bus` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "39066666642e32867185a50ceeccbb131113bacd00d429f5d7283a044f741b71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39066666642e32867185a50ceeccbb131113bacd00d429f5d7283a044f741b71", kill_on_drop: false }` [INFO] [stdout] 39066666642e32867185a50ceeccbb131113bacd00d429f5d7283a044f741b71