[INFO] fetching crate fontra2fontir 0.0.1... [INFO] checking fontra2fontir-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fontra2fontir 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate fontra2fontir 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fontra2fontir 0.0.1 [INFO] finished tweaking crates.io crate fontra2fontir 0.0.1 [INFO] tweaked toml for crates.io crate fontra2fontir 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 98 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding font-types v0.4.3 (latest: v0.7.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding read-fonts v0.17.0 (latest: v0.21.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding write-fonts v0.25.0 (latest: v0.29.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9429d93ec626afed1275f06c12106b402b3fa89520f578d27da2fbe04c402780 [INFO] running `Command { std: "docker" "start" "-a" "9429d93ec626afed1275f06c12106b402b3fa89520f578d27da2fbe04c402780", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9429d93ec626afed1275f06c12106b402b3fa89520f578d27da2fbe04c402780", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9429d93ec626afed1275f06c12106b402b3fa89520f578d27da2fbe04c402780", kill_on_drop: false }` [INFO] [stdout] 9429d93ec626afed1275f06c12106b402b3fa89520f578d27da2fbe04c402780 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3e2108d04c1170bceb5c21901c6387ebfbc7756ca7f0eafd76724878c598b3a [INFO] running `Command { std: "docker" "start" "-a" "f3e2108d04c1170bceb5c21901c6387ebfbc7756ca7f0eafd76724878c598b3a", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling fontdrasil v0.0.1 [INFO] [stderr] Checking dot2 v1.0.0 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking font-types v0.4.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking kurbo v0.11.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking read-fonts v0.17.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking write-fonts v0.25.0 [INFO] [stderr] Checking fontir v0.0.1 [INFO] [stderr] Checking fontra2fontir v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fontra.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | serde_json::from_str(&raw).map_err(|e| Error::ParseError(p.to_path_buf(), format!("{e}"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 142 | let glyphs = self.glyph_state()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Input { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | static_metadata: static_metadata.clone(), [INFO] [stdout] 151 | | global_metrics: static_metadata, [INFO] [stdout] 152 | | glyphs, [INFO] [stdout] 153 | | features, [INFO] [stdout] 154 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / StaticMetadata::new( [INFO] [stdout] 82 | | font_data.units_per_em, [INFO] [stdout] 83 | | Default::default(), [INFO] [stdout] 84 | | axes, [INFO] [stdout] ... | [INFO] [stdout] 89 | | Default::default(), [INFO] [stdout] 90 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 97 | codepoints: HashSet, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let mut instances = HashMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Glyph::new(fontra_glyph.name.clone(), true, codepoints, instances) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:137:33 [INFO] [stdout] | [INFO] [stdout] 137 | .map(|c| to_ir_path(fontra_glyph.name.clone(), c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:172:29 [INFO] [stdout] | [INFO] [stdout] 171 | .map_err(|e| WorkError::InvalidSourceGlyph { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | glyph_name: glyph_name.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 201 | .map_err(|e| WorkError::InvalidSourceGlyph { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | glyph_name: glyph_name.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fontra2fontir` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fontra.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | serde_json::from_str(&raw).map_err(|e| Error::ParseError(p.to_path_buf(), format!("{e}"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fontra.rs:461:46 [INFO] [stdout] | [INFO] [stdout] 461 | .map(|c| (n.to_string(), c.name.clone()))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 142 | let glyphs = self.glyph_state()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Input { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | static_metadata: static_metadata.clone(), [INFO] [stdout] 151 | | global_metrics: static_metadata, [INFO] [stdout] 152 | | glyphs, [INFO] [stdout] 153 | | features, [INFO] [stdout] 154 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:317:40 [INFO] [stdout] | [INFO] [stdout] 317 | .map(|(name, codepoints)| (GlyphName::new(name), codepoints)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:322:49 [INFO] [stdout] | [INFO] [stdout] 322 | .map(|(name, (_, codepoints))| (name.clone(), codepoints.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / StaticMetadata::new( [INFO] [stdout] 82 | | font_data.units_per_em, [INFO] [stdout] 83 | | Default::default(), [INFO] [stdout] 84 | | axes, [INFO] [stdout] ... | [INFO] [stdout] 89 | | Default::default(), [INFO] [stdout] 90 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 97 | codepoints: HashSet, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let mut instances = HashMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Glyph::new(fontra_glyph.name.clone(), true, codepoints, instances) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:137:33 [INFO] [stdout] | [INFO] [stdout] 137 | .map(|c| to_ir_path(fontra_glyph.name.clone(), c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:172:29 [INFO] [stdout] | [INFO] [stdout] 171 | .map_err(|e| WorkError::InvalidSourceGlyph { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | glyph_name: glyph_name.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toir.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 201 | .map_err(|e| WorkError::InvalidSourceGlyph { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | glyph_name: glyph_name.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fontra2fontir` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "f3e2108d04c1170bceb5c21901c6387ebfbc7756ca7f0eafd76724878c598b3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3e2108d04c1170bceb5c21901c6387ebfbc7756ca7f0eafd76724878c598b3a", kill_on_drop: false }` [INFO] [stdout] f3e2108d04c1170bceb5c21901c6387ebfbc7756ca7f0eafd76724878c598b3a