[INFO] fetching crate fontkit 0.6.0-beta.8... [INFO] checking fontkit-0.6.0-beta.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fontkit 0.6.0-beta.8 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fontkit 0.6.0-beta.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fontkit 0.6.0-beta.8 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate fontkit 0.6.0-beta.8 [INFO] tweaked toml for crates.io crate fontkit 0.6.0-beta.8 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 95 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding brotli v3.5.0 (latest: v6.0.0) [INFO] [stderr] Adding brotli-decompressor v2.5.1 (latest: v4.0.1) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding fast_image_resize v3.0.4 (latest: v4.2.1) [INFO] [stderr] Adding four-cc v0.2.0 (latest: v0.4.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding image v0.23.14 (latest: v0.25.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] [stderr] Adding ordered-float v3.9.2 (latest: v4.2.2) [INFO] [stderr] Adding ouroboros v0.17.2 (latest: v0.18.4) [INFO] [stderr] Adding ouroboros_macro v0.17.2 (latest: v0.18.4) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding strict-num v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding ttf-parser v0.21.1 (latest: v0.24.1) [INFO] [stderr] Adding wit-bindgen-rt v0.24.0 (latest: v0.30.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3fc421ce5ef12fa32d7ecf32d5a37fe32d6b089608d2616fe428547e6eed449f [INFO] running `Command { std: "docker" "start" "-a" "3fc421ce5ef12fa32d7ecf32d5a37fe32d6b089608d2616fe428547e6eed449f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3fc421ce5ef12fa32d7ecf32d5a37fe32d6b089608d2616fe428547e6eed449f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fc421ce5ef12fa32d7ecf32d5a37fe32d6b089608d2616fe428547e6eed449f", kill_on_drop: false }` [INFO] [stdout] 3fc421ce5ef12fa32d7ecf32d5a37fe32d6b089608d2616fe428547e6eed449f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe04a40df49992dea54a9aa6c02961c8bf074d5311bcce7397f3dc3ef6dd8bae [INFO] running `Command { std: "docker" "start" "-a" "fe04a40df49992dea54a9aa6c02961c8bf074d5311bcce7397f3dc3ef6dd8bae", kill_on_drop: false }` [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling pathfinder_simd v0.5.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Checking four-cc v0.2.0 [INFO] [stderr] Compiling ouroboros_macro v0.17.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking inflections v1.1.1 [INFO] [stderr] Checking unicode-script v0.5.6 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking pathfinder_geometry v0.5.1 [INFO] [stderr] Checking pathfinder_color v0.5.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking safer-bytes v0.2.0 [INFO] [stderr] Checking fast_image_resize v3.0.4 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking ouroboros v0.17.2 [INFO] [stderr] Checking pathfinder_content v0.5.0 [INFO] [stderr] Checking woff2-patched v0.3.0 [INFO] [stderr] Checking fontkit v0.6.0-beta.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/font.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 85 | pub(super) struct Name { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 86 | pub id: u16, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Name` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:51 [INFO] [stdout] | [INFO] [stdout] 56 | self.fallback_font_key = font_key.map(|f| Box::new(f) as _); [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | .and_then(|font| font.measure(text).ok()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 18 | let f = self.face.load(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(TextMetrics { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | positions: Arc::new(RwLock::new(positions)), [INFO] [stdout] 98 | | line_gap, [INFO] [stdout] 99 | | content_height: height, [INFO] [stdout] 100 | | ascender: font.ascender(), [INFO] [stdout] 101 | | units: font.units_per_em(), [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:244:24 [INFO] [stdout] | [INFO] [stdout] 234 | let p = self.positions.read().unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | positions: Arc::new(RwLock::new(positions)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/font.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 85 | pub(super) struct Name { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 86 | pub id: u16, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Name` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:51 [INFO] [stdout] | [INFO] [stdout] 56 | self.fallback_font_key = font_key.map(|f| Box::new(f) as _); [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | .and_then(|font| font.measure(text).ok()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 18 | let f = self.face.load(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(TextMetrics { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | positions: Arc::new(RwLock::new(positions)), [INFO] [stdout] 98 | | line_gap, [INFO] [stdout] 99 | | content_height: height, [INFO] [stdout] 100 | | ascender: font.ascender(), [INFO] [stdout] 101 | | units: font.units_per_em(), [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:244:24 [INFO] [stdout] | [INFO] [stdout] 234 | let p = self.positions.read().unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | positions: Arc::new(RwLock::new(positions)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fontkit` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fontkit` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "fe04a40df49992dea54a9aa6c02961c8bf074d5311bcce7397f3dc3ef6dd8bae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe04a40df49992dea54a9aa6c02961c8bf074d5311bcce7397f3dc3ef6dd8bae", kill_on_drop: false }` [INFO] [stdout] fe04a40df49992dea54a9aa6c02961c8bf074d5311bcce7397f3dc3ef6dd8bae