[INFO] fetching crate fontdb 0.21.0... [INFO] checking fontdb-0.21.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fontdb 0.21.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fontdb 0.21.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fontdb 0.21.0 [INFO] finished tweaking crates.io crate fontdb 0.21.0 [INFO] tweaked toml for crates.io crate fontdb 0.21.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate fontdb 0.21.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac0cdc8687b083f1dd5961fcf2995c4d82b7a71412ce1fc5153d40e856de3508 [INFO] running `Command { std: "docker" "start" "-a" "ac0cdc8687b083f1dd5961fcf2995c4d82b7a71412ce1fc5153d40e856de3508", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac0cdc8687b083f1dd5961fcf2995c4d82b7a71412ce1fc5153d40e856de3508", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac0cdc8687b083f1dd5961fcf2995c4d82b7a71412ce1fc5153d40e856de3508", kill_on_drop: false }` [INFO] [stdout] ac0cdc8687b083f1dd5961fcf2995c4d82b7a71412ce1fc5153d40e856de3508 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 62ee75a99622d403e2c07ed47591712dac4ee9462dece0f9ac5f9c6a64144f0b [INFO] running `Command { std: "docker" "start" "-a" "62ee75a99622d403e2c07ed47591712dac4ee9462dece0f9ac5f9c6a64144f0b", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking fontconfig-parser v0.5.6 [INFO] [stderr] Checking core_maths v0.1.0 [INFO] [stderr] Checking ttf-parser v0.24.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking fontdb v0.21.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:305:53 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn load_fonts_dir>(&mut self, dir: P) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | self.load_fonts_dir_impl(dir.as_ref(), &mut Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:568:39 [INFO] [stdout] | [INFO] [stdout] 567 | pub fn push_face_info(&mut self, mut info: FaceInfo) -> ID { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 568 | ID(self.faces.insert_with_key(|k| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 569 | | info.id = ID(k); [INFO] [stdout] 570 | | info [INFO] [stdout] 571 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:679:35 [INFO] [stdout] | [INFO] [stdout] 679 | self.face(id).map(|info| (info.source.clone(), info.index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:706:23 [INFO] [stdout] | [INFO] [stdout] 701 | pub fn with_face_data(&self, id: ID, p: P) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 705 | let (src, face_index) = self.face_source(id)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 706 | src.with_data(|data| p(data, face_index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:754:14 [INFO] [stdout] | [INFO] [stdout] 729 | let old_source = face_info.source.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 730 | [INFO] [stdout] 731 | let (path, shared_data) = match &old_source { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | let file = std::fs::File::open(path).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 737 | let shared_data = std::sync::Arc::new(memmap2::MmapOptions::new().map(&file).ok()?) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 746 | let shared_source = Source::SharedFile(path.clone(), shared_data.clone()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 754 | Some((shared_data, face_index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1024:8 [INFO] [stdout] | [INFO] [stdout] 1014 | fn parse_face_info(source: Source, data: &[u8], index: u32) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1024 | Ok(FaceInfo { [INFO] [stdout] | ________^ [INFO] [stdout] 1025 | | id: ID::dummy(), [INFO] [stdout] 1026 | | source, [INFO] [stdout] 1027 | | index, [INFO] [stdout] ... | [INFO] [stdout] 1033 | | monospaced, [INFO] [stdout] 1034 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fontdb` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:305:53 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn load_fonts_dir>(&mut self, dir: P) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | self.load_fonts_dir_impl(dir.as_ref(), &mut Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:568:39 [INFO] [stdout] | [INFO] [stdout] 567 | pub fn push_face_info(&mut self, mut info: FaceInfo) -> ID { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 568 | ID(self.faces.insert_with_key(|k| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 569 | | info.id = ID(k); [INFO] [stdout] 570 | | info [INFO] [stdout] 571 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:679:35 [INFO] [stdout] | [INFO] [stdout] 679 | self.face(id).map(|info| (info.source.clone(), info.index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:706:23 [INFO] [stdout] | [INFO] [stdout] 701 | pub fn with_face_data(&self, id: ID, p: P) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 705 | let (src, face_index) = self.face_source(id)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 706 | src.with_data(|data| p(data, face_index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:754:14 [INFO] [stdout] | [INFO] [stdout] 729 | let old_source = face_info.source.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 730 | [INFO] [stdout] 731 | let (path, shared_data) = match &old_source { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | let file = std::fs::File::open(path).ok()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 737 | let shared_data = std::sync::Arc::new(memmap2::MmapOptions::new().map(&file).ok()?) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 746 | let shared_source = Source::SharedFile(path.clone(), shared_data.clone()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 754 | Some((shared_data, face_index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1024:8 [INFO] [stdout] | [INFO] [stdout] 1014 | fn parse_face_info(source: Source, data: &[u8], index: u32) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1024 | Ok(FaceInfo { [INFO] [stdout] | ________^ [INFO] [stdout] 1025 | | id: ID::dummy(), [INFO] [stdout] 1026 | | source, [INFO] [stdout] 1027 | | index, [INFO] [stdout] ... | [INFO] [stdout] 1033 | | monospaced, [INFO] [stdout] 1034 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fontdb` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "62ee75a99622d403e2c07ed47591712dac4ee9462dece0f9ac5f9c6a64144f0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62ee75a99622d403e2c07ed47591712dac4ee9462dece0f9ac5f9c6a64144f0b", kill_on_drop: false }` [INFO] [stdout] 62ee75a99622d403e2c07ed47591712dac4ee9462dece0f9ac5f9c6a64144f0b