[INFO] fetching crate font-atlas 0.1.4... [INFO] checking font-atlas-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate font-atlas 0.1.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate font-atlas 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate font-atlas 0.1.4 [INFO] finished tweaking crates.io crate font-atlas 0.1.4 [INFO] tweaked toml for crates.io crate font-atlas 0.1.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding rusttype v0.2.4 (latest: v0.9.3) [INFO] [stderr] Adding stb_truetype v0.2.8 (latest: v0.3.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be6c0241d9042f48b845536c825ecfe604276592174d5e19519e6fdab3dde49b [INFO] running `Command { std: "docker" "start" "-a" "be6c0241d9042f48b845536c825ecfe604276592174d5e19519e6fdab3dde49b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be6c0241d9042f48b845536c825ecfe604276592174d5e19519e6fdab3dde49b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be6c0241d9042f48b845536c825ecfe604276592174d5e19519e6fdab3dde49b", kill_on_drop: false }` [INFO] [stdout] be6c0241d9042f48b845536c825ecfe604276592174d5e19519e6fdab3dde49b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be712f71582eefe07278a8a98afa3bc376ce1337c908054a869296d9c291309c [INFO] running `Command { std: "docker" "start" "-a" "be712f71582eefe07278a8a98afa3bc376ce1337c908054a869296d9c291309c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking stb_truetype v0.2.8 [INFO] [stderr] Checking rusttype v0.2.4 [INFO] [stderr] Checking font-atlas v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | let fc = try!(FaceCache::new(font, scale, chars, f).or_else(|e| Err(FontCacheError::UserError(e)))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 115 | let fc = try!(self.get_face_cache(font_name, scale).ok_or(FontCacheError::NoRenderedFace(font_name.into(), scale))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | try!(self.create_face(font_name, scale, string.chars(), |a| f(a))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | try!(fc.prepare_string(string, f).map_err(FontCacheError::UserError)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:147:26 [INFO] [stdout] | [INFO] [stdout] 147 | let bitmap = try!(f(bitmap)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | try!(self.prepare_string(s, f)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | try!(try!(File::open(path)).read_to_end(&mut buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:29:10 [INFO] [stdout] | [INFO] [stdout] 29 | try!(try!(File::open(path)).read_to_end(&mut buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | let fc = try!(FaceCache::new(font, scale, chars, f).or_else(|e| Err(FontCacheError::UserError(e)))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 115 | let fc = try!(self.get_face_cache(font_name, scale).ok_or(FontCacheError::NoRenderedFace(font_name.into(), scale))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | try!(self.create_face(font_name, scale, string.chars(), |a| f(a))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | try!(fc.prepare_string(string, f).map_err(FontCacheError::UserError)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:147:26 [INFO] [stdout] | [INFO] [stdout] 147 | let bitmap = try!(f(bitmap)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/cache/mod.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | try!(self.prepare_string(s, f)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | try!(try!(File::open(path)).read_to_end(&mut buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:29:10 [INFO] [stdout] | [INFO] [stdout] 29 | try!(try!(File::open(path)).read_to_end(&mut buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn load_font>(path: P) -> IoResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(load_font_from_bytes(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/mod.rs:87:85 [INFO] [stdout] | [INFO] [stdout] 87 | let fc = try!(FaceCache::new(font, scale, chars, f).or_else(|e| Err(FontCacheError::UserError(e)))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/mod.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(font: Font, scale: f32, chars: I, f: F) -> Result, E> [INFO] [stdout] | ---------- -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let bitmap = try!(f(bitmap)); [INFO] [stdout] | ------ --------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | Ok(FaceCache { [INFO] [stdout] | ________________^ [INFO] [stdout] 149 | | font: font, [INFO] [stdout] 150 | | atlas: atlas, [INFO] [stdout] 151 | | bitmap: bitmap, [INFO] [stdout] ... | [INFO] [stdout] 155 | | line_height: line_height, [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/mod.rs:165:77 [INFO] [stdout] | [INFO] [stdout] 165 | match self.font.render_char(c, self.scale).map(|(i, a)| (i, f(a))) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn load_font>(path: P) -> IoResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(load_font_from_bytes(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/mod.rs:87:85 [INFO] [stdout] | [INFO] [stdout] 87 | let fc = try!(FaceCache::new(font, scale, chars, f).or_else(|e| Err(FontCacheError::UserError(e)))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/mod.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn new(font: Font, scale: f32, chars: I, f: F) -> Result, E> [INFO] [stdout] | ---------- -------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let bitmap = try!(f(bitmap)); [INFO] [stdout] | ------ --------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | Ok(FaceCache { [INFO] [stdout] | ________________^ [INFO] [stdout] 149 | | font: font, [INFO] [stdout] 150 | | atlas: atlas, [INFO] [stdout] 151 | | bitmap: bitmap, [INFO] [stdout] ... | [INFO] [stdout] 155 | | line_height: line_height, [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/mod.rs:165:77 [INFO] [stdout] | [INFO] [stdout] 165 | match self.font.render_char(c, self.scale).map(|(i, a)| (i, f(a))) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `font-atlas` (lib test) due to 5 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `font-atlas` (lib) due to 5 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "be712f71582eefe07278a8a98afa3bc376ce1337c908054a869296d9c291309c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be712f71582eefe07278a8a98afa3bc376ce1337c908054a869296d9c291309c", kill_on_drop: false }` [INFO] [stdout] be712f71582eefe07278a8a98afa3bc376ce1337c908054a869296d9c291309c