[INFO] fetching crate folca 0.1.0... [INFO] checking folca-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate folca 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate folca 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate folca 0.1.0 [INFO] finished tweaking crates.io crate folca 0.1.0 [INFO] tweaked toml for crates.io crate folca 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate folca 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcdb81666d2e924aa9a67f8e18bab2c80ba8346097097c7d7d4c2661fde0a363 [INFO] running `Command { std: "docker" "start" "-a" "fcdb81666d2e924aa9a67f8e18bab2c80ba8346097097c7d7d4c2661fde0a363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcdb81666d2e924aa9a67f8e18bab2c80ba8346097097c7d7d4c2661fde0a363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcdb81666d2e924aa9a67f8e18bab2c80ba8346097097c7d7d4c2661fde0a363", kill_on_drop: false }` [INFO] [stdout] fcdb81666d2e924aa9a67f8e18bab2c80ba8346097097c7d7d4c2661fde0a363 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 89d6bfc9e7dac5e81e92c7724249d60f43aa6e3adf8fe9435b51c020ac61b2e3 [INFO] running `Command { std: "docker" "start" "-a" "89d6bfc9e7dac5e81e92c7724249d60f43aa6e3adf8fe9435b51c020ac61b2e3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling eyre v0.6.5 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking gimli v0.24.0 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking object v0.24.0 [INFO] [stderr] Checking rustc-demangle v0.1.19 [INFO] [stderr] Checking owo-colors v1.3.0 [INFO] [stderr] Checking tracing-subscriber v0.2.18 [INFO] [stderr] Checking subtle v2.4.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking filetime v0.2.14 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking tar v0.4.33 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking dircpy-stable v0.3.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling backtrace v0.3.59 [INFO] [stderr] Compiling blake3 v0.3.7 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking addr2line v0.15.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking simplelog v0.10.0 [INFO] [stderr] Checking globset v0.4.6 [INFO] [stderr] Checking bytefmt v0.1.7 [INFO] [stderr] Checking ignore v0.4.17 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking tracing-error v0.1.2 [INFO] [stderr] Checking color-spantrace v0.1.6 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking color-eyre v0.5.11 [INFO] [stderr] Checking ron v0.6.4 [INFO] [stderr] Checking folca v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 198 | .try_fold(0u64, |sum, entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | entry.and_then(|entry| entry.metadata()).map(|metadata| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:225:25 [INFO] [stdout] | [INFO] [stdout] 223 | .and_then(|enc| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let mut tar = tar::Builder::new(enc); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | tar.append_dir_all(".", &output_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 324 | let mut hasher = blake3::Hasher::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | / WalkBuilder::new(&self.input_path) [INFO] [stdout] 374 | | .hidden(self.hidden) [INFO] [stdout] 375 | | .git_exclude(!self.no_ignore) [INFO] [stdout] 376 | | .sort_by_file_path(|p1, p2| p1.cmp(p2)) [INFO] [stdout] ... | [INFO] [stdout] 379 | | .try_for_each(update_hash) [INFO] [stdout] 380 | | .wrap_err("Folca: cannot hash input") [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:351:13 [INFO] [stdout] | [INFO] [stdout] 333 | let update_hash = |entry: Result| -> Result<()> { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | let dir_entry = entry.map_err(|e| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | / File::open(path) [INFO] [stdout] 352 | | .map(|file| BufReader::new(file)) [INFO] [stdout] 353 | | .and_then(|mut reader| { [INFO] [stdout] 354 | | reader.read_to_end(&mut buffer).map(|_| { [INFO] [stdout] ... | [INFO] [stdout] 365 | | }) [INFO] [stdout] 366 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:354:21 [INFO] [stdout] | [INFO] [stdout] 353 | .and_then(|mut reader| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | reader.read_to_end(&mut buffer).map(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `folca` (bin "folca" test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 198 | .try_fold(0u64, |sum, entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | entry.and_then(|entry| entry.metadata()).map(|metadata| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:225:25 [INFO] [stdout] | [INFO] [stdout] 223 | .and_then(|enc| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let mut tar = tar::Builder::new(enc); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | tar.append_dir_all(".", &output_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 324 | let mut hasher = blake3::Hasher::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | / WalkBuilder::new(&self.input_path) [INFO] [stdout] 374 | | .hidden(self.hidden) [INFO] [stdout] 375 | | .git_exclude(!self.no_ignore) [INFO] [stdout] 376 | | .sort_by_file_path(|p1, p2| p1.cmp(p2)) [INFO] [stdout] ... | [INFO] [stdout] 379 | | .try_for_each(update_hash) [INFO] [stdout] 380 | | .wrap_err("Folca: cannot hash input") [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:351:13 [INFO] [stdout] | [INFO] [stdout] 333 | let update_hash = |entry: Result| -> Result<()> { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | let dir_entry = entry.map_err(|e| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | / File::open(path) [INFO] [stdout] 352 | | .map(|file| BufReader::new(file)) [INFO] [stdout] 353 | | .and_then(|mut reader| { [INFO] [stdout] 354 | | reader.read_to_end(&mut buffer).map(|_| { [INFO] [stdout] ... | [INFO] [stdout] 365 | | }) [INFO] [stdout] 366 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:354:21 [INFO] [stdout] | [INFO] [stdout] 353 | .and_then(|mut reader| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | reader.read_to_end(&mut buffer).map(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `folca` (bin "folca") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "89d6bfc9e7dac5e81e92c7724249d60f43aa6e3adf8fe9435b51c020ac61b2e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89d6bfc9e7dac5e81e92c7724249d60f43aa6e3adf8fe9435b51c020ac61b2e3", kill_on_drop: false }` [INFO] [stdout] 89d6bfc9e7dac5e81e92c7724249d60f43aa6e3adf8fe9435b51c020ac61b2e3