[INFO] fetching crate fn-fixture-lib 1.0.2... [INFO] checking fn-fixture-lib-1.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fn-fixture-lib 1.0.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate fn-fixture-lib 1.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fn-fixture-lib 1.0.2 [INFO] finished tweaking crates.io crate fn-fixture-lib 1.0.2 [INFO] tweaked toml for crates.io crate fn-fixture-lib 1.0.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f37ae5f7d15e981e4ccdb8a21831c68707c44898fb066e529c7ec8aa85e1fd4 [INFO] running `Command { std: "docker" "start" "-a" "4f37ae5f7d15e981e4ccdb8a21831c68707c44898fb066e529c7ec8aa85e1fd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f37ae5f7d15e981e4ccdb8a21831c68707c44898fb066e529c7ec8aa85e1fd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f37ae5f7d15e981e4ccdb8a21831c68707c44898fb066e529c7ec8aa85e1fd4", kill_on_drop: false }` [INFO] [stdout] 4f37ae5f7d15e981e4ccdb8a21831c68707c44898fb066e529c7ec8aa85e1fd4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d1590c6974b5e68ccfc3707e3c8df3f831a58175eaaba3d18abf01add6a08f4 [INFO] running `Command { std: "docker" "start" "-a" "3d1590c6974b5e68ccfc3707e3c8df3f831a58175eaaba3d18abf01add6a08f4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking fn-fixture-lib v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 172 | fn pull_function_description(item: TokenStream) -> Result<(Ident, Generics, (Ident, Type)), TokenStream> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let Signature { [INFO] [stdout] 174 | ident: name, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | inputs: param, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | generics, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let param: SmallVec<[FnArg; 1]> = param.into_iter().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let param = match param.into_inner() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok([param]) => param, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Err(ref param) if param.is_empty() => return ().compile_err("No input parameter"), [INFO] [stdout] 185 | Err(param) => return ().compile_error(fmt!( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let (param_type, param_name) = match param { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | FnArg::Typed(PatType { pat, ty, .. }) => (*ty, *pat), [INFO] [stdout] | --- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | param => return ().compile_error(fmt!("Unexpected self in {}", param.into_token_stream())), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | }; [INFO] [stdout] 198 | let param_name = match param_name { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Pat::Ident(PatIdent { ident, .. }) => ident, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | pat => return ().compile_error(fmt!("Expected parameter, received {}", pat.into_token_stream())), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | Ok((name, generics, (param_name, param_type))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 217 | folders: impl IntoIterator>, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let super_chain = { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let mut super_chain = super_chain.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | / folders [INFO] [stdout] 234 | | .into_iter() [INFO] [stdout] 235 | | .map(|result| result.and_then(|fixture: DirEntry| { [INFO] [stdout] 236 | | let fixture_path = fixture [INFO] [stdout] ... | [INFO] [stdout] 370 | | })) [INFO] [stdout] 371 | | .map(EitherResult::either) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:350:48 [INFO] [stdout] | [INFO] [stdout] 350 | let make_literal = |path: PathBuf| path [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 351 | | .to_str() [INFO] [stdout] 352 | | .compile_error(fmt!("Failed to get utf8 string from {:?}", path)) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fn-fixture-lib` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 172 | fn pull_function_description(item: TokenStream) -> Result<(Ident, Generics, (Ident, Type)), TokenStream> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let Signature { [INFO] [stdout] 174 | ident: name, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | inputs: param, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | generics, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let param: SmallVec<[FnArg; 1]> = param.into_iter().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let param = match param.into_inner() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok([param]) => param, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Err(ref param) if param.is_empty() => return ().compile_err("No input parameter"), [INFO] [stdout] 185 | Err(param) => return ().compile_error(fmt!( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let (param_type, param_name) = match param { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | FnArg::Typed(PatType { pat, ty, .. }) => (*ty, *pat), [INFO] [stdout] | --- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | param => return ().compile_error(fmt!("Unexpected self in {}", param.into_token_stream())), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | }; [INFO] [stdout] 198 | let param_name = match param_name { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Pat::Ident(PatIdent { ident, .. }) => ident, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | pat => return ().compile_error(fmt!("Expected parameter, received {}", pat.into_token_stream())), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | Ok((name, generics, (param_name, param_type))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 217 | folders: impl IntoIterator>, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | let super_chain = { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let mut super_chain = super_chain.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | / folders [INFO] [stdout] 234 | | .into_iter() [INFO] [stdout] 235 | | .map(|result| result.and_then(|fixture: DirEntry| { [INFO] [stdout] 236 | | let fixture_path = fixture [INFO] [stdout] ... | [INFO] [stdout] 370 | | })) [INFO] [stdout] 371 | | .map(EitherResult::either) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:350:48 [INFO] [stdout] | [INFO] [stdout] 350 | let make_literal = |path: PathBuf| path [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 351 | | .to_str() [INFO] [stdout] 352 | | .compile_error(fmt!("Failed to get utf8 string from {:?}", path)) [INFO] [stdout] | |_________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fn-fixture-lib` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "3d1590c6974b5e68ccfc3707e3c8df3f831a58175eaaba3d18abf01add6a08f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d1590c6974b5e68ccfc3707e3c8df3f831a58175eaaba3d18abf01add6a08f4", kill_on_drop: false }` [INFO] [stdout] 3d1590c6974b5e68ccfc3707e3c8df3f831a58175eaaba3d18abf01add6a08f4