[INFO] fetching crate fmtools 0.1.2... [INFO] checking fmtools-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fmtools 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate fmtools 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fmtools 0.1.2 [INFO] finished tweaking crates.io crate fmtools 0.1.2 [INFO] tweaked toml for crates.io crate fmtools 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 056c82e49946124a63695c335edc2678bd2a182003ee80e76e767df0753a6993 [INFO] running `Command { std: "docker" "start" "-a" "056c82e49946124a63695c335edc2678bd2a182003ee80e76e767df0753a6993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "056c82e49946124a63695c335edc2678bd2a182003ee80e76e767df0753a6993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "056c82e49946124a63695c335edc2678bd2a182003ee80e76e767df0753a6993", kill_on_drop: false }` [INFO] [stdout] 056c82e49946124a63695c335edc2678bd2a182003ee80e76e767df0753a6993 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2550795397cea7eadb582a6c59dc9e6ccec6f791f84949e47685a0b26c2b3f18 [INFO] running `Command { std: "docker" "start" "-a" "2550795397cea7eadb582a6c59dc9e6ccec6f791f84949e47685a0b26c2b3f18", kill_on_drop: false }` [INFO] [stderr] Checking fmtools v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/join.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn join(sep: &'static str, collection: T) -> impl fmt::Display + fmt::Debug [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let iter = collection.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | crate::fmt(move |f| { [INFO] [stdout] | ________________^ [INFO] [stdout] 17 | | let mut draw = false; [INFO] [stdout] 18 | | for item in iter.clone() { [INFO] [stdout] 19 | | if sep.len() > 0 { [INFO] [stdout] ... | [INFO] [stdout] 27 | | Ok(()) [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fmtools` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/join.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn join(sep: &'static str, collection: T) -> impl fmt::Display + fmt::Debug [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let iter = collection.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | crate::fmt(move |f| { [INFO] [stdout] | ________________^ [INFO] [stdout] 17 | | let mut draw = false; [INFO] [stdout] 18 | | for item in iter.clone() { [INFO] [stdout] 19 | | if sep.len() > 0 { [INFO] [stdout] ... | [INFO] [stdout] 27 | | Ok(()) [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fmtools` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "2550795397cea7eadb582a6c59dc9e6ccec6f791f84949e47685a0b26c2b3f18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2550795397cea7eadb582a6c59dc9e6ccec6f791f84949e47685a0b26c2b3f18", kill_on_drop: false }` [INFO] [stdout] 2550795397cea7eadb582a6c59dc9e6ccec6f791f84949e47685a0b26c2b3f18