[INFO] fetching crate fly-migrate 0.2.1... [INFO] checking fly-migrate-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fly-migrate 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate fly-migrate 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fly-migrate 0.2.1 [INFO] finished tweaking crates.io crate fly-migrate 0.2.1 [INFO] tweaked toml for crates.io crate fly-migrate 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate fly-migrate 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9dfd49da48e10af5169638061a401d8b1f098881ae0cef09d39e2e862d275b9 [INFO] running `Command { std: "docker" "start" "-a" "c9dfd49da48e10af5169638061a401d8b1f098881ae0cef09d39e2e862d275b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9dfd49da48e10af5169638061a401d8b1f098881ae0cef09d39e2e862d275b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9dfd49da48e10af5169638061a401d8b1f098881ae0cef09d39e2e862d275b9", kill_on_drop: false }` [INFO] [stdout] c9dfd49da48e10af5169638061a401d8b1f098881ae0cef09d39e2e862d275b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b422c5def530e82f78d56dcd6f0e4b8274bcaccc34ef220605c64072c2f68975 [INFO] running `Command { std: "docker" "start" "-a" "b422c5def530e82f78d56dcd6f0e4b8274bcaccc34ef220605c64072c2f68975", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking finl_unicode v1.2.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking stringprep v0.1.4 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking postgres-protocol v0.6.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling postgres-derive v0.4.5 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking postgres-types v0.2.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking tokio-postgres v0.7.10 [INFO] [stderr] Checking postgres v0.19.7 [INFO] [stderr] Checking fly-migrate-core v0.2.1 [INFO] [stderr] Checking fly-migrate v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 38 | let mut command = Command::new("createdb"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(TestDatabase { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | database: name, [INFO] [stdout] 50 | | host, [INFO] [stdout] 51 | | port, [INFO] [stdout] 52 | | user, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fly-migrate` (test "common") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 38 | let mut command = Command::new("createdb"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(TestDatabase { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | database: name, [INFO] [stdout] 50 | | host, [INFO] [stdout] 51 | | port, [INFO] [stdout] 52 | | user, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fly-migrate` (test "cli_test") due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 26 | let mut db = Db::connect(&config).context("couldn't connect to database")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok((db, application_state)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fly-migrate` (bin "fly") due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 26 | let mut db = Db::connect(&config).context("couldn't connect to database")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok((db, application_state)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fly-migrate` (bin "fly" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "b422c5def530e82f78d56dcd6f0e4b8274bcaccc34ef220605c64072c2f68975", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b422c5def530e82f78d56dcd6f0e4b8274bcaccc34ef220605c64072c2f68975", kill_on_drop: false }` [INFO] [stdout] b422c5def530e82f78d56dcd6f0e4b8274bcaccc34ef220605c64072c2f68975