[INFO] fetching crate fluid-xenth 0.9.0... [INFO] checking fluid-xenth-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fluid-xenth 0.9.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate fluid-xenth 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fluid-xenth 0.9.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate fluid-xenth 0.9.0 [INFO] tweaked toml for crates.io crate fluid-xenth 0.9.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate fluid-xenth 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abfa48ad4d67818e845dad8c9c07e854d9dcc1cb5b5fc40c038a37f9bcfcd95f [INFO] running `Command { std: "docker" "start" "-a" "abfa48ad4d67818e845dad8c9c07e854d9dcc1cb5b5fc40c038a37f9bcfcd95f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abfa48ad4d67818e845dad8c9c07e854d9dcc1cb5b5fc40c038a37f9bcfcd95f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abfa48ad4d67818e845dad8c9c07e854d9dcc1cb5b5fc40c038a37f9bcfcd95f", kill_on_drop: false }` [INFO] [stdout] abfa48ad4d67818e845dad8c9c07e854d9dcc1cb5b5fc40c038a37f9bcfcd95f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a6c990cfe26fa7626950058be5dacb6c8cf134826d63e276a42fad02445951f [INFO] running `Command { std: "docker" "start" "-a" "5a6c990cfe26fa7626950058be5dacb6c8cf134826d63e276a42fad02445951f", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking riff v1.0.1 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Checking tune v0.35.0 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking soundfont v0.0.3 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking oxisynth v0.0.5 [INFO] [stderr] Checking fluid-xenth v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 28 | let (xenth, tuners) = [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | create_internal(desc, per_semitone_polyphony, |synth| AotTuner::start(synth))?; [INFO] [stdout] 30 | Ok((xenth, AotXenthControl { tuners })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 41 | let (xenth, tuners) = create_internal(desc, per_semitone_polyphony, |synth| { [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok((xenth, JitXenthControl { tuners })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 55 | let (xenth, tuners) = create_internal(desc, per_semitone_polyphony, |synth| synth)?; [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok((xenth, tuners)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 62 | mut xenth_control_creator: C, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let synth = oxisynth::Synth::new(desc)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | let tuners = (0..synth.count_midi_channels()) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let xenth = Xenth { synth, receiver }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | Ok((xenth, tuners)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:49 [INFO] [stdout] | [INFO] [stdout] 166 | command: impl FnMut(&mut oxisynth::Synth, u8) -> Result<(), OxiError> + Send + 'static, [INFO] [stdout] | -------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | ) -> SendCommandResult { [INFO] [stdout] 168 | self.get_tuner(xen_channel).global_attr(Box::new(command)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:215:49 [INFO] [stdout] | [INFO] [stdout] 213 | command: impl FnMut(&mut oxisynth::Synth, u8) -> Result<(), OxiError> + Send + 'static, [INFO] [stdout] | -------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | ) -> SendCommandResult { [INFO] [stdout] 215 | self.get_tuner(xen_channel).global_attr(Box::new(command)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:27 [INFO] [stdout] | [INFO] [stdout] 315 | fn global_attr(&mut self, mut command: ChannelCommand) -> SendCommandResult { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let channels = (self.get_channel(0)..).take(self.polyphony); [INFO] [stdout] 317 | self.send_command(move |s| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 318 | | for channel in channels { [INFO] [stdout] 319 | | command(s, channel)?; [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | Ok(()) [INFO] [stdout] 322 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fluid-xenth` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 28 | let (xenth, tuners) = [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | create_internal(desc, per_semitone_polyphony, |synth| AotTuner::start(synth))?; [INFO] [stdout] 30 | Ok((xenth, AotXenthControl { tuners })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 41 | let (xenth, tuners) = create_internal(desc, per_semitone_polyphony, |synth| { [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok((xenth, JitXenthControl { tuners })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 55 | let (xenth, tuners) = create_internal(desc, per_semitone_polyphony, |synth| synth)?; [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok((xenth, tuners)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 62 | mut xenth_control_creator: C, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let synth = oxisynth::Synth::new(desc)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | [INFO] [stdout] 67 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | let tuners = (0..synth.count_midi_channels()) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let xenth = Xenth { synth, receiver }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | [INFO] [stdout] 83 | Ok((xenth, tuners)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:49 [INFO] [stdout] | [INFO] [stdout] 166 | command: impl FnMut(&mut oxisynth::Synth, u8) -> Result<(), OxiError> + Send + 'static, [INFO] [stdout] | -------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | ) -> SendCommandResult { [INFO] [stdout] 168 | self.get_tuner(xen_channel).global_attr(Box::new(command)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:215:49 [INFO] [stdout] | [INFO] [stdout] 213 | command: impl FnMut(&mut oxisynth::Synth, u8) -> Result<(), OxiError> + Send + 'static, [INFO] [stdout] | -------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | ) -> SendCommandResult { [INFO] [stdout] 215 | self.get_tuner(xen_channel).global_attr(Box::new(command)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:27 [INFO] [stdout] | [INFO] [stdout] 315 | fn global_attr(&mut self, mut command: ChannelCommand) -> SendCommandResult { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let channels = (self.get_channel(0)..).take(self.polyphony); [INFO] [stdout] 317 | self.send_command(move |s| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 318 | | for channel in channels { [INFO] [stdout] 319 | | command(s, channel)?; [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | Ok(()) [INFO] [stdout] 322 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fluid-xenth` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "5a6c990cfe26fa7626950058be5dacb6c8cf134826d63e276a42fad02445951f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a6c990cfe26fa7626950058be5dacb6c8cf134826d63e276a42fad02445951f", kill_on_drop: false }` [INFO] [stdout] 5a6c990cfe26fa7626950058be5dacb6c8cf134826d63e276a42fad02445951f