[INFO] fetching crate fluid-let 1.0.0... [INFO] checking fluid-let-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fluid-let 1.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate fluid-let 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fluid-let 1.0.0 [INFO] finished tweaking crates.io crate fluid-let 1.0.0 [INFO] tweaked toml for crates.io crate fluid-let 1.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d4bf7213e719ab51e1d191f12de575db1aad3549db72c7569a40480ae664cfd [INFO] running `Command { std: "docker" "start" "-a" "5d4bf7213e719ab51e1d191f12de575db1aad3549db72c7569a40480ae664cfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d4bf7213e719ab51e1d191f12de575db1aad3549db72c7569a40480ae664cfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d4bf7213e719ab51e1d191f12de575db1aad3549db72c7569a40480ae664cfd", kill_on_drop: false }` [INFO] [stdout] 5d4bf7213e719ab51e1d191f12de575db1aad3549db72c7569a40480ae664cfd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6993d4b3616af03b17b35c0460dcebd0b3020bcb0b6b4f540874f1887680b076 [INFO] running `Command { std: "docker" "start" "-a" "6993d4b3616af03b17b35c0460dcebd0b3020bcb0b6b4f540874f1887680b076", kill_on_drop: false }` [INFO] [stderr] Checking fluid-let v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 471 | pub fn get(&self, f: impl FnOnce(Option<&T>) -> R) -> R { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 472 | self.cell.with(|current| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 473 | | // This is safe because the lifetime of the reference returned by get() [INFO] [stdout] 474 | | // is limited to this block so it cannot outlive any value set by set() [INFO] [stdout] 475 | | // in the caller frames. [INFO] [stdout] 476 | | f(unsafe { current.get() }) [INFO] [stdout] 477 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:482:24 [INFO] [stdout] | [INFO] [stdout] 481 | pub fn set(&self, value: impl Borrow, f: impl FnOnce() -> R) -> R { [INFO] [stdout] | --------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | self.cell.with(|current| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 483 | | // This is safe because the guard returned by set() is guaranteed to be [INFO] [stdout] 484 | | // dropped after the thunk returns and before anything else executes. [INFO] [stdout] 485 | | let _guard_ = unsafe { current.set(value.borrow()) }; [INFO] [stdout] 486 | | f() [INFO] [stdout] 487 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fluid-let` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 471 | pub fn get(&self, f: impl FnOnce(Option<&T>) -> R) -> R { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 472 | self.cell.with(|current| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 473 | | // This is safe because the lifetime of the reference returned by get() [INFO] [stdout] 474 | | // is limited to this block so it cannot outlive any value set by set() [INFO] [stdout] 475 | | // in the caller frames. [INFO] [stdout] 476 | | f(unsafe { current.get() }) [INFO] [stdout] 477 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:482:24 [INFO] [stdout] | [INFO] [stdout] 481 | pub fn set(&self, value: impl Borrow, f: impl FnOnce() -> R) -> R { [INFO] [stdout] | --------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | self.cell.with(|current| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 483 | | // This is safe because the guard returned by set() is guaranteed to be [INFO] [stdout] 484 | | // dropped after the thunk returns and before anything else executes. [INFO] [stdout] 485 | | let _guard_ = unsafe { current.set(value.borrow()) }; [INFO] [stdout] 486 | | f() [INFO] [stdout] 487 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fluid-let` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "6993d4b3616af03b17b35c0460dcebd0b3020bcb0b6b4f540874f1887680b076", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6993d4b3616af03b17b35c0460dcebd0b3020bcb0b6b4f540874f1887680b076", kill_on_drop: false }` [INFO] [stdout] 6993d4b3616af03b17b35c0460dcebd0b3020bcb0b6b4f540874f1887680b076