[INFO] fetching crate flowrs 0.2.0... [INFO] checking flowrs-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate flowrs 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate flowrs 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate flowrs 0.2.0 [INFO] finished tweaking crates.io crate flowrs 0.2.0 [INFO] tweaked toml for crates.io crate flowrs 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c4a903e6ab8b56d18bfc548c0971e2cdb5a6176da4d547fbeb50f9837468902 [INFO] running `Command { std: "docker" "start" "-a" "5c4a903e6ab8b56d18bfc548c0971e2cdb5a6176da4d547fbeb50f9837468902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c4a903e6ab8b56d18bfc548c0971e2cdb5a6176da4d547fbeb50f9837468902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c4a903e6ab8b56d18bfc548c0971e2cdb5a6176da4d547fbeb50f9837468902", kill_on_drop: false }` [INFO] [stdout] 5c4a903e6ab8b56d18bfc548c0971e2cdb5a6176da4d547fbeb50f9837468902 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42aa569d05870d9baf5f4cd6c4ec2778df25b998bc63a90636b3acd8f21d2453 [INFO] running `Command { std: "docker" "start" "-a" "42aa569d05870d9baf5f4cd6c4ec2778df25b998bc63a90636b3acd8f21d2453", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling flowrs-derive v0.3.0 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.43 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.43 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking wasm-bindgen-test v0.3.43 [INFO] [stderr] Checking flowrs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/sched/scheduler.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 26 | fn get_next_node_idx(&mut self, info: &SchedulingInfo) -> usize { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `version` are never read [INFO] [stdout] --> src/sched/flow_type.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Flow { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 6 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | version: Version, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `major`, `minor`, and `patch` are never read [INFO] [stdout] --> src/sched/version.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Version { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 3 | major: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 4 | minor: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 5 | patch: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Version` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/connection.rs:76:23 [INFO] [stdout] | [INFO] [stdout] 73 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | receiver: Some(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/sched/scheduler.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 26 | fn get_next_node_idx(&mut self, info: &SchedulingInfo) -> usize { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/connection.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new(context: State ) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Self{ [INFO] [stdout] 108 | edge: Arc::new(Mutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flowrs` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/node.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn to_shared(value: T) -> Arc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Arc::new(Mutex::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/node.rs:58:15 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | State(Arc::new(Mutex::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `version` are never read [INFO] [stdout] --> src/sched/flow_type.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Flow { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 6 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | version: Version, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sched/executor.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn execute(&self, job: impl FnOnce() + Send + 'static) { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | / self.pool [INFO] [stdout] 149 | | .lock() [INFO] [stdout] 150 | | .expect("could not lock thread pool mutex") [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `major`, `minor`, and `patch` are never read [INFO] [stdout] --> src/sched/version.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Version { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 3 | major: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 4 | minor: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 5 | patch: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Version` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/connection.rs:76:23 [INFO] [stdout] | [INFO] [stdout] 73 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | receiver: Some(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/connection.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new(context: State ) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Self{ [INFO] [stdout] 108 | edge: Arc::new(Mutex::new(None)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/node.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn to_shared(value: T) -> Arc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Arc::new(Mutex::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodes/node.rs:58:15 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(inner: S) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | State(Arc::new(Mutex::new(inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sched/executor.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn execute(&self, job: impl FnOnce() + Send + 'static) { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | / self.pool [INFO] [stdout] 149 | | .lock() [INFO] [stdout] 150 | | .expect("could not lock thread pool mutex") [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flowrs` (lib) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "42aa569d05870d9baf5f4cd6c4ec2778df25b998bc63a90636b3acd8f21d2453", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42aa569d05870d9baf5f4cd6c4ec2778df25b998bc63a90636b3acd8f21d2453", kill_on_drop: false }` [INFO] [stdout] 42aa569d05870d9baf5f4cd6c4ec2778df25b998bc63a90636b3acd8f21d2453