[INFO] fetching crate flir_rs 0.1.2... [INFO] checking flir_rs-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate flir_rs 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate flir_rs 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate flir_rs 0.1.2 [INFO] finished tweaking crates.io crate flir_rs 0.1.2 [INFO] tweaked toml for crates.io crate flir_rs 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate flir_rs 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7bfecc68a1738519fea92eba38b6ad32788e2dddc6abaa7127d717ef3b0bfe66 [INFO] running `Command { std: "docker" "start" "-a" "7bfecc68a1738519fea92eba38b6ad32788e2dddc6abaa7127d717ef3b0bfe66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7bfecc68a1738519fea92eba38b6ad32788e2dddc6abaa7127d717ef3b0bfe66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bfecc68a1738519fea92eba38b6ad32788e2dddc6abaa7127d717ef3b0bfe66", kill_on_drop: false }` [INFO] [stdout] 7bfecc68a1738519fea92eba38b6ad32788e2dddc6abaa7127d717ef3b0bfe66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b556aa6860557a79c055be2c9e1e3566cd80dcf308c64c4ad5176b16d22e487 [INFO] running `Command { std: "docker" "start" "-a" "6b556aa6860557a79c055be2c9e1e3566cd80dcf308c64c4ad5176b16d22e487", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking byteordered v0.5.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking img-parts v0.2.3 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling zerocopy-derive v0.3.2 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking zerocopy v0.5.2 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking flir_rs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flir.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 65 | .find_map(|e| e.try_parse_raw_data(&self.data).transpose()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flir.rs:74:27 [INFO] [stdout] | [INFO] [stdout] 74 | .find_map(|e| e.try_parse_camera_params(&self.data).transpose()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flir.rs:268:12 [INFO] [stdout] | [INFO] [stdout] 268 | Ok(Some(Array2::from_shape_vec((height, width), raw_data)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 24 | let image = flir_segment [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(ThermalImage { image, settings }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 150 | Ok(Array2::from_shape_vec((height, width), output)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 126 | fn image_as_float<'a, T, R>(decoder: R) -> Result> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let mut image: Vec = Vec::with_capacity(num_pixels); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(image.into_iter().map(|f| f.into()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 63 | let image = ThermalImage::try_from_rjpeg_path(&filename) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | .context("could not parse flir_rs image: tried FLIR, DJI")?; [INFO] [stdout] 65 | Ok(ThermalInput { filename, image }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 67 | fn try_from_exiftool_json(rdr: R) -> Result>> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(serde_json::from_reader::>(rdr)? [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | .into_iter() [INFO] [stdout] 70 | | .map(|j| j.try_into()) [INFO] [stdout] 71 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 73 | fn stream_from_exiftool_json(rdr: R) -> impl Iterator> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | / Deserializer::from_reader(rdr) [INFO] [stdout] 75 | | .into_iter::() [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 103 | let bar = ProgressBar::new(paths.len() as u64); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let bar_dup = bar.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | / paths [INFO] [stdout] 111 | | .into_par_iter() [INFO] [stdout] 112 | | .map(move |p| { [INFO] [stdout] 113 | | if is_json { [INFO] [stdout] ... | [INFO] [stdout] 129 | | }) [INFO] [stdout] 130 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:131:18 [INFO] [stdout] | [INFO] [stdout] 103 | let bar = ProgressBar::new(paths.len() as u64); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let bar_dup = bar.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | .inspect(move |_| bar_dup.inc(1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:116:72 [INFO] [stdout] | [INFO] [stdout] 116 | .and_then(|f| ThermalInput::try_from_exiftool_json(BufReader::new(f))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flir_rs` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6b556aa6860557a79c055be2c9e1e3566cd80dcf308c64c4ad5176b16d22e487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b556aa6860557a79c055be2c9e1e3566cd80dcf308c64c4ad5176b16d22e487", kill_on_drop: false }` [INFO] [stdout] 6b556aa6860557a79c055be2c9e1e3566cd80dcf308c64c4ad5176b16d22e487