[INFO] fetching crate flinch 0.1.67... [INFO] checking flinch-0.1.67 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate flinch 0.1.67 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate flinch 0.1.67 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate flinch 0.1.67 [INFO] finished tweaking crates.io crate flinch 0.1.67 [INFO] tweaked toml for crates.io crate flinch 0.1.67 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 171 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding anydate v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding virtue v0.0.13 (latest: v0.0.17) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d589d9ab40b24b64f3457097edfe084fe4d944ad1856371f69eeeb8e9a7cca92 [INFO] running `Command { std: "docker" "start" "-a" "d589d9ab40b24b64f3457097edfe084fe4d944ad1856371f69eeeb8e9a7cca92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d589d9ab40b24b64f3457097edfe084fe4d944ad1856371f69eeeb8e9a7cca92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d589d9ab40b24b64f3457097edfe084fe4d944ad1856371f69eeeb8e9a7cca92", kill_on_drop: false }` [INFO] [stdout] d589d9ab40b24b64f3457097edfe084fe4d944ad1856371f69eeeb8e9a7cca92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3886a34b4600ad7aae850dc20732f86113b91fd42a0f6f54be3d6c0abaa1163e [INFO] running `Command { std: "docker" "start" "-a" "3886a34b4600ad7aae850dc20732f86113b91fd42a0f6f54be3d6c0abaa1163e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling virtue v0.0.13 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling bincode_derive v2.0.0-rc.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking paris v1.5.15 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking bincode v2.0.0-rc.3 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking size v0.4.1 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling uuid-macro-internal v1.10.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking sha256 v1.5.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking anydate v0.3.0 [INFO] [stderr] Checking flql v0.2.6 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking flinch v0.1.67 (/opt/rustwide/workdir) [INFO] [stdout] warning: crate-level attribute should be in the root module [INFO] [stdout] --> src/schemas.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(integer_atomics, const_fn_trait_bound)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate-level attribute should be in the root module [INFO] [stdout] --> src/schemas.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(integer_atomics, const_fn_trait_bound)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/persistent.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl Persistent { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn get(&self, k: String) -> sled::Result> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `watching` is never read [INFO] [stdout] --> src/ttl.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Ttl { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 19 | kv: DashMap, [INFO] [stdout] 20 | watching: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ttl` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `config` and `storage` are never read [INFO] [stdout] --> src/schemas.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Schemas { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | config: FlinchCnf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 33 | storage: Db, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/authenticate.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 91 | for map in &self.users.get(user.db.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(map) = &self.users.get(user.db.as_str()) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 91 | if let Some(map) = &self.users.get(user.db.as_str()) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn put(&self, k: K, v: String) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let rf = self.kv.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 43 | | let separated = tokenize(&v); [INFO] [stdout] 44 | | for w in separated { [INFO] [stdout] 45 | | let token = w.to_lowercase(); [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn delete(&self, k: K, v: String) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | trace!("deleting inverted index for key - {}",&k); [INFO] [stdout] 65 | let rf = self.kv.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 67 | | for w in v.split_whitespace() { [INFO] [stdout] 68 | | let token = w.to_lowercase(); [INFO] [stdout] 69 | | if let Some(set) = rf.get_mut(&token) { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 77 | let mut res = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | res.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 98 | let res = DashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | res.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchman.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(chans: Vec>) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | idx: 0, [INFO] [stdout] 20 | | chans, [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/collection.rs:236:43 [INFO] [stdout] | [INFO] [stdout] 236 | if let Some(v) = self.kv.get(k.clone()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/doc.rs:77:38 [INFO] [stdout] | [INFO] [stdout] 77 | if obj.contains_key(f.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/doc.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | ... key: f.clone().to_string(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/doc.rs:82:39 [INFO] [stdout] | [INFO] [stdout] 82 | ... .get(f.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:14:116 [INFO] [stdout] | [INFO] [stdout] 14 | async fn push<'a, T>(&self, col: &'a str, value: T) where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | _______________________________________________--------________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | | if let Ok(col) = self.using(col) { [INFO] [stdout] 16 | | let document = QueryBased::from_str(value.to_string().as_str()).unwrap(); [INFO] [stdout] 17 | | let _ = col.put(col.id(), document).await; [INFO] [stdout] ... | [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:23:130 [INFO] [stdout] | [INFO] [stdout] 23 | async fn save<'a, T>(&self, col: &'a str, key: &'a str, value: T) where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | _____________________________________________________________--------________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | | if let Ok(col) = self.using(col) { [INFO] [stdout] 25 | | let document = QueryBased::from_str(value.to_string().as_str()).unwrap(); [INFO] [stdout] 26 | | let _ = col.put(format!("{}", key), document).await; [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:32:149 [INFO] [stdout] | [INFO] [stdout] 32 | async fn save_with_ttl<'a, T>(&self, col: &'a str, key: &'a str, value: T, ttl: i64) where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | ______________________________________________________________________--------__________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | | if let Ok(col) = self.using(col) { [INFO] [stdout] 34 | | let document = QueryBased::from_str(value.to_string().as_str()).unwrap(); [INFO] [stdout] 35 | | let _ = col.put(format!("{}", key), document).await; [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:114:151 [INFO] [stdout] | [INFO] [stdout] 114 | async fn update_by_index<'a, T>(&self, col: &'a str, index: &'a str, value: T) -> bool where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | __________________________________________________________________________--------________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | | if let Ok(db) = self.using(col) { [INFO] [stdout] 116 | | return match self.find_id_by_index(col,index) { [INFO] [stdout] 117 | | None => false, [INFO] [stdout] ... | [INFO] [stdout] 131 | | false [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flinch` (lib test) due to 10 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `get` is never used [INFO] [stdout] --> src/persistent.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl Persistent { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn get(&self, k: String) -> sled::Result> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `watching` is never read [INFO] [stdout] --> src/ttl.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Ttl { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 19 | kv: DashMap, [INFO] [stdout] 20 | watching: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ttl` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `config` and `storage` are never read [INFO] [stdout] --> src/schemas.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Schemas { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | config: FlinchCnf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 33 | storage: Db, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/authenticate.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 91 | for map in &self.users.get(user.db.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(map) = &self.users.get(user.db.as_str()) { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 91 | if let Some(map) = &self.users.get(user.db.as_str()) { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn put(&self, k: K, v: String) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let rf = self.kv.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 43 | | let separated = tokenize(&v); [INFO] [stdout] 44 | | for w in separated { [INFO] [stdout] 45 | | let token = w.to_lowercase(); [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn delete(&self, k: K, v: String) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | trace!("deleting inverted index for key - {}",&k); [INFO] [stdout] 65 | let rf = self.kv.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 67 | | for w in v.split_whitespace() { [INFO] [stdout] 68 | | let token = w.to_lowercase(); [INFO] [stdout] 69 | | if let Some(set) = rf.get_mut(&token) { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 77 | let mut res = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | res.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index_fields.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 98 | let res = DashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | res.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/watchman.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(chans: Vec>) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 19 | | idx: 0, [INFO] [stdout] 20 | | chans, [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/collection.rs:236:43 [INFO] [stdout] | [INFO] [stdout] 236 | if let Some(v) = self.kv.get(k.clone()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/doc.rs:77:38 [INFO] [stdout] | [INFO] [stdout] 77 | if obj.contains_key(f.clone()) { [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/doc.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | ... key: f.clone().to_string(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/doc.rs:82:39 [INFO] [stdout] | [INFO] [stdout] 82 | ... .get(f.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:14:116 [INFO] [stdout] | [INFO] [stdout] 14 | async fn push<'a, T>(&self, col: &'a str, value: T) where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | _______________________________________________--------________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | | if let Ok(col) = self.using(col) { [INFO] [stdout] 16 | | let document = QueryBased::from_str(value.to_string().as_str()).unwrap(); [INFO] [stdout] 17 | | let _ = col.put(col.id(), document).await; [INFO] [stdout] ... | [INFO] [stdout] 20 | | } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:23:130 [INFO] [stdout] | [INFO] [stdout] 23 | async fn save<'a, T>(&self, col: &'a str, key: &'a str, value: T) where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | _____________________________________________________________--------________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | | if let Ok(col) = self.using(col) { [INFO] [stdout] 25 | | let document = QueryBased::from_str(value.to_string().as_str()).unwrap(); [INFO] [stdout] 26 | | let _ = col.put(format!("{}", key), document).await; [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:32:149 [INFO] [stdout] | [INFO] [stdout] 32 | async fn save_with_ttl<'a, T>(&self, col: &'a str, key: &'a str, value: T, ttl: i64) where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | ______________________________________________________________________--------__________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | | if let Ok(col) = self.using(col) { [INFO] [stdout] 34 | | let document = QueryBased::from_str(value.to_string().as_str()).unwrap(); [INFO] [stdout] 35 | | let _ = col.put(format!("{}", key), document).await; [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/flinch_ext.rs:114:151 [INFO] [stdout] | [INFO] [stdout] 114 | async fn update_by_index<'a, T>(&self, col: &'a str, index: &'a str, value: T) -> bool where T: Serialize + Deserialize<'a> + Sync + Send + ToString { [INFO] [stdout] | __________________________________________________________________________--------________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | | if let Ok(db) = self.using(col) { [INFO] [stdout] 116 | | return match self.find_id_by_index(col,index) { [INFO] [stdout] 117 | | None => false, [INFO] [stdout] ... | [INFO] [stdout] 131 | | false [INFO] [stdout] 132 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flinch` (lib) due to 10 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3886a34b4600ad7aae850dc20732f86113b91fd42a0f6f54be3d6c0abaa1163e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3886a34b4600ad7aae850dc20732f86113b91fd42a0f6f54be3d6c0abaa1163e", kill_on_drop: false }` [INFO] [stdout] 3886a34b4600ad7aae850dc20732f86113b91fd42a0f6f54be3d6c0abaa1163e