[INFO] fetching crate flic 0.1.6... [INFO] checking flic-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate flic 0.1.6 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate flic 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate flic 0.1.6 [INFO] finished tweaking crates.io crate flic 0.1.6 [INFO] tweaked toml for crates.io crate flic 0.1.6 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.7.0 (latest: v2.6.0) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding num v0.1.42 (latest: v0.4.3) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding sdl2 v0.30.0 (latest: v0.37.0) [INFO] [stderr] Adding sdl2-sys v0.30.0 (latest: v0.37.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d28d514f837694e4bf2acb9a8ae4d247977a118b2d43f72d08968bff2caa811 [INFO] running `Command { std: "docker" "start" "-a" "8d28d514f837694e4bf2acb9a8ae4d247977a118b2d43f72d08968bff2caa811", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d28d514f837694e4bf2acb9a8ae4d247977a118b2d43f72d08968bff2caa811", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d28d514f837694e4bf2acb9a8ae4d247977a118b2d43f72d08968bff2caa811", kill_on_drop: false }` [INFO] [stdout] 8d28d514f837694e4bf2acb9a8ae4d247977a118b2d43f72d08968bff2caa811 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64728c44eb403184cf836e7d7a0e0b01d2bb21738c510e84b461010d008bf819 [INFO] running `Command { std: "docker" "start" "-a" "64728c44eb403184cf836e7d7a0e0b01d2bb21738c510e84b461010d008bf819", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling sdl2-sys v0.30.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking flic v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/codec/codec007.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let mut row = &mut dst.buf[start..end]; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/codec/codec015.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | let mut row = &mut row[start..end]; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/mod.rs:128:19 [INFO] [stdout] | [INFO] [stdout] 126 | fn new(old: I, new: I) -> Self { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | GroupByEq { [INFO] [stdout] 128 | iter: old.zip(new), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:50:11 [INFO] [stdout] | [INFO] [stdout] 44 | decoder: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | match decoder(src_slice, dst_raster) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:65:11 [INFO] [stdout] | [INFO] [stdout] 60 | encoder: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | match encoder(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flic.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 253 | let mut file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | Ok(FlicFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 258 | | hdr: hdr, [INFO] [stdout] 259 | | frame_hdr: frame_hdr, [INFO] [stdout] 260 | | frame: 0, [INFO] [stdout] ... | [INFO] [stdout] 263 | | file: file, [INFO] [stdout] 264 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flic.rs:454:12 [INFO] [stdout] | [INFO] [stdout] 431 | let mut file = File::create(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 454 | Ok(FlicFileWriter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 455 | | hdr: hdr, [INFO] [stdout] 456 | | offset_frame1: 0, [INFO] [stdout] 457 | | offset_frame2: 0, [INFO] [stdout] 458 | | filename: filename.to_path_buf(), [INFO] [stdout] 459 | | file: Some(file), [INFO] [stdout] 460 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flic.rs:497:12 [INFO] [stdout] | [INFO] [stdout] 476 | let mut file = File::create(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | Ok(FlicFileWriter{ [INFO] [stdout] | ____________^ [INFO] [stdout] 498 | | hdr: hdr, [INFO] [stdout] 499 | | offset_frame1: 0, [INFO] [stdout] 500 | | offset_frame2: 0, [INFO] [stdout] 501 | | filename: filename.to_path_buf(), [INFO] [stdout] 502 | | file: Some(file), [INFO] [stdout] 503 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flic` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "64728c44eb403184cf836e7d7a0e0b01d2bb21738c510e84b461010d008bf819", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64728c44eb403184cf836e7d7a0e0b01d2bb21738c510e84b461010d008bf819", kill_on_drop: false }` [INFO] [stdout] 64728c44eb403184cf836e7d7a0e0b01d2bb21738c510e84b461010d008bf819