[INFO] fetching crate fleetspeak 0.4.1... [INFO] checking fleetspeak-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fleetspeak 0.4.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate fleetspeak 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fleetspeak 0.4.1 [INFO] finished tweaking crates.io crate fleetspeak 0.4.1 [INFO] tweaked toml for crates.io crate fleetspeak 0.4.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate fleetspeak 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59453eeb8535bb214fb2b26721017a3d3db6b3c5d0dc89f56aba89833c40d09b [INFO] running `Command { std: "docker" "start" "-a" "59453eeb8535bb214fb2b26721017a3d3db6b3c5d0dc89f56aba89833c40d09b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59453eeb8535bb214fb2b26721017a3d3db6b3c5d0dc89f56aba89833c40d09b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59453eeb8535bb214fb2b26721017a3d3db6b3c5d0dc89f56aba89833c40d09b", kill_on_drop: false }` [INFO] [stdout] 59453eeb8535bb214fb2b26721017a3d3db6b3c5d0dc89f56aba89833c40d09b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e77c649068d8841a46e8b12728c733e722ecfe2ca7110e5c5dd14b718e311f9 [INFO] running `Command { std: "docker" "start" "-a" "2e77c649068d8841a46e8b12728c733e722ecfe2ca7110e5c5dd14b718e311f9", kill_on_drop: false }` [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling protobuf-codegen v2.28.0 [INFO] [stderr] Compiling protobuf-codegen-pure v2.28.0 [INFO] [stderr] Compiling fleetspeak-proto v0.4.1 [INFO] [stderr] Checking fleetspeak v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | Ok(never) => match never {}, [INFO] [stdout] | ^^^^^^^^^ matches no values because `Never` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:251:11 [INFO] [stdout] | [INFO] [stdout] 246 | fn execute(mutex: &Mutex<&mut std::fs::File>, f: F) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let mut file = mutex.lock().expect("poisoned connection mutex"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | match f(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:349:15 [INFO] [stdout] | [INFO] [stdout] 277 | let guard = mutex.lock() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 295 | let file = unsafe { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | if libc::fcntl(fd, libc::F_GETFD) == -1 { [INFO] [stdout] 297 | let error = std::io::Error::last_os_error(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | Box::leak(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:178:8 [INFO] [stdout] | [INFO] [stdout] 178 | Ok(protobuf::Message::parse_from_bytes(&buf[..])?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fleetspeak` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | Ok(never) => match never {}, [INFO] [stdout] | ^^^^^^^^^ matches no values because `Never` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:251:11 [INFO] [stdout] | [INFO] [stdout] 246 | fn execute(mutex: &Mutex<&mut std::fs::File>, f: F) -> T [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let mut file = mutex.lock().expect("poisoned connection mutex"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | match f(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:349:15 [INFO] [stdout] | [INFO] [stdout] 277 | let guard = mutex.lock() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 295 | let file = unsafe { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | if libc::fcntl(fd, libc::F_GETFD) == -1 { [INFO] [stdout] 297 | let error = std::io::Error::last_os_error(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | Box::leak(Box::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:178:8 [INFO] [stdout] | [INFO] [stdout] 178 | Ok(protobuf::Message::parse_from_bytes(&buf[..])?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fleetspeak` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2e77c649068d8841a46e8b12728c733e722ecfe2ca7110e5c5dd14b718e311f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e77c649068d8841a46e8b12728c733e722ecfe2ca7110e5c5dd14b718e311f9", kill_on_drop: false }` [INFO] [stdout] 2e77c649068d8841a46e8b12728c733e722ecfe2ca7110e5c5dd14b718e311f9