[INFO] fetching crate flax-derive 0.7.1... [INFO] checking flax-derive-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate flax-derive 0.7.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate flax-derive 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate flax-derive 0.7.1 [INFO] finished tweaking crates.io crate flax-derive 0.7.1 [INFO] tweaked toml for crates.io crate flax-derive 0.7.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding glam v0.24.2 (latest: v0.29.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding proc-macro-crate v2.0.2 (latest: v3.2.0) [INFO] [stderr] Adding toml_datetime v0.6.3 (latest: v0.6.8) [INFO] [stderr] Adding toml_edit v0.20.2 (latest: v0.22.20) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64b6b2c88bf2fd5783a6962d3901fbcd395a2aeb6c007d38abc51a4552bb1e92 [INFO] running `Command { std: "docker" "start" "-a" "64b6b2c88bf2fd5783a6962d3901fbcd395a2aeb6c007d38abc51a4552bb1e92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64b6b2c88bf2fd5783a6962d3901fbcd395a2aeb6c007d38abc51a4552bb1e92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64b6b2c88bf2fd5783a6962d3901fbcd395a2aeb6c007d38abc51a4552bb1e92", kill_on_drop: false }` [INFO] [stdout] 64b6b2c88bf2fd5783a6962d3901fbcd395a2aeb6c007d38abc51a4552bb1e92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a05a8a17ae97ba53ef17f39434ea0c775fef89d73346a26813b3bb9ef6aa57af [INFO] running `Command { std: "docker" "start" "-a" "a05a8a17ae97ba53ef17f39434ea0c775fef89d73346a26813b3bb9ef6aa57af", kill_on_drop: false }` [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking toml_edit v0.20.2 [INFO] [stderr] Checking proc-macro-crate v2.0.2 [INFO] [stderr] Checking flax-derive v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn derive_fetch(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let crate_name = match proc_macro_crate::crate_name("flax").expect("Failed to get crate name") { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | do_derive_fetch(crate_name, input.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:251:37 [INFO] [stdout] | [INFO] [stdout] 251 | .map(|v| GenericParam::Type(TypeParam::from(v))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:601:12 [INFO] [stdout] | [INFO] [stdout] 587 | let fetch_name = input.ident.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 588 | [INFO] [stdout] 589 | let w_lf = LifetimeParam::new(Lifetime::new("'w", Span::call_site())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | let q_lf = LifetimeParam::new(Lifetime::new("'q", Span::call_site())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 601 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 602 | | crate_name, [INFO] [stdout] 603 | | vis, [INFO] [stdout] 604 | | generics: &input.generics, [INFO] [stdout] ... | [INFO] [stdout] 621 | | ), [INFO] [stdout] 622 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flax-derive` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn derive_fetch(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let crate_name = match proc_macro_crate::crate_name("flax").expect("Failed to get crate name") { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | do_derive_fetch(crate_name, input.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:251:37 [INFO] [stdout] | [INFO] [stdout] 251 | .map(|v| GenericParam::Type(TypeParam::from(v))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:601:12 [INFO] [stdout] | [INFO] [stdout] 587 | let fetch_name = input.ident.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 588 | [INFO] [stdout] 589 | let w_lf = LifetimeParam::new(Lifetime::new("'w", Span::call_site())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | let q_lf = LifetimeParam::new(Lifetime::new("'q", Span::call_site())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 601 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 602 | | crate_name, [INFO] [stdout] 603 | | vis, [INFO] [stdout] 604 | | generics: &input.generics, [INFO] [stdout] ... | [INFO] [stdout] 621 | | ), [INFO] [stdout] 622 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flax-derive` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "a05a8a17ae97ba53ef17f39434ea0c775fef89d73346a26813b3bb9ef6aa57af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a05a8a17ae97ba53ef17f39434ea0c775fef89d73346a26813b3bb9ef6aa57af", kill_on_drop: false }` [INFO] [stdout] a05a8a17ae97ba53ef17f39434ea0c775fef89d73346a26813b3bb9ef6aa57af