[INFO] fetching crate flat_device_tree 3.1.1... [INFO] checking flat_device_tree-3.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate flat_device_tree 3.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate flat_device_tree 3.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate flat_device_tree 3.1.1 [INFO] finished tweaking crates.io crate flat_device_tree 3.1.1 [INFO] tweaked toml for crates.io crate flat_device_tree 3.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate flat_device_tree 3.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69ebc1fbc1a8fc78b4041febbd4a183f105f694fb2f1330889525169247b0e28 [INFO] running `Command { std: "docker" "start" "-a" "69ebc1fbc1a8fc78b4041febbd4a183f105f694fb2f1330889525169247b0e28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69ebc1fbc1a8fc78b4041febbd4a183f105f694fb2f1330889525169247b0e28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69ebc1fbc1a8fc78b4041febbd4a183f105f694fb2f1330889525169247b0e28", kill_on_drop: false }` [INFO] [stdout] 69ebc1fbc1a8fc78b4041febbd4a183f105f694fb2f1330889525169247b0e28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4daa0e44062937e4d288d1b028ac9b51967f1addc18a5242b038ef29ccd863b0 [INFO] running `Command { std: "docker" "start" "-a" "4daa0e44062937e4d288d1b028ac9b51967f1addc18a5242b038ef29ccd863b0", kill_on_drop: false }` [INFO] [stderr] Checking flat_device_tree v3.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 228 | let mut cpus = self.find_node("/cpus").map(|parent| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | core::iter::from_fn(move || match cpus.as_mut() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 239 | | Some(cpu) => cpu.next(), [INFO] [stdout] 240 | | None => None, [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:295:47 [INFO] [stdout] | [INFO] [stdout] 295 | n.compatible().and_then(|compats| compats.all().find(|c| with.contains(c))).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:357:29 [INFO] [stdout] | [INFO] [stdout] 355 | let mut child_iter = parent.children(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | [INFO] [stdout] 357 | core::iter::from_fn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 358 | | if done || !valid_path || bad_parent { [INFO] [stdout] 359 | | return None; [INFO] [stdout] 360 | | } [INFO] [stdout] ... | [INFO] [stdout] 377 | | ret [INFO] [stdout] 378 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flat_device_tree` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 228 | let mut cpus = self.find_node("/cpus").map(|parent| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | core::iter::from_fn(move || match cpus.as_mut() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 239 | | Some(cpu) => cpu.next(), [INFO] [stdout] 240 | | None => None, [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:295:47 [INFO] [stdout] | [INFO] [stdout] 295 | n.compatible().and_then(|compats| compats.all().find(|c| with.contains(c))).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:357:29 [INFO] [stdout] | [INFO] [stdout] 355 | let mut child_iter = parent.children(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | [INFO] [stdout] 357 | core::iter::from_fn(move || { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 358 | | if done || !valid_path || bad_parent { [INFO] [stdout] 359 | | return None; [INFO] [stdout] 360 | | } [INFO] [stdout] ... | [INFO] [stdout] 377 | | ret [INFO] [stdout] 378 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flat_device_tree` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "4daa0e44062937e4d288d1b028ac9b51967f1addc18a5242b038ef29ccd863b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4daa0e44062937e4d288d1b028ac9b51967f1addc18a5242b038ef29ccd863b0", kill_on_drop: false }` [INFO] [stdout] 4daa0e44062937e4d288d1b028ac9b51967f1addc18a5242b038ef29ccd863b0