[INFO] fetching crate fj-viewer 0.49.0... [INFO] checking fj-viewer-0.49.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fj-viewer 0.49.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate fj-viewer 0.49.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fj-viewer 0.49.0 [INFO] finished tweaking crates.io crate fj-viewer 0.49.0 [INFO] tweaked toml for crates.io crate fj-viewer 0.49.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 165 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding ash v0.37.3+1.3.251 (latest: v0.38.0+1.3.281) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg_aliases v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding core-graphics-types v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding d3d12 v0.19.0 (latest: v22.0.0) [INFO] [stderr] Adding glow v0.13.1 (latest: v0.14.0) [INFO] [stderr] Adding glutin_wgl_sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding gpu-allocator v0.25.0 (latest: v0.27.0) [INFO] [stderr] Adding gpu-descriptor v0.2.4 (latest: v0.3.0) [INFO] [stderr] Adding gpu-descriptor-types v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding libloading v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding malloc_buf v0.0.6 (latest: v1.0.0) [INFO] [stderr] Adding metal v0.27.0 (latest: v0.29.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding naga v0.19.2 (latest: v22.1.0) [INFO] [stderr] Adding nalgebra v0.32.6 (latest: v0.33.0) [INFO] [stderr] Adding ndk-sys v0.5.0+25.2.9519653 (latest: v0.6.0+11769913) [INFO] [stderr] Adding parry2d-f64 v0.13.8 (latest: v0.17.0) [INFO] [stderr] Adding parry3d-f64 v0.13.8 (latest: v0.17.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding simba v0.8.1 (latest: v0.9.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wgpu v0.19.4 (latest: v22.1.0) [INFO] [stderr] Adding wgpu-core v0.19.4 (latest: v22.1.0) [INFO] [stderr] Adding wgpu-hal v0.19.5 (latest: v22.0.0) [INFO] [stderr] Adding wgpu-types v0.19.2 (latest: v22.0.0) [INFO] [stderr] Adding windows v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 73fb6a0e77b28cf5a3bd018d477094c17b365a9a4e745791039a2192a961830b [INFO] running `Command { std: "docker" "start" "-a" "73fb6a0e77b28cf5a3bd018d477094c17b365a9a4e745791039a2192a961830b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "73fb6a0e77b28cf5a3bd018d477094c17b365a9a4e745791039a2192a961830b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73fb6a0e77b28cf5a3bd018d477094c17b365a9a4e745791039a2192a961830b", kill_on_drop: false }` [INFO] [stdout] 73fb6a0e77b28cf5a3bd018d477094c17b365a9a4e745791039a2192a961830b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7fbc0b058e87ba6c80aefb3da57b5f60bae3d2c6f36ba95eccaccd5c73a8b3c [INFO] running `Command { std: "docker" "start" "-a" "f7fbc0b058e87ba6c80aefb3da57b5f60bae3d2c6f36ba95eccaccd5c73a8b3c", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Compiling wgpu-hal v0.19.5 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking unicode-xid v0.2.5 [INFO] [stderr] Compiling wgpu-core v0.19.4 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking wgpu-types v0.19.2 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Compiling wgpu v0.19.4 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking tobj v4.0.2 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking spade v2.12.0 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking naga v0.19.2 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking decorum v0.3.1 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking parry2d-f64 v0.13.8 [INFO] [stderr] Checking parry3d-f64 v0.13.8 [INFO] [stderr] Checking fj-math v0.49.0 [INFO] [stderr] Checking fj-interop v0.49.0 [INFO] [stderr] Checking fj-viewer v0.49.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `name` and `diffuse_texture` are never read [INFO] [stdout] --> src/graphics/model.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Material { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 46 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 47 | pub diffuse_texture: super::texture::Texture, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Material` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/graphics/model.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Mesh { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 53 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mesh` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_mesh` is never used [INFO] [stdout] --> src/graphics/model.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 179 | pub trait DrawModel<'a> { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 180 | fn draw_mesh(&mut self, mesh: &'a Mesh, material: &'a Material); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture` is never read [INFO] [stdout] --> src/graphics/texture.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Texture { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 5 | pub texture: wgpu::Texture, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Texture` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/model.rs:176:8 [INFO] [stdout] | [INFO] [stdout] 96 | let mut materials = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let meshes = models [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Model { meshes, materials }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/texture.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(Self::from_image(device, queue, &img, Some(label))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fj-viewer` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `name` and `diffuse_texture` are never read [INFO] [stdout] --> src/graphics/model.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Material { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 46 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 47 | pub diffuse_texture: super::texture::Texture, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Material` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/graphics/model.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Mesh { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 53 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mesh` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_mesh` is never used [INFO] [stdout] --> src/graphics/model.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 179 | pub trait DrawModel<'a> { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 180 | fn draw_mesh(&mut self, mesh: &'a Mesh, material: &'a Material); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture` is never read [INFO] [stdout] --> src/graphics/texture.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Texture { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 5 | pub texture: wgpu::Texture, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Texture` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/model.rs:176:8 [INFO] [stdout] | [INFO] [stdout] 96 | let mut materials = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let meshes = models [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Model { meshes, materials }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/texture.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(Self::from_image(device, queue, &img, Some(label))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fj-viewer` (lib) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f7fbc0b058e87ba6c80aefb3da57b5f60bae3d2c6f36ba95eccaccd5c73a8b3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7fbc0b058e87ba6c80aefb3da57b5f60bae3d2c6f36ba95eccaccd5c73a8b3c", kill_on_drop: false }` [INFO] [stdout] f7fbc0b058e87ba6c80aefb3da57b5f60bae3d2c6f36ba95eccaccd5c73a8b3c