[INFO] fetching crate fizyr-rpc-macros 0.8.0... [INFO] checking fizyr-rpc-macros-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fizyr-rpc-macros 0.8.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate fizyr-rpc-macros 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fizyr-rpc-macros 0.8.0 [INFO] finished tweaking crates.io crate fizyr-rpc-macros 0.8.0 [INFO] tweaked toml for crates.io crate fizyr-rpc-macros 0.8.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `proc_macro` is deprecated in favor of `proc-macro` and will not work in the 2024 edition [INFO] [stderr] (in the `fizyr_rpc_macros` library target) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3130b0db69ee37b5f5a7fce88ffc8799f816fdb9ff91946f146dc521274d6cc3 [INFO] running `Command { std: "docker" "start" "-a" "3130b0db69ee37b5f5a7fce88ffc8799f816fdb9ff91946f146dc521274d6cc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3130b0db69ee37b5f5a7fce88ffc8799f816fdb9ff91946f146dc521274d6cc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3130b0db69ee37b5f5a7fce88ffc8799f816fdb9ff91946f146dc521274d6cc3", kill_on_drop: false }` [INFO] [stdout] 3130b0db69ee37b5f5a7fce88ffc8799f816fdb9ff91946f146dc521274d6cc3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b7dd273f6b9ad30e01498c1d8d6185f8992fea1294dd7bd0f1d0685c00fa51d [INFO] running `Command { std: "docker" "start" "-a" "0b7dd273f6b9ad30e01498c1d8d6185f8992fea1294dd7bd0f1d0685c00fa51d", kill_on_drop: false }` [INFO] [stderr] warning: `proc_macro` is deprecated in favor of `proc-macro` and will not work in the 2024 edition [INFO] [stderr] (in the `fizyr_rpc_macros` library target) [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking fizyr-rpc-macros v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `hidden` is never used [INFO] [stdout] --> src/interface/parse.rs:123:6 [INFO] [stdout] | [INFO] [stdout] 112 | pub trait MessageDefinition { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 123 | fn hidden(&self) -> Option; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/interface/parse.rs:542:10 [INFO] [stdout] | [INFO] [stdout] 542 | NoBody(syn::token::Comma), [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 542 | NoBody(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/interface/parse.rs:543:21 [INFO] [stdout] | [INFO] [stdout] 543 | Body(ServiceBody, Option), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 543 | Body(ServiceBody, ()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/interface/parse.rs:561:17 [INFO] [stdout] | [INFO] [stdout] 561 | RequestUpdate(keyword::request_update), [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 561 | RequestUpdate(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/interface/parse.rs:562:18 [INFO] [stdout] | [INFO] [stdout] 562 | ResponseUpdate(keyword::response_update), [INFO] [stdout] | -------------- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 562 | ResponseUpdate(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:7:2 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn interface(tokens: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | interface::generate_interface(tokens.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/parse.rs:361:15 [INFO] [stdout] | [INFO] [stdout] 358 | fn from_raw(errors: &mut Vec, raw: raw::UpdateDefinition) -> (raw::UpdateKind, Self) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | (raw.kind, Self { [INFO] [stdout] | ________________________^ [INFO] [stdout] 362 | | service_id: parse_i32(errors, raw.service_id), [INFO] [stdout] 363 | | name: raw.name, [INFO] [stdout] 364 | | doc: attrs.doc, [INFO] [stdout] 365 | | hidden: attrs.hidden, [INFO] [stdout] 366 | | body_type: raw.body_type, [INFO] [stdout] 367 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/parse.rs:588:7 [INFO] [stdout] | [INFO] [stdout] 587 | let body; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 588 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 589 | | attrs: input.call(syn::Attribute::parse_outer)?, [INFO] [stdout] 590 | | visibility: input.parse()?, [INFO] [stdout] 591 | | _interface: input.parse()?, [INFO] [stdout] ... | [INFO] [stdout] 594 | | items: body.call(crate::util::parse_repeated)?, [INFO] [stdout] 595 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/parse.rs:645:7 [INFO] [stdout] | [INFO] [stdout] 644 | let braced; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 645 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 646 | | _brace_token: syn::braced!(braced in input), [INFO] [stdout] 647 | | updates: braced.call(syn::punctuated::Punctuated::parse_terminated)?, [INFO] [stdout] 648 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fizyr-rpc-macros` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `hidden` is never used [INFO] [stdout] --> src/interface/parse.rs:123:6 [INFO] [stdout] | [INFO] [stdout] 112 | pub trait MessageDefinition { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 123 | fn hidden(&self) -> Option; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/interface/parse.rs:542:10 [INFO] [stdout] | [INFO] [stdout] 542 | NoBody(syn::token::Comma), [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 542 | NoBody(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/interface/parse.rs:543:21 [INFO] [stdout] | [INFO] [stdout] 543 | Body(ServiceBody, Option), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 543 | Body(ServiceBody, ()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/interface/parse.rs:561:17 [INFO] [stdout] | [INFO] [stdout] 561 | RequestUpdate(keyword::request_update), [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 561 | RequestUpdate(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/interface/parse.rs:562:18 [INFO] [stdout] | [INFO] [stdout] 562 | ResponseUpdate(keyword::response_update), [INFO] [stdout] | -------------- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 562 | ResponseUpdate(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:7:2 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn interface(tokens: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | interface::generate_interface(tokens.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/parse.rs:361:15 [INFO] [stdout] | [INFO] [stdout] 358 | fn from_raw(errors: &mut Vec, raw: raw::UpdateDefinition) -> (raw::UpdateKind, Self) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | (raw.kind, Self { [INFO] [stdout] | ________________________^ [INFO] [stdout] 362 | | service_id: parse_i32(errors, raw.service_id), [INFO] [stdout] 363 | | name: raw.name, [INFO] [stdout] 364 | | doc: attrs.doc, [INFO] [stdout] 365 | | hidden: attrs.hidden, [INFO] [stdout] 366 | | body_type: raw.body_type, [INFO] [stdout] 367 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/parse.rs:588:7 [INFO] [stdout] | [INFO] [stdout] 587 | let body; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 588 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 589 | | attrs: input.call(syn::Attribute::parse_outer)?, [INFO] [stdout] 590 | | visibility: input.parse()?, [INFO] [stdout] 591 | | _interface: input.parse()?, [INFO] [stdout] ... | [INFO] [stdout] 594 | | items: body.call(crate::util::parse_repeated)?, [INFO] [stdout] 595 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface/parse.rs:645:7 [INFO] [stdout] | [INFO] [stdout] 644 | let braced; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 645 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 646 | | _brace_token: syn::braced!(braced in input), [INFO] [stdout] 647 | | updates: braced.call(syn::punctuated::Punctuated::parse_terminated)?, [INFO] [stdout] 648 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fizyr-rpc-macros` (lib) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0b7dd273f6b9ad30e01498c1d8d6185f8992fea1294dd7bd0f1d0685c00fa51d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b7dd273f6b9ad30e01498c1d8d6185f8992fea1294dd7bd0f1d0685c00fa51d", kill_on_drop: false }` [INFO] [stdout] 0b7dd273f6b9ad30e01498c1d8d6185f8992fea1294dd7bd0f1d0685c00fa51d