[INFO] fetching crate fitrs 0.5.0... [INFO] checking fitrs-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fitrs 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate fitrs 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fitrs 0.5.0 [INFO] finished tweaking crates.io crate fitrs 0.5.0 [INFO] tweaked toml for crates.io crate fitrs 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9daa7f8ea06d0e63e354fc9e3d8d216b79ded20010ce68dc6ef26e786d7a5b07 [INFO] running `Command { std: "docker" "start" "-a" "9daa7f8ea06d0e63e354fc9e3d8d216b79ded20010ce68dc6ef26e786d7a5b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9daa7f8ea06d0e63e354fc9e3d8d216b79ded20010ce68dc6ef26e786d7a5b07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9daa7f8ea06d0e63e354fc9e3d8d216b79ded20010ce68dc6ef26e786d7a5b07", kill_on_drop: false }` [INFO] [stdout] 9daa7f8ea06d0e63e354fc9e3d8d216b79ded20010ce68dc6ef26e786d7a5b07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f83f65c6042fa15c66dac43092ca757072b8fe01e5af669c03db2e4b90ae9ab5 [INFO] running `Command { std: "docker" "start" "-a" "f83f65c6042fa15c66dac43092ca757072b8fe01e5af669c03db2e4b90ae9ab5", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking fitrs v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/fits.rs:1234:13 [INFO] [stdout] | [INFO] [stdout] 1234 | Comment(HeaderKeyWord, String), [INFO] [stdout] | ------- ^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 1234 | Comment((), ()), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 180 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | File::open(path).map(|file| Fits { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:182:19 [INFO] [stdout] | [INFO] [stdout] 181 | File::open(path).map(|file| Fits { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | file: Arc::new(Mutex::new(file)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 181 | File::open(path).map(|file| Fits { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | file: Arc::new(Mutex::new(file)), [INFO] [stdout] 183 | hdus: RwLock::new(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn create>(path: P, mut primary_hdu: Hdu) -> Result { [INFO] [stdout] | ------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | File::create(path).and_then(|file| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn create>(path: P, mut primary_hdu: Hdu) -> Result { [INFO] [stdout] | ------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | File::create(path).and_then(|file| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 236 | | let file_ptr = Arc::new(Mutex::new(file)); [INFO] [stdout] 237 | | [INFO] [stdout] 238 | | primary_hdu.data_start = 0; [INFO] [stdout] ... | [INFO] [stdout] 246 | | }) [INFO] [stdout] 247 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn create>(path: P, mut primary_hdu: Hdu) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | File::create(path).and_then(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let file_ptr = Arc::new(Mutex::new(file)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | Ok(Fits { [INFO] [stdout] | ________________^ [INFO] [stdout] 243 | | file: file_ptr, [INFO] [stdout] 244 | | hdus: RwLock::new(vec![primary_hdu]), [INFO] [stdout] 245 | | total_hdu_count: RwLock::new(Some(1)), [INFO] [stdout] 246 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:678:36 [INFO] [stdout] | [INFO] [stdout] 668 | fn inner_read_data_force(&self, read: F) -> FitsDataArray [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 674 | let mut file_lock = self.file.as_ref().unwrap().lock().expect("Get file lock"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 678 | FitsDataArray::new(&naxis, read(&mut *file_lock, length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:767:19 [INFO] [stdout] | [INFO] [stdout] 725 | pub fn new(shape: &[usize], data: Vec) -> Hdu { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 767 | file: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fitrs` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/fits.rs:1234:13 [INFO] [stdout] | [INFO] [stdout] 1234 | Comment(HeaderKeyWord, String), [INFO] [stdout] | ------- ^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 1234 | Comment((), ()), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 180 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | File::open(path).map(|file| Fits { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:182:19 [INFO] [stdout] | [INFO] [stdout] 181 | File::open(path).map(|file| Fits { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | file: Arc::new(Mutex::new(file)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 181 | File::open(path).map(|file| Fits { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | file: Arc::new(Mutex::new(file)), [INFO] [stdout] 183 | hdus: RwLock::new(Vec::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn create>(path: P, mut primary_hdu: Hdu) -> Result { [INFO] [stdout] | ------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | File::create(path).and_then(|file| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:235:37 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn create>(path: P, mut primary_hdu: Hdu) -> Result { [INFO] [stdout] | ------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | File::create(path).and_then(|file| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 236 | | let file_ptr = Arc::new(Mutex::new(file)); [INFO] [stdout] 237 | | [INFO] [stdout] 238 | | primary_hdu.data_start = 0; [INFO] [stdout] ... | [INFO] [stdout] 246 | | }) [INFO] [stdout] 247 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn create>(path: P, mut primary_hdu: Hdu) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | File::create(path).and_then(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | let file_ptr = Arc::new(Mutex::new(file)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | Ok(Fits { [INFO] [stdout] | ________________^ [INFO] [stdout] 243 | | file: file_ptr, [INFO] [stdout] 244 | | hdus: RwLock::new(vec![primary_hdu]), [INFO] [stdout] 245 | | total_hdu_count: RwLock::new(Some(1)), [INFO] [stdout] 246 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:678:36 [INFO] [stdout] | [INFO] [stdout] 668 | fn inner_read_data_force(&self, read: F) -> FitsDataArray [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 674 | let mut file_lock = self.file.as_ref().unwrap().lock().expect("Get file lock"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 678 | FitsDataArray::new(&naxis, read(&mut *file_lock, length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fits.rs:767:19 [INFO] [stdout] | [INFO] [stdout] 725 | pub fn new(shape: &[usize], data: Vec) -> Hdu { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 767 | file: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fitrs` (lib test) due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f83f65c6042fa15c66dac43092ca757072b8fe01e5af669c03db2e4b90ae9ab5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f83f65c6042fa15c66dac43092ca757072b8fe01e5af669c03db2e4b90ae9ab5", kill_on_drop: false }` [INFO] [stdout] f83f65c6042fa15c66dac43092ca757072b8fe01e5af669c03db2e4b90ae9ab5