[INFO] fetching crate fitme 1.1.0... [INFO] checking fitme-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fitme 1.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fitme 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fitme 1.1.0 [INFO] finished tweaking crates.io crate fitme 1.1.0 [INFO] tweaked toml for crates.io crate fitme 1.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate fitme 1.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45953fa081b611606ac9a16f0515a6d910a3bbf3d8f8175baaa8b7f517294f3a [INFO] running `Command { std: "docker" "start" "-a" "45953fa081b611606ac9a16f0515a6d910a3bbf3d8f8175baaa8b7f517294f3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45953fa081b611606ac9a16f0515a6d910a3bbf3d8f8175baaa8b7f517294f3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45953fa081b611606ac9a16f0515a6d910a3bbf3d8f8175baaa8b7f517294f3a", kill_on_drop: false }` [INFO] [stdout] 45953fa081b611606ac9a16f0515a6d910a3bbf3d8f8175baaa8b7f517294f3a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e7cabf1c10d82b50ce3e8c75e67f623ece903e4f810aca54b956399c8811cb7 [INFO] running `Command { std: "docker" "start" "-a" "0e7cabf1c10d82b50ce3e8c75e67f623ece903e4f810aca54b956399c8811cb7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling rustix v0.38.14 [INFO] [stderr] Checking linux-raw-sys v0.4.7 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking anstream v0.6.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking is_ci v1.1.1 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking supports-unicode v2.0.0 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking supports-hyperlinks v2.1.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking triple_accel v0.3.4 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking nom v1.2.4 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking meval v0.2.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking numfmt v1.1.1 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking rmpfit v0.2.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking simsearch v0.2.4 [INFO] [stderr] Checking bstr v1.6.2 [INFO] [stderr] Checking predicates v3.0.4 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Checking comfy-table v7.0.1 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking csv v1.2.2 [INFO] [stderr] Checking fitme v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 97 | fn from_iter>(i: I) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | Headers( [INFO] [stdout] 99 | / i.into_iter() [INFO] [stdout] 100 | | .map(|t| t.as_ref().trim().to_string()) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn new(rdr: R) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Self { [INFO] [stdout] 202 | rdr: csv::Reader::from_reader(Box::new(rdr)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:159:20 [INFO] [stdout] | [INFO] [stdout] 159 | .map(|row| row.get_num(tgt).expect("inside data").expect("is number")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:182:26 [INFO] [stdout] | [INFO] [stdout] 182 | .map(|(row, y_)| row.get_num(tgt).expect("inside data").expect("is number") - y_) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 306 | fn write_rich_table(x: &Fit, write_stats: bool, w: impl Write) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | / write_table( [INFO] [stdout] 308 | | x, [INFO] [stdout] 309 | | write_stats, [INFO] [stdout] 310 | | comfy_table::presets::UTF8_HORIZONTAL_ONLY, [INFO] [stdout] 311 | | w, [INFO] [stdout] 312 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:317:5 [INFO] [stdout] | [INFO] [stdout] 316 | fn write_plain_table(x: &Fit, write_stats: bool, w: impl Write) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | write_table(x, write_stats, comfy_table::presets::NOTHING, w).into_diagnostic() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 365 | fn write_md_table(x: &Fit, write_stats: bool, w: impl Write) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | write_table(x, write_stats, comfy_table::presets::ASCII_MARKDOWN, w).into_diagnostic() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fitme` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 97 | fn from_iter>(i: I) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | Headers( [INFO] [stdout] 99 | / i.into_iter() [INFO] [stdout] 100 | | .map(|t| t.as_ref().trim().to_string()) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn new(rdr: R) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Self { [INFO] [stdout] 202 | rdr: csv::Reader::from_reader(Box::new(rdr)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:159:20 [INFO] [stdout] | [INFO] [stdout] 159 | .map(|row| row.get_num(tgt).expect("inside data").expect("is number")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:182:26 [INFO] [stdout] | [INFO] [stdout] 182 | .map(|(row, y_)| row.get_num(tgt).expect("inside data").expect("is number") - y_) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:307:5 [INFO] [stdout] | [INFO] [stdout] 306 | fn write_rich_table(x: &Fit, write_stats: bool, w: impl Write) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | / write_table( [INFO] [stdout] 308 | | x, [INFO] [stdout] 309 | | write_stats, [INFO] [stdout] 310 | | comfy_table::presets::UTF8_HORIZONTAL_ONLY, [INFO] [stdout] 311 | | w, [INFO] [stdout] 312 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:317:5 [INFO] [stdout] | [INFO] [stdout] 316 | fn write_plain_table(x: &Fit, write_stats: bool, w: impl Write) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | write_table(x, write_stats, comfy_table::presets::NOTHING, w).into_diagnostic() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solve.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 365 | fn write_md_table(x: &Fit, write_stats: bool, w: impl Write) -> Result<()> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | write_table(x, write_stats, comfy_table::presets::ASCII_MARKDOWN, w).into_diagnostic() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fitme` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "0e7cabf1c10d82b50ce3e8c75e67f623ece903e4f810aca54b956399c8811cb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e7cabf1c10d82b50ce3e8c75e67f623ece903e4f810aca54b956399c8811cb7", kill_on_drop: false }` [INFO] [stdout] 0e7cabf1c10d82b50ce3e8c75e67f623ece903e4f810aca54b956399c8811cb7