[INFO] fetching crate firewheel 0.0.1... [INFO] checking firewheel-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate firewheel 0.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate firewheel 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate firewheel 0.0.1 [INFO] finished tweaking crates.io crate firewheel 0.0.1 [INFO] tweaked toml for crates.io crate firewheel 0.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding glow v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding keyboard-types v0.6.2 (latest: v0.7.0) [INFO] [stderr] Adding raw-window-handle v0.4.3 (latest: v0.6.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 65942e4dfa3f8d4b05e36aa2defb0e31d7162df17646b47d80f9a5ac3b5c3872 [INFO] running `Command { std: "docker" "start" "-a" "65942e4dfa3f8d4b05e36aa2defb0e31d7162df17646b47d80f9a5ac3b5c3872", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "65942e4dfa3f8d4b05e36aa2defb0e31d7162df17646b47d80f9a5ac3b5c3872", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65942e4dfa3f8d4b05e36aa2defb0e31d7162df17646b47d80f9a5ac3b5c3872", kill_on_drop: false }` [INFO] [stdout] 65942e4dfa3f8d4b05e36aa2defb0e31d7162df17646b47d80f9a5ac3b5c3872 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83c9c910edd44b497f329bb5de7dcde6593ac741ea5f24067757354150ff5f57 [INFO] running `Command { std: "docker" "start" "-a" "83c9c910edd44b497f329bb5de7dcde6593ac741ea5f24067757354150ff5f57", kill_on_drop: false }` [INFO] [stderr] Compiling nanovg-sys v1.0.2 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking glow v0.11.2 [INFO] [stderr] Checking keyboard-types v0.6.2 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking nanovg v1.0.2 [INFO] [stderr] Checking firewheel v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ParentAnchorType` [INFO] [stdout] --> src/canvas.rs:11:45 [INFO] [stdout] | [INFO] [stdout] 11 | ContainerRegionID, EventCapturedStatus, ParentAnchorType, Point, RegionInfo, Size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ParentAnchorType` [INFO] [stdout] --> src/canvas.rs:11:45 [INFO] [stdout] | [INFO] [stdout] 11 | ContainerRegionID, EventCapturedStatus, ParentAnchorType, Point, RegionInfo, Size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_widget` [INFO] [stdout] --> src/canvas.rs:598:29 [INFO] [stdout] | [INFO] [stdout] 598 | if let Some(last_widget) = self.widget_with_text_comp_listen.take() { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_widget` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_widget` [INFO] [stdout] --> src/canvas.rs:598:29 [INFO] [stdout] | [INFO] [stdout] 598 | if let Some(last_widget) = self.widget_with_text_comp_listen.take() { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_widget` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `canvas` [INFO] [stdout] --> src/gl_renderer/canvas_renderer.rs:32:35 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn render(&mut self, canvas: &mut Canvas) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_canvas` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `canvas` [INFO] [stdout] --> src/gl_renderer/canvas_renderer.rs:32:35 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn render(&mut self, canvas: &mut Canvas) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_canvas` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/canvas.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl WeakLayerEntry { [INFO] [stdout] | ----------------------------- associated function in this implementation [INFO] [stdout] 48 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/canvas.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 76 | impl StrongWidgetEntry { [INFO] [stdout] | -------------------------------- associated function in this implementation [INFO] [stdout] 77 | pub fn new(widget: Box>, unique_id: u64) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `pack_layers` is never used [INFO] [stdout] --> src/canvas.rs:811:8 [INFO] [stdout] | [INFO] [stdout] 208 | impl Canvas { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 811 | fn pack_layers(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CanvasRenderer` is never constructed [INFO] [stdout] --> src/gl_renderer/canvas_renderer.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct CanvasRenderer { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `render`, and `clear` are never used [INFO] [stdout] --> src/gl_renderer/canvas_renderer.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl CanvasRenderer { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(gl: Arc, canvas_size: Size, scale_factor: ScaleFactor) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn render(&mut self, canvas: &mut Canvas) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LayerRenderer` is never constructed [INFO] [stdout] --> src/gl_renderer/layer_renderer.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct LayerRenderer {} [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(widget: Box>, unique_id: u64) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Self { [INFO] [stdout] 79 | shared: Rc::new(RefCell::new(widget)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(widget: Box>, unique_id: u64) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | assigned_layer: WeakLayerEntry { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 81 | | shared: Weak::new(), [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:83:30 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(widget: Box>, unique_id: u64) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | assigned_region: WeakRegionTreeEntry::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:463:12 [INFO] [stdout] | [INFO] [stdout] 426 | mut widget: Box>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | let mut layer_entry = if let Some(layer) = self.layers.get(&layer) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 444 | let mut widget_entry = StrongWidgetEntry { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | Ok(WidgetRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 464 | | shared: widget_entry, [INFO] [stdout] 465 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/canvas.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl WeakLayerEntry { [INFO] [stdout] | ----------------------------- associated function in this implementation [INFO] [stdout] 48 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firewheel` (lib) due to 5 previous errors; 9 warnings emitted [INFO] [stdout] warning: method `pack_layers` is never used [INFO] [stdout] --> src/canvas.rs:811:8 [INFO] [stdout] | [INFO] [stdout] 208 | impl Canvas { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 811 | fn pack_layers(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `CanvasRenderer` is never constructed [INFO] [stdout] --> src/gl_renderer/canvas_renderer.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct CanvasRenderer { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `render`, and `clear` are never used [INFO] [stdout] --> src/gl_renderer/canvas_renderer.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl CanvasRenderer { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(gl: Arc, canvas_size: Size, scale_factor: ScaleFactor) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn render(&mut self, canvas: &mut Canvas) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LayerRenderer` is never constructed [INFO] [stdout] --> src/gl_renderer/layer_renderer.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct LayerRenderer {} [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(widget: Box>, unique_id: u64) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Self { [INFO] [stdout] 79 | shared: Rc::new(RefCell::new(widget)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(widget: Box>, unique_id: u64) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | assigned_layer: WeakLayerEntry { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 81 | | shared: Weak::new(), [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:83:30 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(widget: Box>, unique_id: u64) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | assigned_region: WeakRegionTreeEntry::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:463:12 [INFO] [stdout] | [INFO] [stdout] 426 | mut widget: Box>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | let mut layer_entry = if let Some(layer) = self.layers.get(&layer) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 444 | let mut widget_entry = StrongWidgetEntry { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | Ok(WidgetRef { [INFO] [stdout] | ____________^ [INFO] [stdout] 464 | | shared: widget_entry, [INFO] [stdout] 465 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firewheel` (lib test) due to 5 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "83c9c910edd44b497f329bb5de7dcde6593ac741ea5f24067757354150ff5f57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83c9c910edd44b497f329bb5de7dcde6593ac741ea5f24067757354150ff5f57", kill_on_drop: false }` [INFO] [stdout] 83c9c910edd44b497f329bb5de7dcde6593ac741ea5f24067757354150ff5f57