[INFO] fetching crate firewall 0.3.6... [INFO] checking firewall-0.3.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate firewall 0.3.6 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate firewall 0.3.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate firewall 0.3.6 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate firewall 0.3.6 [INFO] tweaked toml for crates.io crate firewall 0.3.6 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate firewall 0.3.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 704bef96ad2efc739f851c629786ad142987913782dce039231c16721a405545 [INFO] running `Command { std: "docker" "start" "-a" "704bef96ad2efc739f851c629786ad142987913782dce039231c16721a405545", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "704bef96ad2efc739f851c629786ad142987913782dce039231c16721a405545", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "704bef96ad2efc739f851c629786ad142987913782dce039231c16721a405545", kill_on_drop: false }` [INFO] [stdout] 704bef96ad2efc739f851c629786ad142987913782dce039231c16721a405545 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5bdb572dc58f32d909778a28b27427c7ebdc058e7c79bd0dedd831ccb1e5ba62 [INFO] running `Command { std: "docker" "start" "-a" "5bdb572dc58f32d909778a28b27427c7ebdc058e7c79bd0dedd831ccb1e5ba62", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking cidr v0.2.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking firewall v0.3.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/mod.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn try_allow_ip_range(self, cidr: impl AsRef) -> Result { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Ok(self.allow_ip_range(parse_cidr(cidr)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/mod.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn try_allow_ip(self, ip: impl AsRef) -> Result { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Ok(self.allow_ip_range(IpCidr::new_host(parse_ip(ip)?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/mod.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn try_deny_ip_range(self, cidr: impl AsRef) -> Result { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Ok(self.deny_ip_range(parse_cidr(cidr)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/mod.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn try_deny_ip(self, ip: impl AsRef) -> Result { [INFO] [stdout] | ---- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(self.deny_ip(parse_ip(ip)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/mod.rs:227:25 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn with_exception(self, exception: R) -> Firewall { [INFO] [stdout] | ---- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | tls_accept: Some(exception), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firewall` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5bdb572dc58f32d909778a28b27427c7ebdc058e7c79bd0dedd831ccb1e5ba62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bdb572dc58f32d909778a28b27427c7ebdc058e7c79bd0dedd831ccb1e5ba62", kill_on_drop: false }` [INFO] [stdout] 5bdb572dc58f32d909778a28b27427c7ebdc058e7c79bd0dedd831ccb1e5ba62