[INFO] fetching crate firefox-rs 0.1.0... [INFO] checking firefox-rs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate firefox-rs 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate firefox-rs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate firefox-rs 0.1.0 [INFO] finished tweaking crates.io crate firefox-rs 0.1.0 [INFO] tweaked toml for crates.io crate firefox-rs 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate firefox-rs 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d8fc9a8db7eb57782ecb1e4bd697f727364dc0bc1ff50f6b842bb1e55529b4d [INFO] running `Command { std: "docker" "start" "-a" "9d8fc9a8db7eb57782ecb1e4bd697f727364dc0bc1ff50f6b842bb1e55529b4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d8fc9a8db7eb57782ecb1e4bd697f727364dc0bc1ff50f6b842bb1e55529b4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d8fc9a8db7eb57782ecb1e4bd697f727364dc0bc1ff50f6b842bb1e55529b4d", kill_on_drop: false }` [INFO] [stdout] 9d8fc9a8db7eb57782ecb1e4bd697f727364dc0bc1ff50f6b842bb1e55529b4d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7cf2ca593aa1eaddb0a4b484fa3bd86f08b53fc250eb8e5a645a62c1c6587e8d [INFO] running `Command { std: "docker" "start" "-a" "7cf2ca593aa1eaddb0a4b484fa3bd86f08b53fc250eb8e5a645a62c1c6587e8d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking lz4_flex v0.9.3 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking firefox-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:88:18 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(ok) => ok, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Err(e) => return Some(ErrorOrIterator::Error(Some(e))), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .filter_map(|entry_res| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let entry = try_eoi!(entry_res); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let iter = read_dir(backups).ok()?.filter_map(|entry_res| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Some(ErrorOrIterator::Iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firefox-rs` (lib test) due to 2 previous errors [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:88:18 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(ok) => ok, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Err(e) => return Some(ErrorOrIterator::Error(Some(e))), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | .filter_map(|entry_res| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let entry = try_eoi!(entry_res); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let iter = read_dir(backups).ok()?.filter_map(|entry_res| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Some(ErrorOrIterator::Iter(iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firefox-rs` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "7cf2ca593aa1eaddb0a4b484fa3bd86f08b53fc250eb8e5a645a62c1c6587e8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7cf2ca593aa1eaddb0a4b484fa3bd86f08b53fc250eb8e5a645a62c1c6587e8d", kill_on_drop: false }` [INFO] [stdout] 7cf2ca593aa1eaddb0a4b484fa3bd86f08b53fc250eb8e5a645a62c1c6587e8d