[INFO] fetching crate firecore-pokedex 0.0.9... [INFO] checking firecore-pokedex-0.0.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate firecore-pokedex 0.0.9 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate firecore-pokedex 0.0.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate firecore-pokedex 0.0.9 [INFO] finished tweaking crates.io crate firecore-pokedex 0.0.9 [INFO] tweaked toml for crates.io crate firecore-pokedex 0.0.9 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding tinystr v0.6.2 (latest: v0.7.6) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] effb08a7214597555e3087eba480c22b7e3547ad8727d8aec31a689abbb2c098 [INFO] running `Command { std: "docker" "start" "-a" "effb08a7214597555e3087eba480c22b7e3547ad8727d8aec31a689abbb2c098", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "effb08a7214597555e3087eba480c22b7e3547ad8727d8aec31a689abbb2c098", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "effb08a7214597555e3087eba480c22b7e3547ad8727d8aec31a689abbb2c098", kill_on_drop: false }` [INFO] [stdout] effb08a7214597555e3087eba480c22b7e3547ad8727d8aec31a689abbb2c098 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b9993b1b1800f4775374b428f8466fd232d50c533fabf58dc4b9008999d2008 [INFO] running `Command { std: "docker" "start" "-a" "2b9993b1b1800f4775374b428f8466fd232d50c533fabf58dc4b9008999d2008", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tinystr v0.6.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking firecore-pokedex v0.0.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn insert(&mut self, v: I) -> Option> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | self.0.insert(v.id().clone(), Arc::from(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:51:39 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn insert(&mut self, v: I) -> Option> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | self.0.insert(v.id().clone(), Arc::from(v)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 96 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | alloc::vec::Vec::::deserialize(deserializer).map(|i| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 97 | alloc::vec::Vec::::deserialize(deserializer).map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | Self( [INFO] [stdout] 99 | / i.into_iter() [INFO] [stdout] 100 | | .map(|i| (i.id().clone(), Arc::new(i))) [INFO] [stdout] 101 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | .map(|i| (i.id().clone(), Arc::new(i))) [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:100:47 [INFO] [stdout] | [INFO] [stdout] 100 | .map(|i| (i.id().clone(), Arc::new(i))) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:95:14 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn init(self, dex: &Dex) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Some(Bag(self [INFO] [stdout] | ______________^ [INFO] [stdout] 96 | | .0 [INFO] [stdout] 97 | | .into_iter() [INFO] [stdout] 98 | | .flat_map(|(i, stack)| stack.init(dex).map(|stack| (i, stack))) [INFO] [stdout] 99 | | .collect())) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:98:36 [INFO] [stdout] | [INFO] [stdout] 98 | .flat_map(|(i, stack)| stack.init(dex).map(|stack| (i, stack))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn uninit(self) -> SavedBag { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Bag(self.0.into_iter().map(|(id, v)| (id, v.uninit())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 116 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Ok(Self( [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | alloc::vec::Vec::>::deserialize(deserializer)? [INFO] [stdout] 119 | | .into_iter() [INFO] [stdout] 120 | | .map(|stack| (stack.item, stack)) [INFO] [stdout] 121 | | .collect(), [INFO] [stdout] 122 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moves/set.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn uninit(self) -> SavedMoveSet { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | MoveSet(self.0.into_iter().map(OwnedMove::uninit).collect(), self.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 139 | levels: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> impl DoubleEndedIterator + 's { [INFO] [stdout] 141 | / self.moves [INFO] [stdout] 142 | | .iter() [INFO] [stdout] 143 | | .filter(move |m| levels.contains(&m.0)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon/owned.rs:258:14 [INFO] [stdout] | [INFO] [stdout] 256 | let moves = self.moves.init(movedex)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let item = self.item.and_then(|ref id| itemdex.try_get(id)); [INFO] [stdout] 258 | Some(OwnedPokemon { [INFO] [stdout] | ______________^ [INFO] [stdout] 259 | | // data: OwnablePokemonData { [INFO] [stdout] 260 | | pokemon: pokemon.clone(), [INFO] [stdout] 261 | | level: self.level, [INFO] [stdout] ... | [INFO] [stdout] 273 | | experience: self.experience, [INFO] [stdout] 274 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon/owned.rs:315:14 [INFO] [stdout] | [INFO] [stdout] 296 | let mut moves = self.moves.init(movedex)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | Some(OwnedPokemon { [INFO] [stdout] | ______________^ [INFO] [stdout] 316 | | // data: OwnablePokemonData { [INFO] [stdout] 317 | | pokemon: pokemon.clone(), [INFO] [stdout] 318 | | level: self.level, [INFO] [stdout] ... | [INFO] [stdout] 330 | | experience: self.experience, [INFO] [stdout] 331 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon/stat.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 161 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | EnumMap::deserialize(deserializer).map(Self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trainer.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 42 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Some(Trainer { [INFO] [stdout] | ______________^ [INFO] [stdout] 49 | | party: { [INFO] [stdout] 50 | | let mut party = Vec::new(); [INFO] [stdout] 51 | | for pokemon in self.party { [INFO] [stdout] ... | [INFO] [stdout] 57 | | money: self.money, [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trainer.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn uninit(self) -> SavedTrainer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | SavedTrainer { [INFO] [stdout] 66 | party: self.party.into_iter().map(|p| p.uninit()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trainer.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn uninit(self) -> SavedTrainer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | bag: self.bag.uninit(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firecore-pokedex` (lib test) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn insert(&mut self, v: I) -> Option> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | self.0.insert(v.id().clone(), Arc::from(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:51:39 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn insert(&mut self, v: I) -> Option> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | self.0.insert(v.id().clone(), Arc::from(v)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 96 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | alloc::vec::Vec::::deserialize(deserializer).map(|i| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 97 | alloc::vec::Vec::::deserialize(deserializer).map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | Self( [INFO] [stdout] 99 | / i.into_iter() [INFO] [stdout] 100 | | .map(|i| (i.id().clone(), Arc::new(i))) [INFO] [stdout] 101 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | .map(|i| (i.id().clone(), Arc::new(i))) [INFO] [stdout] | - ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dex.rs:100:47 [INFO] [stdout] | [INFO] [stdout] 100 | .map(|i| (i.id().clone(), Arc::new(i))) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:95:14 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn init(self, dex: &Dex) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Some(Bag(self [INFO] [stdout] | ______________^ [INFO] [stdout] 96 | | .0 [INFO] [stdout] 97 | | .into_iter() [INFO] [stdout] 98 | | .flat_map(|(i, stack)| stack.init(dex).map(|stack| (i, stack))) [INFO] [stdout] 99 | | .collect())) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:98:36 [INFO] [stdout] | [INFO] [stdout] 98 | .flat_map(|(i, stack)| stack.init(dex).map(|stack| (i, stack))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn uninit(self) -> SavedBag { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Bag(self.0.into_iter().map(|(id, v)| (id, v.uninit())).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/bag.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 116 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Ok(Self( [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | alloc::vec::Vec::>::deserialize(deserializer)? [INFO] [stdout] 119 | | .into_iter() [INFO] [stdout] 120 | | .map(|stack| (stack.item, stack)) [INFO] [stdout] 121 | | .collect(), [INFO] [stdout] 122 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moves/set.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn uninit(self) -> SavedMoveSet { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | MoveSet(self.0.into_iter().map(OwnedMove::uninit).collect(), self.1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 139 | levels: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | ) -> impl DoubleEndedIterator + 's { [INFO] [stdout] 141 | / self.moves [INFO] [stdout] 142 | | .iter() [INFO] [stdout] 143 | | .filter(move |m| levels.contains(&m.0)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon/owned.rs:258:14 [INFO] [stdout] | [INFO] [stdout] 256 | let moves = self.moves.init(movedex)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let item = self.item.and_then(|ref id| itemdex.try_get(id)); [INFO] [stdout] 258 | Some(OwnedPokemon { [INFO] [stdout] | ______________^ [INFO] [stdout] 259 | | // data: OwnablePokemonData { [INFO] [stdout] 260 | | pokemon: pokemon.clone(), [INFO] [stdout] 261 | | level: self.level, [INFO] [stdout] ... | [INFO] [stdout] 273 | | experience: self.experience, [INFO] [stdout] 274 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon/owned.rs:315:14 [INFO] [stdout] | [INFO] [stdout] 296 | let mut moves = self.moves.init(movedex)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | Some(OwnedPokemon { [INFO] [stdout] | ______________^ [INFO] [stdout] 316 | | // data: OwnablePokemonData { [INFO] [stdout] 317 | | pokemon: pokemon.clone(), [INFO] [stdout] 318 | | level: self.level, [INFO] [stdout] ... | [INFO] [stdout] 330 | | experience: self.experience, [INFO] [stdout] 331 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pokemon/stat.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 161 | fn deserialize>(deserializer: D) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | EnumMap::deserialize(deserializer).map(Self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trainer.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 42 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Some(Trainer { [INFO] [stdout] | ______________^ [INFO] [stdout] 49 | | party: { [INFO] [stdout] 50 | | let mut party = Vec::new(); [INFO] [stdout] 51 | | for pokemon in self.party { [INFO] [stdout] ... | [INFO] [stdout] 57 | | money: self.money, [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trainer.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn uninit(self) -> SavedTrainer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | SavedTrainer { [INFO] [stdout] 66 | party: self.party.into_iter().map(|p| p.uninit()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trainer.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn uninit(self) -> SavedTrainer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | bag: self.bag.uninit(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `firecore-pokedex` (lib) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "2b9993b1b1800f4775374b428f8466fd232d50c533fabf58dc4b9008999d2008", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b9993b1b1800f4775374b428f8466fd232d50c533fabf58dc4b9008999d2008", kill_on_drop: false }` [INFO] [stdout] 2b9993b1b1800f4775374b428f8466fd232d50c533fabf58dc4b9008999d2008