[INFO] fetching crate finra-rs 0.1.0... [INFO] checking finra-rs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate finra-rs 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate finra-rs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate finra-rs 0.1.0 [INFO] finished tweaking crates.io crate finra-rs 0.1.0 [INFO] tweaked toml for crates.io crate finra-rs 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate finra-rs 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea2ff93679a303b99bc60ac0ab911e30b29d3ceb2cc5f970720308115ab201c9 [INFO] running `Command { std: "docker" "start" "-a" "ea2ff93679a303b99bc60ac0ab911e30b29d3ceb2cc5f970720308115ab201c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea2ff93679a303b99bc60ac0ab911e30b29d3ceb2cc5f970720308115ab201c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea2ff93679a303b99bc60ac0ab911e30b29d3ceb2cc5f970720308115ab201c9", kill_on_drop: false }` [INFO] [stdout] ea2ff93679a303b99bc60ac0ab911e30b29d3ceb2cc5f970720308115ab201c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6326925994f8d2aee1b47a04ef296d7b2485f671b5b85126e3349158fd688b2 [INFO] running `Command { std: "docker" "start" "-a" "e6326925994f8d2aee1b47a04ef296d7b2485f671b5b85126e3349158fd688b2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking join-string v0.3.0 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking finra-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `limit` is never used [INFO] [stdout] --> src/query.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) trait Query: Serialize { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] 12 | fn limit(&self) -> u64; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finra.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 102 | client_builder: Arc ClientBuilder>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | client_getter: Mutex::new(ClientGetter::Unauthenticated { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 109 | | login_data: LoginData { [INFO] [stdout] 110 | | client_builder, [INFO] [stdout] 111 | | client_id, [INFO] [stdout] 112 | | client_secret, [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pager.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 33 | |state| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::pin(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 35 | | if state.end { [INFO] [stdout] 36 | | return Ok(None); [INFO] [stdout] 37 | | } [INFO] [stdout] ... | [INFO] [stdout] 78 | | ))) [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pager.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 33 | |state| { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let response = state [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let mut rdr = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | csv::ReaderBuilder::new().from_reader(BufReader::new(body.as_bytes())); [INFO] [stdout] 64 | let items: Vec = rdr.deserialize().flatten().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let new_query = state.query.move_cursor(items.len() as u64); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Some(( [INFO] [stdout] | ____________________^ [INFO] [stdout] 71 | | items, [INFO] [stdout] 72 | | PagerState { [INFO] [stdout] 73 | | client: state.client, [INFO] [stdout] ... | [INFO] [stdout] 77 | | }, [INFO] [stdout] 78 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `limit` is never used [INFO] [stdout] --> src/query.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub(crate) trait Query: Serialize { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] 12 | fn limit(&self) -> u64; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finra-rs` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finra.rs:108:28 [INFO] [stdout] | [INFO] [stdout] 102 | client_builder: Arc ClientBuilder>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | client_getter: Mutex::new(ClientGetter::Unauthenticated { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 109 | | login_data: LoginData { [INFO] [stdout] 110 | | client_builder, [INFO] [stdout] 111 | | client_id, [INFO] [stdout] 112 | | client_secret, [INFO] [stdout] 113 | | }, [INFO] [stdout] 114 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pager.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 33 | |state| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::pin(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 35 | | if state.end { [INFO] [stdout] 36 | | return Ok(None); [INFO] [stdout] 37 | | } [INFO] [stdout] ... | [INFO] [stdout] 78 | | ))) [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pager.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 33 | |state| { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let response = state [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let mut rdr = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | csv::ReaderBuilder::new().from_reader(BufReader::new(body.as_bytes())); [INFO] [stdout] 64 | let items: Vec = rdr.deserialize().flatten().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let new_query = state.query.move_cursor(items.len() as u64); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(Some(( [INFO] [stdout] | ____________________^ [INFO] [stdout] 71 | | items, [INFO] [stdout] 72 | | PagerState { [INFO] [stdout] 73 | | client: state.client, [INFO] [stdout] ... | [INFO] [stdout] 77 | | }, [INFO] [stdout] 78 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finra-rs` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e6326925994f8d2aee1b47a04ef296d7b2485f671b5b85126e3349158fd688b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6326925994f8d2aee1b47a04ef296d7b2485f671b5b85126e3349158fd688b2", kill_on_drop: false }` [INFO] [stdout] e6326925994f8d2aee1b47a04ef296d7b2485f671b5b85126e3349158fd688b2