[INFO] fetching crate find_peaks 0.1.5... [INFO] checking find_peaks-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate find_peaks 0.1.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate find_peaks 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate find_peaks 0.1.5 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate find_peaks 0.1.5 [INFO] tweaked toml for crates.io crate find_peaks 0.1.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate find_peaks 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 288d7a78aa83973a5346581ca9ffb8b56fc2bf68af6d5c5068345c8a3704777f [INFO] running `Command { std: "docker" "start" "-a" "288d7a78aa83973a5346581ca9ffb8b56fc2bf68af6d5c5068345c8a3704777f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "288d7a78aa83973a5346581ca9ffb8b56fc2bf68af6d5c5068345c8a3704777f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "288d7a78aa83973a5346581ca9ffb8b56fc2bf68af6d5c5068345c8a3704777f", kill_on_drop: false }` [INFO] [stdout] 288d7a78aa83973a5346581ca9ffb8b56fc2bf68af6d5c5068345c8a3704777f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21edcc93281035d8c00afb9d0143f711e53f9ca02d2b2cc6317dd254de6c524b [INFO] running `Command { std: "docker" "start" "-a" "21edcc93281035d8c00afb9d0143f711e53f9ca02d2b2cc6317dd254de6c524b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.38 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling syn v1.0.94 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling unindent v0.1.9 [INFO] [stderr] Compiling inventory v0.1.11 [INFO] [stderr] Compiling pyo3 v0.13.2 [INFO] [stderr] Checking find_peaks v0.1.5 (/opt/rustwide/workdir) [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn new(position: Range, left_diff: T, right_diff: T) -> Self { [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | height: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 21 | fn new(position: Range, left_diff: T, right_diff: T) -> Self { [INFO] [stdout] | ------------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | prominence: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 163 | let zero = self.zero.clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let (_i, zeroth) = it.next().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let (_i, first) = it.next().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | [INFO] [stdout] 169 | let mut back_diff = first.clone() - zeroth; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | let mut prev = first; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | it.filter_map(move |(i, y)| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 177 | | let ahead_diff = prev.clone() - y.clone(); // positive for downward slope [INFO] [stdout] 178 | | let ahead_inside = limit.is_inside(&ahead_diff); [INFO] [stdout] 179 | | let back_inside = limit.is_inside(&back_diff); [INFO] [stdout] ... | [INFO] [stdout] 204 | | res [INFO] [stdout] 205 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 345 | let peak_height = data[i_left].clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | / match (left_valley_y, right_valley_y) { [INFO] [stdout] 347 | | (None, None) => self.zero.clone().unwrap(), [INFO] [stdout] 348 | | (Some(v), None) => peak_height - v.clone(), [INFO] [stdout] 349 | | (None, Some(v)) => peak_height - v.clone(), [INFO] [stdout] 350 | | (Some(v1), Some(v2)) => peak_height - (if v1.ge(&v2) { v1 } else { v2 }).clone(), [INFO] [stdout] 351 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `find_peaks` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "21edcc93281035d8c00afb9d0143f711e53f9ca02d2b2cc6317dd254de6c524b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21edcc93281035d8c00afb9d0143f711e53f9ca02d2b2cc6317dd254de6c524b", kill_on_drop: false }` [INFO] [stdout] 21edcc93281035d8c00afb9d0143f711e53f9ca02d2b2cc6317dd254de6c524b