[INFO] fetching crate financ 0.4.0... [INFO] checking financ-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate financ 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate financ 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate financ 0.4.0 [INFO] finished tweaking crates.io crate financ 0.4.0 [INFO] tweaked toml for crates.io crate financ 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate financ 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a293e46d37eb9eddec6b18ba60842bea7ebe06c2d415c3dd6dc99bf06d527027 [INFO] running `Command { std: "docker" "start" "-a" "a293e46d37eb9eddec6b18ba60842bea7ebe06c2d415c3dd6dc99bf06d527027", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a293e46d37eb9eddec6b18ba60842bea7ebe06c2d415c3dd6dc99bf06d527027", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a293e46d37eb9eddec6b18ba60842bea7ebe06c2d415c3dd6dc99bf06d527027", kill_on_drop: false }` [INFO] [stdout] a293e46d37eb9eddec6b18ba60842bea7ebe06c2d415c3dd6dc99bf06d527027 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc4b82cf90b9c10b3787ed6a25adf1d419af81aac17fcdd482f4fc48db2f19bd [INFO] running `Command { std: "docker" "start" "-a" "bc4b82cf90b9c10b3787ed6a25adf1d419af81aac17fcdd482f4fc48db2f19bd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling anyhow v1.0.76 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling libsqlite3-sys v0.27.0 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Compiling syn v2.0.42 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking codepage v0.1.1 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking guid-create v0.3.1 [INFO] [stderr] Checking calamine v0.23.1 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.1.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling diesel_derives v2.1.2 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking clap_complete v4.4.4 [INFO] [stderr] Checking diesel v2.1.4 [INFO] [stderr] Checking financ v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external_models.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 113 | let workbook = open_workbook_auto(input_file)?; //.expect("Cannot open file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(SheetDefinition { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | // input_file, [INFO] [stdout] 116 | | workbook, [INFO] [stdout] 117 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/accounts.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 80 | let mut query = accounts::table.into_boxed(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | / query [INFO] [stdout] 102 | | .limit(self.limit) [INFO] [stdout] 103 | | .load::(connection) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/currencies.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 16 | let mut query = commodities.into_boxed(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | / query [INFO] [stdout] 25 | | .limit(self.limit) [INFO] [stdout] 26 | | .load::(connection) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/transactions.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut query = join.into_boxed(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | / query [INFO] [stdout] 64 | | .limit(self.limit) [INFO] [stdout] 65 | | .load::<(Split, Transaction)>(connection) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `financ` (bin "financ") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/external_models.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 113 | let workbook = open_workbook_auto(input_file)?; //.expect("Cannot open file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | Ok(SheetDefinition { [INFO] [stdout] | ____________^ [INFO] [stdout] 115 | | // input_file, [INFO] [stdout] 116 | | workbook, [INFO] [stdout] 117 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/accounts.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 80 | let mut query = accounts::table.into_boxed(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | / query [INFO] [stdout] 102 | | .limit(self.limit) [INFO] [stdout] 103 | | .load::(connection) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/currencies.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 16 | let mut query = commodities.into_boxed(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | / query [INFO] [stdout] 25 | | .limit(self.limit) [INFO] [stdout] 26 | | .load::(connection) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/transactions.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut query = join.into_boxed(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | / query [INFO] [stdout] 64 | | .limit(self.limit) [INFO] [stdout] 65 | | .load::<(Split, Transaction)>(connection) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `financ` (bin "financ" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bc4b82cf90b9c10b3787ed6a25adf1d419af81aac17fcdd482f4fc48db2f19bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc4b82cf90b9c10b3787ed6a25adf1d419af81aac17fcdd482f4fc48db2f19bd", kill_on_drop: false }` [INFO] [stdout] bc4b82cf90b9c10b3787ed6a25adf1d419af81aac17fcdd482f4fc48db2f19bd