[INFO] fetching crate finalfusion-inspector 0.1.0... [INFO] checking finalfusion-inspector-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate finalfusion-inspector 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate finalfusion-inspector 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate finalfusion-inspector 0.1.0 [INFO] finished tweaking crates.io crate finalfusion-inspector 0.1.0 [INFO] tweaked toml for crates.io crate finalfusion-inspector 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate finalfusion-inspector 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c5d87e8ad677da34e075277941c12b1cbad26f3a3b61337dbd35faaeda19db6 [INFO] running `Command { std: "docker" "start" "-a" "0c5d87e8ad677da34e075277941c12b1cbad26f3a3b61337dbd35faaeda19db6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c5d87e8ad677da34e075277941c12b1cbad26f3a3b61337dbd35faaeda19db6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c5d87e8ad677da34e075277941c12b1cbad26f3a3b61337dbd35faaeda19db6", kill_on_drop: false }` [INFO] [stdout] 0c5d87e8ad677da34e075277941c12b1cbad26f3a3b61337dbd35faaeda19db6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] daa5b091783336357fc16ffaa7a0dc181df66287062750615379669e14434e71 [INFO] running `Command { std: "docker" "start" "-a" "daa5b091783336357fc16ffaa7a0dc181df66287062750615379669e14434e71", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling syn v1.0.31 [INFO] [stderr] Compiling pin-project-internal v0.4.22 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.16 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling glib-sys v0.9.1 [INFO] [stderr] Compiling gobject-sys v0.9.1 [INFO] [stderr] Compiling gio-sys v0.9.1 [INFO] [stderr] Compiling pango-sys v0.9.1 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.9.1 [INFO] [stderr] Compiling cairo-sys-rs v0.9.2 [INFO] [stderr] Compiling atk-sys v0.9.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling gdk-sys v0.9.1 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling gio v0.8.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling gtk-sys v0.9.2 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling cairo-rs v0.8.1 [INFO] [stderr] Compiling gdk-pixbuf v0.8.0 [INFO] [stderr] Checking futures-io v0.3.5 [INFO] [stderr] Compiling pango v0.8.0 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Compiling serde v1.0.112 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_pcg v0.2.1 [INFO] [stderr] Compiling atk v0.8.0 [INFO] [stderr] Compiling gdk v0.12.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Compiling gtk v0.8.1 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking stdinout v0.4.1 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling serde_derive v1.0.112 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking pin-project v0.4.22 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking reductive v0.4.0 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking glib v0.9.3 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking finalfusion v0.12.2 [INFO] [stderr] Checking finalfusion-inspector v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/similarity_model.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(embeddings: Rc>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let model = ListStore::new(&[ [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | embeddings: RefCell::new(embeddings), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/subwords_model.rs:23:25 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(embeddings: Rc>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let model = ListStore::new(&[String::static_type(), u64::static_type()]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | embeddings: RefCell::new(embeddings), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/metadata_dialog.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(model: MetadataModel) -> Rc { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let glade_src = include_str!("metadata_dialog.glade"); [INFO] [stdout] 17 | let builder = Builder::new_from_string(glade_src); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let dialog: Dialog = builder [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let metadata_view: TreeView = builder [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Rc::new(MetadataDialog { [INFO] [stdout] | _________________^ [INFO] [stdout] 30 | | inner: dialog, [INFO] [stdout] 31 | | model, [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/similarity_widget.rs:65:63 [INFO] [stdout] | [INFO] [stdout] 65 | clone!(entry, model => move |_| model.similarity(&entry.get_buffer().get_text())), [INFO] [stdout] | ----- ----- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/subwords_widget.rs:77:61 [INFO] [stdout] | [INFO] [stdout] 77 | clone!(entry, model => move |_| model.subwords(&entry.get_buffer().get_text())), [INFO] [stdout] | ----- ----- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finalfusion-inspector` (bin "finalfusion-inspector") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/similarity_model.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(embeddings: Rc>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let model = ListStore::new(&[ [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | embeddings: RefCell::new(embeddings), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/subwords_model.rs:23:25 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(embeddings: Rc>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let model = ListStore::new(&[String::static_type(), u64::static_type()]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | embeddings: RefCell::new(embeddings), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/metadata_dialog.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(model: MetadataModel) -> Rc { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let glade_src = include_str!("metadata_dialog.glade"); [INFO] [stdout] 17 | let builder = Builder::new_from_string(glade_src); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let dialog: Dialog = builder [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let metadata_view: TreeView = builder [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Rc::new(MetadataDialog { [INFO] [stdout] | _________________^ [INFO] [stdout] 30 | | inner: dialog, [INFO] [stdout] 31 | | model, [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/similarity_widget.rs:65:63 [INFO] [stdout] | [INFO] [stdout] 65 | clone!(entry, model => move |_| model.similarity(&entry.get_buffer().get_text())), [INFO] [stdout] | ----- ----- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/subwords_widget.rs:77:61 [INFO] [stdout] | [INFO] [stdout] 77 | clone!(entry, model => move |_| model.subwords(&entry.get_buffer().get_text())), [INFO] [stdout] | ----- ----- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finalfusion-inspector` (bin "finalfusion-inspector" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "daa5b091783336357fc16ffaa7a0dc181df66287062750615379669e14434e71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "daa5b091783336357fc16ffaa7a0dc181df66287062750615379669e14434e71", kill_on_drop: false }` [INFO] [stdout] daa5b091783336357fc16ffaa7a0dc181df66287062750615379669e14434e71