[INFO] fetching crate finalfrontier-utils 0.6.2... [INFO] checking finalfrontier-utils-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate finalfrontier-utils 0.6.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate finalfrontier-utils 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate finalfrontier-utils 0.6.2 [INFO] finished tweaking crates.io crate finalfrontier-utils 0.6.2 [INFO] tweaked toml for crates.io crate finalfrontier-utils 0.6.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate finalfrontier-utils 0.6.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 838af0eddf97e8665e4778b5e967624ce688879ab0f25ee3f72ad170a2cbb6da [INFO] running `Command { std: "docker" "start" "-a" "838af0eddf97e8665e4778b5e967624ce688879ab0f25ee3f72ad170a2cbb6da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "838af0eddf97e8665e4778b5e967624ce688879ab0f25ee3f72ad170a2cbb6da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "838af0eddf97e8665e4778b5e967624ce688879ab0f25ee3f72ad170a2cbb6da", kill_on_drop: false }` [INFO] [stdout] 838af0eddf97e8665e4778b5e967624ce688879ab0f25ee3f72ad170a2cbb6da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 046615e6aad3c9bc126f5313ba37c25b6a300493ed7bba04550b1cd5f0119b73 [INFO] running `Command { std: "docker" "start" "-a" "046615e6aad3c9bc126f5313ba37c25b6a300493ed7bba04550b1cd5f0119b73", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling syn v1.0.7 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Compiling cc v1.0.47 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Compiling ndarray v0.12.1 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking itertools v0.8.1 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking lazy-init v0.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking stdinout v0.4.0 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking parking_lot_core v0.6.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking number_prefix v0.2.8 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking zipf v5.0.1 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Checking console v0.9.1 [INFO] [stderr] Checking indicatif v0.11.0 [INFO] [stderr] Compiling synstructure v0.12.2 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking ndarray-parallel v0.9.1 [INFO] [stderr] Checking ndarray-rand v0.9.0 [INFO] [stderr] Checking hogwild v0.6.1 [INFO] [stderr] Checking reductive v0.2.0 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking conllx v0.11.2 [INFO] [stderr] Checking toml v0.5.5 [INFO] [stderr] Checking finalfusion v0.7.1 [INFO] [stderr] Checking finalfrontier v0.6.2 [INFO] [stderr] Checking finalfrontier-utils v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 22 | let mmap = unsafe { MmapOptions::new().map(&f)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok((mmap, start)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 60 | let mmap = unsafe { MmapOptions::new().map(&f)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok((mmap, start)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(file: File) -> io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let metadata = file.metadata()?; [INFO] [stdout] 18 | let progress = ProgressBar::new(metadata.len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(FileProgress { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | inner: file, [INFO] [stdout] 26 | | progress, [INFO] [stdout] 27 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|v| ModelType::try_from_str(v).or_exit("Cannot parse model type", 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 234 | fn add_depembeds_opts<'a, 'b>(app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | / app.arg( [INFO] [stdout] 236 | | Arg::with_name(CONTEXT_DISCARD) [INFO] [stdout] 237 | | .long("context_discard") [INFO] [stdout] 238 | | .value_name("CONTEXT_THRESHOLD") [INFO] [stdout] ... | [INFO] [stdout] 272 | | .help("Projectivize dependency graphs before training."), [INFO] [stdout] 273 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 234 | fn add_depembeds_opts<'a, 'b>(app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | / Arg::with_name(USE_ROOT) [INFO] [stdout] 276 | | .long("use_root") [INFO] [stdout] 277 | | .help("Use root when extracting dependency contexts."), [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finalfrontier-utils` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 22 | let mmap = unsafe { MmapOptions::new().map(&f)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Ok((mmap, start)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 60 | let mmap = unsafe { MmapOptions::new().map(&f)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok((mmap, start)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(file: File) -> io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let metadata = file.metadata()?; [INFO] [stdout] 18 | let progress = ProgressBar::new(metadata.len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(FileProgress { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | inner: file, [INFO] [stdout] 26 | | progress, [INFO] [stdout] 27 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | .map(|v| ModelType::try_from_str(v).or_exit("Cannot parse model type", 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 234 | fn add_depembeds_opts<'a, 'b>(app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | / app.arg( [INFO] [stdout] 236 | | Arg::with_name(CONTEXT_DISCARD) [INFO] [stdout] 237 | | .long("context_discard") [INFO] [stdout] 238 | | .value_name("CONTEXT_THRESHOLD") [INFO] [stdout] ... | [INFO] [stdout] 272 | | .help("Projectivize dependency graphs before training."), [INFO] [stdout] 273 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 234 | fn add_depembeds_opts<'a, 'b>(app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | / Arg::with_name(USE_ROOT) [INFO] [stdout] 276 | | .long("use_root") [INFO] [stdout] 277 | | .help("Use root when extracting dependency contexts."), [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finalfrontier-utils` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "046615e6aad3c9bc126f5313ba37c25b6a300493ed7bba04550b1cd5f0119b73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "046615e6aad3c9bc126f5313ba37c25b6a300493ed7bba04550b1cd5f0119b73", kill_on_drop: false }` [INFO] [stdout] 046615e6aad3c9bc126f5313ba37c25b6a300493ed7bba04550b1cd5f0119b73