[INFO] fetching crate file_test_runner 0.7.2... [INFO] checking file_test_runner-0.7.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate file_test_runner 0.7.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate file_test_runner 0.7.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate file_test_runner 0.7.2 [INFO] finished tweaking crates.io crate file_test_runner 0.7.2 [INFO] tweaked toml for crates.io crate file_test_runner 0.7.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding deno_terminal v0.1.1 (latest: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9483a8ca77b954008c0b4c74e5e337921a79cdb70fd7f67f9a75c7612c916ffb [INFO] running `Command { std: "docker" "start" "-a" "9483a8ca77b954008c0b4c74e5e337921a79cdb70fd7f67f9a75c7612c916ffb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9483a8ca77b954008c0b4c74e5e337921a79cdb70fd7f67f9a75c7612c916ffb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9483a8ca77b954008c0b4c74e5e337921a79cdb70fd7f67f9a75c7612c916ffb", kill_on_drop: false }` [INFO] [stdout] 9483a8ca77b954008c0b4c74e5e337921a79cdb70fd7f67f9a75c7612c916ffb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93dff8fa203f98c15e29ea7018872313f9fbcbb4a8aecc0f714bacf681a531b2 [INFO] running `Command { std: "docker" "start" "-a" "93dff8fa203f98c15e29ea7018872313f9fbcbb4a8aecc0f714bacf681a531b2", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking deno_terminal v0.1.1 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking file_test_runner v0.7.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/runner.rs:33:42 [INFO] [stdout] | [INFO] [stdout] 33 | type PanicHook = Box; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/runner.rs:33:42 [INFO] [stdout] | [INFO] [stdout] 33 | type PanicHook = Box; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 103 | options: CollectOptions, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> CollectedTestCategory { [INFO] [stdout] 105 | match collect_tests(options) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/strategies/file_test_mapper.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 40 | let mut new_children = Vec::with_capacity(category.children.len()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(CollectedTestCategory { [INFO] [stdout] | ________^ [INFO] [stdout] 53 | | name: category.name, [INFO] [stdout] 54 | | path: category.path, [INFO] [stdout] 55 | | children: new_children, [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:75:38 [INFO] [stdout] | [INFO] [stdout] 73 | func: impl FnOnce() + std::panic::UnwindSafe, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | ) -> Self { [INFO] [stdout] 75 | Self::from_maybe_panic_or_result(|| { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 76 | | func(); [INFO] [stdout] 77 | | TestResult::Passed [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:110:7 [INFO] [stdout] | [INFO] [stdout] 109 | let panic_message = panic_message.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | hook.borrow_mut().replace(Box::new(move |info| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:110:33 [INFO] [stdout] | [INFO] [stdout] 109 | let panic_message = panic_message.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | hook.borrow_mut().replace(Box::new(move |info| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 111 | | let backtrace = capture_backtrace(); [INFO] [stdout] 112 | | panic_message.lock().extend( [INFO] [stdout] 113 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 121 | | ); [INFO] [stdout] 122 | | })) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:143:15 [INFO] [stdout] | [INFO] [stdout] 142 | result.unwrap_or_else(|_| TestResult::Failed { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | output: panic_message.lock().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:496:5 [INFO] [stdout] | [INFO] [stdout] 490 | pub fn queue_test(&self, test: CollectedTest) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 496 | self.sender.send(test).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `file_test_runner` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 103 | options: CollectOptions, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> CollectedTestCategory { [INFO] [stdout] 105 | match collect_tests(options) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection/strategies/file_test_mapper.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 40 | let mut new_children = Vec::with_capacity(category.children.len()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(CollectedTestCategory { [INFO] [stdout] | ________^ [INFO] [stdout] 53 | | name: category.name, [INFO] [stdout] 54 | | path: category.path, [INFO] [stdout] 55 | | children: new_children, [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:75:38 [INFO] [stdout] | [INFO] [stdout] 73 | func: impl FnOnce() + std::panic::UnwindSafe, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | ) -> Self { [INFO] [stdout] 75 | Self::from_maybe_panic_or_result(|| { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 76 | | func(); [INFO] [stdout] 77 | | TestResult::Passed [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:110:7 [INFO] [stdout] | [INFO] [stdout] 109 | let panic_message = panic_message.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | hook.borrow_mut().replace(Box::new(move |info| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:110:33 [INFO] [stdout] | [INFO] [stdout] 109 | let panic_message = panic_message.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | hook.borrow_mut().replace(Box::new(move |info| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 111 | | let backtrace = capture_backtrace(); [INFO] [stdout] 112 | | panic_message.lock().extend( [INFO] [stdout] 113 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 121 | | ); [INFO] [stdout] 122 | | })) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:143:15 [INFO] [stdout] | [INFO] [stdout] 142 | result.unwrap_or_else(|_| TestResult::Failed { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | output: panic_message.lock().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:496:5 [INFO] [stdout] | [INFO] [stdout] 490 | pub fn queue_test(&self, test: CollectedTest) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 496 | self.sender.send(test).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `file_test_runner` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "93dff8fa203f98c15e29ea7018872313f9fbcbb4a8aecc0f714bacf681a531b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93dff8fa203f98c15e29ea7018872313f9fbcbb4a8aecc0f714bacf681a531b2", kill_on_drop: false }` [INFO] [stdout] 93dff8fa203f98c15e29ea7018872313f9fbcbb4a8aecc0f714bacf681a531b2