[INFO] fetching crate file-header 0.1.2... [INFO] checking file-header-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate file-header 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate file-header 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate file-header 0.1.2 [INFO] finished tweaking crates.io crate file-header 0.1.2 [INFO] tweaked toml for crates.io crate file-header 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3967dc5fb3cd5ca183269bf5d8d7806e179cc956fd1131135feb0f83deb6d687 [INFO] running `Command { std: "docker" "start" "-a" "3967dc5fb3cd5ca183269bf5d8d7806e179cc956fd1131135feb0f83deb6d687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3967dc5fb3cd5ca183269bf5d8d7806e179cc956fd1131135feb0f83deb6d687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3967dc5fb3cd5ca183269bf5d8d7806e179cc956fd1131135feb0f83deb6d687", kill_on_drop: false }` [INFO] [stdout] 3967dc5fb3cd5ca183269bf5d8d7806e179cc956fd1131135feb0f83deb6d687 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a73d1028584bb791504f1ce4bc25f979a4139ea05008ad7f9a5faf25864482e [INFO] running `Command { std: "docker" "start" "-a" "2a73d1028584bb791504f1ce4bc25f979a4139ea05008ad7f9a5faf25864482e", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Compiling reword v7.0.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Compiling license v3.5.0+3.25.0 [INFO] [stderr] Checking file-header v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:244:27 [INFO] [stdout] | [INFO] [stdout] 241 | let path_rx = path_rx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let result_tx = result_tx.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | let header = header.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 245 | | for p in path_rx { [INFO] [stdout] 246 | | match fs::File::open(&p).and_then(|mut f| header.header_present(&mut f)) { [INFO] [stdout] 247 | | Ok(header_present) => { [INFO] [stdout] ... | [INFO] [stdout] 270 | | // no more files [INFO] [stdout] 271 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 300 | path_predicate: impl Fn(&path::Path) -> bool, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | header: Header, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let (path_tx, path_rx) = crossbeam::channel::unbounded::(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | find_files(root, path_predicate, path_tx)?; [INFO] [stdout] 306 | / path_rx [INFO] [stdout] 307 | | .into_iter() [INFO] [stdout] 308 | | // keep the errors, or the ones with added headers [INFO] [stdout] 309 | | .filter_map(|p| { [INFO] [stdout] ... | [INFO] [stdout] 324 | | } [INFO] [stdout] 325 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:244:27 [INFO] [stdout] | [INFO] [stdout] 241 | let path_rx = path_rx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | let result_tx = result_tx.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | let header = header.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 245 | | for p in path_rx { [INFO] [stdout] 246 | | match fs::File::open(&p).and_then(|mut f| header.header_present(&mut f)) { [INFO] [stdout] 247 | | Ok(header_present) => { [INFO] [stdout] ... | [INFO] [stdout] 270 | | // no more files [INFO] [stdout] 271 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 300 | path_predicate: impl Fn(&path::Path) -> bool, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | header: Header, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let (path_tx, path_rx) = crossbeam::channel::unbounded::(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | find_files(root, path_predicate, path_tx)?; [INFO] [stdout] 306 | / path_rx [INFO] [stdout] 307 | | .into_iter() [INFO] [stdout] 308 | | // keep the errors, or the ones with added headers [INFO] [stdout] 309 | | .filter_map(|p| { [INFO] [stdout] ... | [INFO] [stdout] 324 | | } [INFO] [stdout] 325 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `file-header` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `file-header` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "2a73d1028584bb791504f1ce4bc25f979a4139ea05008ad7f9a5faf25864482e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a73d1028584bb791504f1ce4bc25f979a4139ea05008ad7f9a5faf25864482e", kill_on_drop: false }` [INFO] [stdout] 2a73d1028584bb791504f1ce4bc25f979a4139ea05008ad7f9a5faf25864482e