[INFO] fetching crate fictionary 0.1.2... [INFO] checking fictionary-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fictionary 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate fictionary 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fictionary 0.1.2 [INFO] finished tweaking crates.io crate fictionary 0.1.2 [INFO] tweaked toml for crates.io crate fictionary 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate fictionary 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1098ce8b61ce58fda9e485a7d4f33fc3034ff225d8fadacf403a5e86ed27e023 [INFO] running `Command { std: "docker" "start" "-a" "1098ce8b61ce58fda9e485a7d4f33fc3034ff225d8fadacf403a5e86ed27e023", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1098ce8b61ce58fda9e485a7d4f33fc3034ff225d8fadacf403a5e86ed27e023", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1098ce8b61ce58fda9e485a7d4f33fc3034ff225d8fadacf403a5e86ed27e023", kill_on_drop: false }` [INFO] [stdout] 1098ce8b61ce58fda9e485a7d4f33fc3034ff225d8fadacf403a5e86ed27e023 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a0bacd091daa697e83efb819989fa81ee1e11ea39d6fef2a5ce70a1804d390a [INFO] running `Command { std: "docker" "start" "-a" "3a0bacd091daa697e83efb819989fa81ee1e11ea39d6fef2a5ce70a1804d390a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling syn v2.0.67 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking cobs v0.2.3 [INFO] [stderr] Checking roff v0.2.1 [INFO] [stderr] Checking embedded-io v0.4.0 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking counter v0.5.7 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking clap_complete v4.5.6 [INFO] [stderr] Checking clap_mangen v0.2.21 [INFO] [stderr] Checking weighted_rand v0.4.2 [INFO] [stderr] Checking postcard v1.0.8 [INFO] [stderr] Checking fictionary v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:266:8 [INFO] [stdout] | [INFO] [stdout] 261 | fn load_charkov(path: impl AsRef) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut reader = io::BufReader::new(fs::File::open(path.as_ref())?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | Ok(from_bytes(&buf)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 269 | fn load_wordfile(path: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let buf = io::BufReader::new(fs::File::open(path.as_ref())?).lines(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let mut result = CharCounter::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok(result.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 145 | fn from(counter: CharCounter) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Self { [INFO] [stdout] 147 | chain: counter [INFO] [stdout] | ____________________^ [INFO] [stdout] 148 | | .counts [INFO] [stdout] 149 | | .into_iter() [INFO] [stdout] 150 | | .map(|(k, v)| (k, CharChooser::from(v))) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fictionary` (bin "fictionary") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:266:8 [INFO] [stdout] | [INFO] [stdout] 261 | fn load_charkov(path: impl AsRef) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut reader = io::BufReader::new(fs::File::open(path.as_ref())?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | Ok(from_bytes(&buf)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 269 | fn load_wordfile(path: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | let buf = io::BufReader::new(fs::File::open(path.as_ref())?).lines(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let mut result = CharCounter::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok(result.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 145 | fn from(counter: CharCounter) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Self { [INFO] [stdout] 147 | chain: counter [INFO] [stdout] | ____________________^ [INFO] [stdout] 148 | | .counts [INFO] [stdout] 149 | | .into_iter() [INFO] [stdout] 150 | | .map(|(k, v)| (k, CharChooser::from(v))) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fictionary` (bin "fictionary" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "3a0bacd091daa697e83efb819989fa81ee1e11ea39d6fef2a5ce70a1804d390a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a0bacd091daa697e83efb819989fa81ee1e11ea39d6fef2a5ce70a1804d390a", kill_on_drop: false }` [INFO] [stdout] 3a0bacd091daa697e83efb819989fa81ee1e11ea39d6fef2a5ce70a1804d390a